From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7012879449257410560 X-Received: by 2002:a1c:23cd:: with SMTP id j196mr2045467wmj.11.1633423775369; Tue, 05 Oct 2021 01:49:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:ef50:: with SMTP id c16ls1257464wrp.3.gmail; Tue, 05 Oct 2021 01:49:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3UFE4o/3rQvJpk6dS554y/T88anpRQ/6/QkcdHbPc3+53Bo4k4LZAhYuKPUaNS7lg5Uo5 X-Received: by 2002:adf:c6c5:: with SMTP id c5mr7409619wrh.46.1633423774492; Tue, 05 Oct 2021 01:49:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633423774; cv=none; d=google.com; s=arc-20160816; b=qaAHJw8E4ENUc3u0ryMXnASFVeDZdS6ohmvkCbn58Z0VxXjgOD94ai2F7RZkl75yTm hRVyTOpVpiKAhohk4QrL5T+iflrDwHIfv4l6PNDpLMckKVhiPD/6dEFa+XNel74E1Sjw Hm5L4hIn0wKdq1cYS32gOHw3wkHMlFtGV5jYXuASHqwhwsMNDVor5O4v/0+6DHD78/AY VsMVFMG01WhikUofaeEARros0hGjNozJ/BCIyucrrRAO120qe8CZ7VeMtX/ZMZTS7wnc gJ/UyApANzTG04mEMoJq81XBtrd4Fq2Li82+k3jzwPJdeExUX93WLXp2B4fOqYHso/jL rymQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=cdh/EqHb4nTsIGjO56yUAFcjuHt7D+93RXqy4F/7OFA=; b=iJZyrCzzRZlQULkXOgUMSg990L34e8oCakHUliU3qy3NgQvzZ55ikOJzcw089R6dme 5ADD6wEto1wWSK2lVEiqMcWEvyQPlGqzKhmNGEr6x0qQtU6MNZ8k+ZSFyGLJhgC3VGaB mGuZgyRFI/RdUdGih5DZc6FNiw0g/mVh6t4Sib3ldyKeqU7bTq12w38pu/ifOZG7nvAH He7mm4sRkAkq9dc/TQailUKBH+dubGZaQ5fq4d4/Op4h3ggAqi9Jh2KbLK9eo+YgrGU8 txVDTDImsPw/T0te1ARD1jWVhmEh5ZEmRYbod2kEaR1Zr3s1MmNH8VBoaIru5nRB5xhN 8DUA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id o16si134313wme.3.2021.10.05.01.49.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Oct 2021 01:49:34 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 1958nYsq028975 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Oct 2021 10:49:34 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 1958nXsa017152; Tue, 5 Oct 2021 10:49:33 +0200 Date: Tue, 5 Oct 2021 10:49:33 +0200 From: Henning Schild To: Uladzimir Bely Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2 2/5] wic-img: Set weak default value for WKS_FILE Message-ID: <20211005104933.7292a750@md1za8fc.ad001.siemens.net> In-Reply-To: <20210928071352.31382-3-ubely@ilbers.de> References: <20210928071352.31382-1-ubely@ilbers.de> <20210928071352.31382-3-ubely@ilbers.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 45JozQh9OZ3F Am Tue, 28 Sep 2021 09:13:49 +0200 schrieb Uladzimir Bely : > In case user lists "wic-img" in IMAGE_TYPE variable, bitbake fails > at early parsing stages because WKS_FILE is not defined at this > moment. > > Signed-off-by: Uladzimir Bely > --- > meta/classes/wic-img.bbclass | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/classes/wic-img.bbclass > b/meta/classes/wic-img.bbclass index d849ad9..50e9819 100644 > --- a/meta/classes/wic-img.bbclass > +++ b/meta/classes/wic-img.bbclass > @@ -6,6 +6,9 @@ > > WKS_FILE_CHECKSUM = "${@'${WKS_FULL_PATH}:%s' % > os.path.exists('${WKS_FULL_PATH}')}" > +# In case user has chosen wic-img in local.conf without mandatory > WKS_FILE, define default +WKS_FILE ??= "sdimage-efi" > + i guess the comment is not needed, should be clear to anyone that this is just a weak default With this you can drop WKS_FILE from some machine confs. Henning > do_copy_wks_template[file-checksums] += "${WKS_FILE_CHECKSUM}" > do_copy_wks_template () { > cp -f '${WKS_TEMPLATE_PATH}' '${WORKDIR}/${WKS_TEMPLATE_FILE}'