From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7012879449257410560 X-Received: by 2002:a1c:7910:: with SMTP id l16mr520766wme.128.1633423962416; Tue, 05 Oct 2021 01:52:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:2051:: with SMTP id g78ls588479wmg.0.canary-gmail; Tue, 05 Oct 2021 01:52:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDR32aLCcntTty2nPrFASJtfYWUaYqGKjLe8lTVH5XLDE4zUR0mHTz1eW3ZU4Pl5Eg9rI7 X-Received: by 2002:a7b:c3cc:: with SMTP id t12mr2090260wmj.34.1633423961552; Tue, 05 Oct 2021 01:52:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633423961; cv=none; d=google.com; s=arc-20160816; b=g3KdPz0Tz/UJwgMAS6tbHql8qCoB0E27HIvaBCo13ZmrgQMSb5O2ZTDFUE9jehZ/n5 l0ow1jKULS63Ih+cpwaIoN6NGcBKGjXRs/AhKk1mW/ER7Ko+Q1G5yzZke3j6jOfsi0FM HlLT5sX1VPOAkCGoZ3ZNkACd9Tw3/6oR4xmrjnfkwzkOST+nNNVvlubjLC/rwYWwPEnI rPq3Ufz+iV5DdkNEqvtczLrNZZs3ctMmRCfyGz7RceO32ppX/DHS+FSjbDXNmr1qa79k HKaneSOoePtJXLyFcQ1I3brt2kBdlcjQdCnehSEaXItyEmh7QIsxRyejknpCpXrxceVc DBsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=c60pSzf6E94K3wd+yXddJbLWmIwBBZEdw6dJ2exl/0I=; b=K4dlby6HAo7XJ1XlYiS9+s5H/wlICkQUy6eKKGjfukE1uhwV9bVDXtRwLDqDkssvsx cQUnQ2gyZWWR947xBtaXIpxWlC0i/j6Jx7VaD/c3nU2wnYqNKOfIQ1ndtlYifBdWxue1 fkzBJzD5FPPcG3hpoSuL7wLEbr/CIq32u8lCHQ/yNc1uk+73PXs/k5+om6ou/Z70GR+m AFdbQzFOWK3UiN0wXhLfoQMwOyScOuj6zSTMWDFAuyC3KhTpP60B3Pk+6elSvbTzYUqJ RAsMlBnMreAu0etfgEl64+/eSqU2LQxnOkRQWJDsj5SBFlw+soNP6EJLQefMsY6r9+kp 5jBg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id g8si1004163wrh.0.2021.10.05.01.52.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Oct 2021 01:52:41 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 1958qfps031023 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Oct 2021 10:52:41 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 1958qemE019011; Tue, 5 Oct 2021 10:52:40 +0200 Date: Tue, 5 Oct 2021 10:52:40 +0200 From: Henning Schild To: Uladzimir Bely Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2 3/5] start_vm: Use the first image type to start VM Message-ID: <20211005105240.64d11d95@md1za8fc.ad001.siemens.net> In-Reply-To: <20210928071352.31382-4-ubely@ilbers.de> References: <20210928071352.31382-1-ubely@ilbers.de> <20210928071352.31382-4-ubely@ilbers.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Gy7+GRBVTkQE Am Tue, 28 Sep 2021 09:13:50 +0200 schrieb Uladzimir Bely : > If there are several image types listed in IMAGE_TYPE, we need > to use the only to start VM. Let first one be the default. > > Signed-off-by: Uladzimir Bely > --- > scripts/start_vm | 2 ++ > testsuite/start_vm.py | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/start_vm b/scripts/start_vm > index 28ada30..77c4244 100755 > --- a/scripts/start_vm > +++ b/scripts/start_vm > @@ -110,6 +110,8 @@ readonly > MACHINE_CONF=$ISARROOT/meta-isar/conf/machine/qemu$ARCH.conf eval > "$(egrep 'MACHINE_SERIAL|QEMU_' $MACHINE_CONF |bb2sh)" > eval $(bitbake -e mc:qemu$ARCH-$DISTRO:isar-image-base | grep > "\(^IMAGE_TYPE=\|^IMAGE_FULLNAME=\)") +# Take first image type for VM > if there are several defined +IMAGE_TYPE=$(echo "$IMAGE_TYPE" | sed > -e 's/\s.*$//') case "$IMAGE_TYPE" in i would find " | awk '{print $1}'" much more readable, in which case the comment can go. Henning > ext4-img) > readonly ROOTFS_IMAGE=$IMAGE_FULLNAME.ext4.img > diff --git a/testsuite/start_vm.py b/testsuite/start_vm.py > index a3e32ac..06fc935 100755 > --- a/testsuite/start_vm.py > +++ b/testsuite/start_vm.py > @@ -28,7 +28,7 @@ def format_qemu_cmdline(arch, build, distro): > extra_args = '' > cpu = [''] > > - image_type = get_bitbake_var(bb_output, 'IMAGE_TYPE') > + image_type = get_bitbake_var(bb_output, 'IMAGE_TYPE').split()[0] > deploy_dir_image = get_bitbake_var(bb_output, 'DEPLOY_DIR_IMAGE') > if image_type == 'ext4-img': > rootfs_image = 'isar-image-base-debian-' + distro + '-qemu' > + arch + '.ext4.img'