From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7012879449257410560 X-Received: by 2002:a05:6512:22d5:: with SMTP id g21mr2206273lfu.544.1633424938787; Tue, 05 Oct 2021 02:08:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3499:: with SMTP id v25ls2282135lfr.0.gmail; Tue, 05 Oct 2021 02:08:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAOHh8g/mS1tERSsfSxQDMmbloZPyGebZHoU+u51mndlW8aPfDYPrlS0W2RcyNLNMUWe31 X-Received: by 2002:a05:6512:2253:: with SMTP id i19mr2260164lfu.480.1633424937757; Tue, 05 Oct 2021 02:08:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633424937; cv=none; d=google.com; s=arc-20160816; b=ctbtWlqG4hzSgrdfaYjTbnTsXjX8w1jwhWJAYsdujnSspElz0BJu75Q9iTNeCkzlm4 rxqtYN/y8c3uR4U0ZLZcIrd8tu8n3zqlXhYgFMnf59i8XYKu/i+Pm58cwgXxxQ44Erid B8C5EggaYj1UD5WyKBSu6Sc/eIvkPgEzouzKQ2MHtLwDgraYIzJwUWdr9+G6HRTqBqdS rIv4a32WKjTuToIG8eat1b+gh0dsknwt92WHEAQ4wpnymmeqiu/Z1RXRERcPvB2Hg1Cq +1/lgKRBXwfDXG0AhVBjjDxk/FoBjwW8eZwuo6icmK2FQFbexO19rR762YKUNEE/O9Zc LdQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=Q/RkunxJzl7UMOcvr+bFPH74RpD4grekN2J/8hHCV+0=; b=DS5boXD0vJWFROb6XnHhJwVV4nvn6HoMa6GOmHrMrY5GVIdDhRsx6rZSbyEXfJhPm2 7tOKe4fW665vphBjahUSvKfOiadYLt6J0bNUy4NSh+N9KCbRdY2Rbwl5lLK6BELs25AL DtsNR02XE/W3W8bOA0mePpWa1nxoUsgLh+5XhwR+sBy7mQUHgLDkNF/8hDfIJfA9Zi/D rjNW0ve5Gay4JLien2ghtklW1AdRa1c9w8gojEFAqnnpuIhP4yh/JiOVNjqVdcIxxOo4 oh+GlRsa8AHaJpWP7qyDEeeX0J8Iy+s2pVknuPzyt+TwdcjuTcSgkg3ZvKHop//m/AH/ hCww== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id i21si262815lfv.2.2021.10.05.02.08.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Oct 2021 02:08:57 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 19598v7j022588 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Oct 2021 11:08:57 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.59]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 19598u9Y030938; Tue, 5 Oct 2021 11:08:56 +0200 Date: Tue, 5 Oct 2021 11:08:56 +0200 From: Henning Schild To: Uladzimir Bely Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2 0/5] Support multiple image types in one build Message-ID: <20211005110856.3cb59475@md1za8fc.ad001.siemens.net> In-Reply-To: <20210928071352.31382-1-ubely@ilbers.de> References: <20210928071352.31382-1-ubely@ilbers.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: HOA6lMkjwCeH In fact having exactly one image type and using multiconfig is already very powerful. We have layers where we have custom image classes which include existing ones and are set as the "main type". That is super flexible already. I am not a fan of mc, but here we have a proposal that seems to want to defeat mc and is lacking a clear motivation. At least i do not fully understand why that change makes sense. The main point could be OE alignment which might be good enough but not really too important. A simple array list is much less flexible. Imagine you want to have a wic-img and an ext4 and your rootfs contains "expand-on-first-boot", meaning wic will grow once on device ... while ext4 might need another ROOTFS_EXTRA/_SIZE. In fact one will likely even have different packages installed depending on the type. While packing the same rootfs into multiple images will work it is much nicer to adapt the content to the type. i.e. a container might need less of an init system/kernel/initrd or filesystem support, a wic will maybe need bootloader bits, and an ext4 will not need expand-on-first-boot (like container as well) Henning Am Tue, 28 Sep 2021 09:13:47 +0200 schrieb Uladzimir Bely : > Changes since v1: > - removed mc:qemuamd64-buster-cpiogz config > - mc:qemuamd64-buster config now includes cpiogz image type > > The patchset makes possible to build several image types for > the specific target by listing all them in IMG_FSTYPES variable. > > This also deprecates using IMG_TYPE variable. > > Uladzimir Bely (5): > image: Make WORKDIR and STAMPs unrelated to IMAGE_TYPE > wic-img: Set weak default value for WKS_FILE > start_vm: Use the first image type to start VM > meta-isar: Rework mc:qemuamd64-buster configs > api: Rename IMAGE_TYPE to IMAGE_FSTYPES > > RECIPE-API-CHANGELOG.md | 5 ++++ > doc/user_manual.md | 23 > +++++++++++-------- meta-isar/conf/local.conf.sample | > 2 -- meta-isar/conf/machine/bananapi.conf | 2 +- > meta-isar/conf/machine/container-amd64.conf | 2 +- > meta-isar/conf/machine/de0-nano-soc.conf | 2 +- > meta-isar/conf/machine/hikey.conf | 2 +- > meta-isar/conf/machine/nand-ubi-demo.conf | 2 +- > meta-isar/conf/machine/nanopi-neo.conf | 2 +- > meta-isar/conf/machine/qemuamd64.conf | 2 +- > meta-isar/conf/machine/qemuarm.conf | 2 +- > meta-isar/conf/machine/qemuarm64.conf | 2 +- > meta-isar/conf/machine/qemui386.conf | 2 +- > meta-isar/conf/machine/qemumipsel.conf | 2 +- > meta-isar/conf/machine/qemuriscv64.conf | 2 +- > meta-isar/conf/machine/rpi.conf | 2 +- > meta-isar/conf/machine/sifive-fu540.conf | 2 +- > meta-isar/conf/machine/stm32mp15x.conf | 2 +- > .../multiconfig/qemuamd64-buster-cpiogz.conf | 9 -------- > .../multiconfig/qemuamd64-buster-tgz.conf | 9 -------- > .../conf/multiconfig/qemuamd64-buster.conf | 2 ++ > meta/classes/image.bbclass | 12 ++++++---- > meta/classes/wic-img.bbclass | 3 +++ > scripts/ci_build.sh | 5 ++-- > scripts/start_vm | 8 ++++--- > testsuite/start_vm.py | 2 +- > 26 files changed, 54 insertions(+), 56 deletions(-) > delete mode 100644 > meta-isar/conf/multiconfig/qemuamd64-buster-cpiogz.conf delete mode > 100644 meta-isar/conf/multiconfig/qemuamd64-buster-tgz.conf >