Re: [PATCH v2 3/4] buildstats: Manage buildstats via USER_CLASSES variable

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 27 Sep 2021 16:17:04 +0200
schrieb Uladzimir Bely <ubely@ilbers.de>:

> Such variable is used in OE, so this patch makes buildstat usage
> similar to OE/Poky.
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  meta-isar/conf/local.conf.sample | 2 ++
>  meta/conf/bitbake.conf           | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/meta-isar/conf/local.conf.sample
> b/meta-isar/conf/local.conf.sample index 88a8175..3f806e2 100644
> --- a/meta-isar/conf/local.conf.sample
> +++ b/meta-isar/conf/local.conf.sample
> @@ -222,5 +222,7 @@ USER_isar[flags] = "system create-home"
>  USER_isar[password] = "isar"
>  USER_isar[flags] += "clear-text-password"
>  
> +USER_CLASSES ?= "buildstats"

Is that the name that OE uses? I find it a bit confusing coming right
after the other USER_ bits, which have a totally different context.

Maybe rename, reorder or add a comment.

Henning

> +
>  # Uncomment the below line to debug WIC.
>  # WIC_CREATE_EXTRA_ARGS += "-D"
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 7f5901d..51af5ca 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -120,4 +120,6 @@ include conf/multiconfig/${BB_CURRENT_MC}.conf
>  include conf/machine/${MACHINE}.conf
>  include conf/distro/${DISTRO}.conf
>  
> +INHERIT += "${USER_CLASSES}"
> +
>  PATCHRESOLVE ?= "noop"