From: Adriaan Schmidt <adriaan.schmidt@siemens.com>
To: isar-users@googlegroups.com
Cc: Adriaan Schmidt <adriaan.schmidt@siemens.com>
Subject: [PATCH v3 04/10] base: remove unneeded "before do_build" task dependencies
Date: Tue, 19 Oct 2021 10:29:07 +0200 [thread overview]
Message-ID: <20211019082913.199818-5-adriaan.schmidt@siemens.com> (raw)
In-Reply-To: <20211019082913.199818-1-adriaan.schmidt@siemens.com>
This makes dependencies more precise, in preparation for
the introduction of caching.
Currently the dependency graph is overspecified, and do_build has
too many explicit dependencies. What happens then is that even
if a package (the output of do_dpkg_build) can be taken from
cache, there are still dependencies that cause the execution of
do_fetch, do_patch etc.
Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
---
meta/classes/base.bbclass | 4 ++--
meta/classes/dpkg-base.bbclass | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 13134ff..fe5bcb0 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -183,7 +183,7 @@ python do_fetch() {
bb.fatal(str(e))
}
-addtask fetch before do_build
+addtask fetch
do_unpack[dirs] = "${WORKDIR}"
@@ -202,7 +202,7 @@ python do_unpack() {
bb.fatal(str(e))
}
-addtask unpack after do_fetch before do_build
+addtask unpack after do_fetch
do_build[noexec] = "1"
do_build () {
diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 2005707..eddf643 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -212,7 +212,7 @@ python do_dpkg_build() {
bb.utils.unlockfile(lock)
}
-addtask dpkg_build before do_build
+addtask dpkg_build
KEEP_INSTALLED_ON_CLEAN ?= "0"
--
2.30.2
next prev parent reply other threads:[~2021-10-19 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 8:29 [PATCH v3 00/10] Add sstate-cache Adriaan Schmidt
2021-10-19 8:29 ` [PATCH v3 01/10] oe imports in central location Adriaan Schmidt
2021-10-19 8:29 ` [PATCH v3 02/10] images: create deploy dir Adriaan Schmidt
2021-10-19 8:29 ` [PATCH v3 03/10] rootfs: recursively depend on packages Adriaan Schmidt
2021-10-19 8:29 ` Adriaan Schmidt [this message]
2021-10-19 8:29 ` [PATCH v3 05/10] dpkg: add explicit dependency to isar-apt Adriaan Schmidt
2021-10-19 8:29 ` [PATCH v3 06/10] meta: add sstate feature from oe Adriaan Schmidt
2021-10-19 8:29 ` [PATCH v3 07/10] sstate: configure Adriaan Schmidt
2021-10-19 8:29 ` [PATCH v3 08/10] sstate: add caching to isar-bootstrap Adriaan Schmidt
2021-10-19 8:29 ` [PATCH v3 09/10] sstate: add caching to rootfs Adriaan Schmidt
2021-10-19 8:29 ` [PATCH v3 10/10] sstate: add caching to debian packages Adriaan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019082913.199818-5-adriaan.schmidt@siemens.com \
--to=adriaan.schmidt@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox