From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7016230395466219520 X-Received: by 2002:a05:6512:150:: with SMTP id m16mr4745223lfo.331.1634632165049; Tue, 19 Oct 2021 01:29:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:982:: with SMTP id b2ls3257328ljq.7.gmail; Tue, 19 Oct 2021 01:29:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOCXwd/AYfC69Lv+CAh2dT9349VpXNpccQNiKKGGnWwlNdEbYDLwMJDiCLSlACBj7/HZAb X-Received: by 2002:a05:651c:1584:: with SMTP id h4mr5302974ljq.208.1634632164011; Tue, 19 Oct 2021 01:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634632164; cv=none; d=google.com; s=arc-20160816; b=lYzL4twFiTSv8r4wNFC2zT4ZB74UwYP89/kGE/H5A6PhjtkeOf3NpL/pdiP9TNAtN8 LJe19q+7BMtOaKGxaQdtnPRKKF1x0xzP13mEC6yJulRXTpq708C3IxioPlBmSBQ8e/7k GXhJz/csPlkghDVuTvbQDollWm1alGuy0JeM0d2oqnrAwJgkdKNjAEJaxS+Xnxu78r/M UVJqwUoG33XrfvtnPsnqw8A+s4aRX675P4ZNBphNbu6AO4VkvAxTSBwV068ncYmAlHBb qOnxwg3dFjhhljAr1zu7ej6N/1I1PB0GV1D7Nx+3wKmxsf23CZgQnx+uMRnExTdwMHRf ytHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=3XAAIVgzAqewjtQglsuEeWhZxOJ9VUQNd9lGiRM5t88=; b=hKQF3PPvFIbnPFh2bwDPhK2Wqswalz9y0yr75nRpQJ+x0biJ7HT9OaqPISu/5zSMmA oBM+xJ9jzg2lUZEcyNnm7Xfyd68cPY3fVlDKVivM2QYmbtlurSRyN3HafivQzxl5rcLm qCVaI8UZrPwReplmtyp+gdVSaasABuSCwGot29ylEgfb+9SmO8w8bws9PBATANXEpCQ3 ru8pMmlG8nQdXi1feflGitC73pueINGhxah3aHMOApylVEs7voaIZHNtdQ4rzUK8VQLW 8YNpsFj8F8UqLWxp977hIK3eoNj6fJBtJ6tjcKyWbrnl9ZOV8P/hGjQpQypQI6s2rFmG yT3w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id c11si322961ljr.8.2021.10.19.01.29.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Oct 2021 01:29:23 -0700 (PDT) Received-SPF: pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 19J8TMBp003459 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 19 Oct 2021 10:29:23 +0200 Received: from random.ppmd.siemens.net (random.ppmd.siemens.net [139.25.68.25]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 19J8TMYB002966; Tue, 19 Oct 2021 10:29:22 +0200 From: Adriaan Schmidt To: isar-users@googlegroups.com Cc: Adriaan Schmidt Subject: [PATCH v3 04/10] base: remove unneeded "before do_build" task dependencies Date: Tue, 19 Oct 2021 10:29:07 +0200 Message-Id: <20211019082913.199818-5-adriaan.schmidt@siemens.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211019082913.199818-1-adriaan.schmidt@siemens.com> References: <20211019082913.199818-1-adriaan.schmidt@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: TzyUT/Cwypol This makes dependencies more precise, in preparation for the introduction of caching. Currently the dependency graph is overspecified, and do_build has too many explicit dependencies. What happens then is that even if a package (the output of do_dpkg_build) can be taken from cache, there are still dependencies that cause the execution of do_fetch, do_patch etc. Signed-off-by: Adriaan Schmidt --- meta/classes/base.bbclass | 4 ++-- meta/classes/dpkg-base.bbclass | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass index 13134ff..fe5bcb0 100644 --- a/meta/classes/base.bbclass +++ b/meta/classes/base.bbclass @@ -183,7 +183,7 @@ python do_fetch() { bb.fatal(str(e)) } -addtask fetch before do_build +addtask fetch do_unpack[dirs] = "${WORKDIR}" @@ -202,7 +202,7 @@ python do_unpack() { bb.fatal(str(e)) } -addtask unpack after do_fetch before do_build +addtask unpack after do_fetch do_build[noexec] = "1" do_build () { diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass index 2005707..eddf643 100644 --- a/meta/classes/dpkg-base.bbclass +++ b/meta/classes/dpkg-base.bbclass @@ -212,7 +212,7 @@ python do_dpkg_build() { bb.utils.unlockfile(lock) } -addtask dpkg_build before do_build +addtask dpkg_build KEEP_INSTALLED_ON_CLEAN ?= "0" -- 2.30.2