Re: [PATCH v2 1/2] CI: install avocado in venv if host does not have it

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 20 Oct 2021 18:32:37 +0200
schrieb Henning Schild <henning.schild@siemens.com>:

> Am Wed, 20 Oct 2021 19:10:48 +0300
> schrieb Anton Mikanovich <amikan@ilbers.de>:
> 
> > On 20.10.21 13:03, Anton Mikanovich wrote:  
> > > From: Henning Schild <henning.schild@siemens.com>
> > >
> > > Avocado packages are currently not available in Debian. Use
> > > virtualenv and pip for sites that do not provide avocado as part
> > > of execution environment. We expect the execution environment to
> > > be Debian-based and to allow us to sudo (true for kas-isar
> > > container).
> > >
> > > Use version 88.0 as the latest working one from pip.
> > >
> > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> > > ---
> > >   scripts/ci_build.sh | 11 +++++++++++
> > >   1 file changed, 11 insertions(+)
> > >
> > > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
> > > index 4534957..32054c4 100755
> > > --- a/scripts/ci_build.sh
> > > +++ b/scripts/ci_build.sh
> > > @@ -14,6 +14,17 @@ export PATH=$PATH:/sbin
> > >   # Go to Isar root
> > >   cd "$(dirname "$0")/.."
> > >   
> > > +# install avocado in virtualenv in case it is not there already
> > > +if ! command -v avocado > /dev/null; then
> > > +    sudo apt-get update -qq
> > > +    sudo apt-get install -y virtualenv
> > > +    rm -rf /tmp/avocado_venv
> > > +    virtualenv --python python3 /tmp/avocado_venv
> > > +    source /tmp/avocado_venv/bin/activate
> > > +    # The latest working version of Avocado framework
> > > +    pip install avocado-framework==88.0
> > > +fi
> > > +
> > >   # Get Avocado build tests path
> > >   BUILD_TEST_DIR="$(pwd)/testsuite/build_test"
> > >       
> > 
> > Applied to next.  
> 
> 
> So the fix was to pin down the version? That will cause maint headache
> ... quality tool and package manager!

But thanks for the quick fix! I gave this to our gitlab to try and
digest. Having a testsuite is a win for sure, even if i still tend to
rant about the choice ... bats or pytest would have been OK as well and
readily available via debian.

Henning

> Henning
>