From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7021779655413727232 X-Received: by 2002:adf:d1ee:: with SMTP id g14mr30733059wrd.264.1635235337883; Tue, 26 Oct 2021 01:02:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:8b92:: with SMTP id o18ls4513178wra.0.gmail; Tue, 26 Oct 2021 01:02:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdNynzNKWqy3paHeAbdVmaJ7sLuD0MuKDZfUnU+iFbZk/ff7Y/ydPlrSxK0wHmvusjX9PQ X-Received: by 2002:adf:8b98:: with SMTP id o24mr29173138wra.302.1635235336871; Tue, 26 Oct 2021 01:02:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635235336; cv=none; d=google.com; s=arc-20160816; b=YYlcADYPk1WcGuo1IWoBgi1adEcD6B411De6RtfEpPeqaGSmJcJzOZwxe6AnuINBHl zBRWouBMDPkdr8cSwyp3js9pswv1w6F+ydXIA6o6xgfgVQWcOJy1s7WsYq/bnCPWEYiA UH9hNME7ew53D1n00SS9xGloqWnW1VcV0jl99WRGyzpGtf7+t4RDYECPUSLlX2s6J46Q 5yq/1ABKfM7hXxbKW8PX5WlmhhZ9c4KfMp/ZsFinN8Q88BJZxtQTnbQ5QU/pfCLUO4iC merhNmgyltzN+M13iVwBGbdUsQmEIozP/8GpODRNCpLbNKCMjtwltZIee+0JpfYSoiru ERpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=UcIvxQY9FT/pcKNSca9nLLy93/wDqIWU6gLRet/sPOc=; b=mWjQjyCURtPcbSGfznL93Wb1UcHdj3CnLVZlbR9y1rY6RkewDigtXnv8lJAMsHWw0b gCloeBWgtF/3OucZhHjnQzK1OE0eMUBMyRl5Z+g+NPN/PSRljBuVoVKRPDskG3ixJz9S y99URJVI8roLQQbFVlqyO9AduY5ERS768EretF9Qy4HnwD1rvFoYlDA3L7X3SOl/PlRy 01gwCGPIjpGPa9oQET/cq6nt+vWQwkeQNfxEuHSNmTI867Me2i507Qnu6NFc+vYCwlLr R3a9fOfnyJW9t255788zdcXwZpxVMJ6ZNH0GX9C0qXD8X7vFcFUQ0Ot/e2Z6bg5pR3WJ qPzg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id a10si1288273wmb.0.2021.10.26.01.02.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Oct 2021 01:02:16 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 19Q82GIk002599 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Oct 2021 10:02:16 +0200 Received: from md1za8fc.ad001.siemens.net ([139.22.32.154]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 19Q82FrA022886; Tue, 26 Oct 2021 10:02:15 +0200 Date: Tue, 26 Oct 2021 10:02:12 +0200 From: Henning Schild To: Anton Mikanovich Cc: , Baurzhan Ismagulov Subject: Re: [PATCH] CI: install avocado debian packages from isar-build.org Message-ID: <20211026100212.2a7afcc6@md1za8fc.ad001.siemens.net> In-Reply-To: <2af99710-e905-1865-021e-a0eeac0c113c@ilbers.de> References: <1634885470-19422-1-git-send-email-amikan@ilbers.de> <20211022075737.6993-1-henning.schild@siemens.com> <2af99710-e905-1865-021e-a0eeac0c113c@ilbers.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: jp5zMw1eiJaf Am Tue, 26 Oct 2021 10:37:00 +0300 schrieb Anton Mikanovich : > 22.10.2021 10:57, Henning Schild wrote: > > Might be better than doing it with pip. So we only need to maintain > > one path while waiting for upsteam debian to ship packages. > > > > Signed-off-by: Henning Schild > > --- > > scripts/ci_build.sh | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh > > index 5ff455e3d77b..ddec9e38cb87 100755 > > --- a/scripts/ci_build.sh > > +++ b/scripts/ci_build.sh > > @@ -14,14 +14,16 @@ export PATH=$PATH:/sbin > > # Go to Isar root > > cd "$(dirname "$0")/.." > > > > -# install avocado in virtualenv in case it is not there already > > +# install avocado in from deb.isar-build.org in case it is not > > there already if ! command -v avocado > /dev/null; then > > sudo apt-get update -qq > > - sudo apt-get install -y virtualenv > > - rm -rf /tmp/avocado_venv > > - virtualenv --python python3 /tmp/avocado_venv > > - source /tmp/avocado_venv/bin/activate > > - pip install avocado-framework > > + sudo apt-get install gnupg2 lsb-release curl -y > > + codename=$( lsb_release -cs ) > > + curl http://deb.isar-build.org/debian-isar.key --output > > /tmp/isar-gpg.pub > > + sudo apt-key add /tmp/isar-gpg.pub > > + echo "deb http://deb.isar-build.org/debian-isar $codename-isar > > main" | sudo tee /etc/apt/sources.list.d/isar.list > /dev/null > > + sudo apt-get update -qq > > + sudo apt-get install -y avocado > > fi > > > > # Get Avocado build tests path > > What is the main difference of this patch and `[PATCH v10 17/17] > ci_build: Install Avocado if needed` (besides distro detection and > apt-get)? Looks pretty much like the way we proposed originally. I think that sums it up, it added distro-detection and uses apt-get. Not sure which you will find easier to maintain. I guess pip might end up being less work, because you can drop the maint of that debian mirror (there is no trace of it in the docs, maybe on your jenkins). While pip is moving "out of control" it will also serve as a detection mechanism if avocado breaks again. I think i would prefer pip after all, seeing the risk also as a chance to keep up to date with little effort. But feel free to take the patch if you want to go the debian route and maintain that repo. (in which case it might be a good idea to write in testsuite/README.md where that deb might be coming from) Henning