public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Adriaan Schmidt <adriaan.schmidt@siemens.com>
To: isar-users@googlegroups.com
Cc: Adriaan Schmidt <adriaan.schmidt@siemens.com>
Subject: [PATCH v4 01/10] oe imports in central location
Date: Tue, 26 Oct 2021 14:28:02 +0200	[thread overview]
Message-ID: <20211026122811.2654125-2-adriaan.schmidt@siemens.com> (raw)
In-Reply-To: <20211026122811.2654125-1-adriaan.schmidt@siemens.com>

Code taken from OE. Allows to import OE modules
without first setting python paths manually.

The reason is that we'd like to take sstate code
unmodified from OE, and here it's expected that
imports of oe and bb modules "just works".

Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
---
 meta/classes/base.bbclass      | 28 ++++++++++++++++++++++++++++
 meta/classes/dpkg-base.bbclass |  5 -----
 meta/classes/patch.bbclass     |  5 -----
 3 files changed, 28 insertions(+), 10 deletions(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 72d4cc0..13134ff 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -21,6 +21,34 @@
 THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
 FILESPATH = "${@base_set_filespath(["${FILE_DIRNAME}/${PF}", "${FILE_DIRNAME}/${P}", "${FILE_DIRNAME}/${PN}", "${FILE_DIRNAME}/files", "${FILE_DIRNAME}"], d)}"
 
+OE_IMPORTS += "os sys time oe.path oe.patch"
+OE_IMPORTS[type] = "list"
+
+def oe_import(d):
+    import sys
+
+    bbpath = d.getVar("BBPATH").split(":")
+    sys.path[0:0] = [os.path.join(dir, "lib") for dir in bbpath]
+
+    def inject(name, value):
+        """Make a python object accessible from the metadata"""
+        if hasattr(bb.utils, "_context"):
+            bb.utils._context[name] = value
+        else:
+            __builtins__[name] = value
+
+    import oe.data
+    for toimport in oe.data.typed_value("OE_IMPORTS", d):
+        try:
+            imported = __import__(toimport)
+            inject(toimport.split(".", 1)[0], imported)
+        except AttributeError as e:
+            bb.error("Error importing OE modules: %s" % str(e))
+    return ""
+
+# We need the oe module name space early (before INHERITs get added)
+OE_IMPORTED := "${@oe_import(d)}"
+
 def get_deb_host_arch():
     import subprocess
     host_arch = subprocess.check_output(
diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 83500da..8a39a6d 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -248,11 +248,6 @@ do_deploy_deb[lockfiles] = "${REPO_ISAR_DIR}/isar.lock"
 do_deploy_deb[dirs] = "${S}"
 
 python do_devshell() {
-    import sys
-
-    oe_lib_path = os.path.join(d.getVar('LAYERDIR_core'), 'lib')
-    sys.path.insert(0, oe_lib_path)
-
     bb.build.exec_func('dpkg_do_mounts', d)
 
     isar_export_proxies(d)
diff --git a/meta/classes/patch.bbclass b/meta/classes/patch.bbclass
index 3060755..2337693 100644
--- a/meta/classes/patch.bbclass
+++ b/meta/classes/patch.bbclass
@@ -92,11 +92,6 @@ def should_apply(parm, d):
 should_apply[vardepsexclude] = "DATE SRCDATE"
 
 python patch_do_patch() {
-    import sys
-
-    oe_lib_path = os.path.join(d.getVar('LAYERDIR_core'), 'lib')
-    sys.path.insert(0, oe_lib_path)
-
     import oe.patch
 
     patchsetmap = {
-- 
2.30.2


  reply	other threads:[~2021-10-26 12:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 12:28 [PATCH v4 00/10] Add sstate-cache Adriaan Schmidt
2021-10-26 12:28 ` Adriaan Schmidt [this message]
2021-10-26 12:48   ` [PATCH v4 01/10] oe imports in central location Henning Schild
2021-10-26 12:28 ` [PATCH v4 02/10] images: create deploy dir Adriaan Schmidt
2021-10-26 12:28 ` [PATCH v4 03/10] rootfs: recursively depend on packages Adriaan Schmidt
2021-10-26 12:28 ` [PATCH v4 04/10] base: remove unneeded "before do_build" task dependencies Adriaan Schmidt
2021-10-26 12:28 ` [PATCH v4 05/10] dpkg: add explicit dependency to isar-apt Adriaan Schmidt
2021-10-26 12:28 ` [PATCH v4 06/10] meta: add sstate feature from oe Adriaan Schmidt
2021-10-26 12:28 ` [PATCH v4 07/10] sstate: configure Adriaan Schmidt
2021-10-26 12:28 ` [PATCH v4 08/10] sstate: add caching to isar-bootstrap Adriaan Schmidt
2021-10-26 12:28 ` [PATCH v4 09/10] sstate: add caching to rootfs Adriaan Schmidt
2021-10-26 12:28 ` [PATCH v4 10/10] sstate: add caching to debian packages Adriaan Schmidt
2021-10-26 12:37 ` [PATCH v4 00/10] Add sstate-cache Schmidt, Adriaan
2021-10-26 13:43 ` Henning Schild
2021-10-28 15:23 ` Anton Mikanovich
2021-10-28 18:06   ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211026122811.2654125-2-adriaan.schmidt@siemens.com \
    --to=adriaan.schmidt@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox