From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7016230395466219520 X-Received: by 2002:a05:600c:4e94:: with SMTP id f20mr56842003wmq.52.1635251300470; Tue, 26 Oct 2021 05:28:20 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:ef8b:: with SMTP id d11ls5539788wro.2.gmail; Tue, 26 Oct 2021 05:28:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVWqcoazWqZMLTpmXbnC0jF9lH3RDHdzNcfeHroB+v//I8mc68Il5OH4tky7qcDyZAoOan X-Received: by 2002:a05:6000:552:: with SMTP id b18mr31962580wrf.112.1635251299497; Tue, 26 Oct 2021 05:28:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635251299; cv=none; d=google.com; s=arc-20160816; b=MPW4yRBc+0TqisEPBotLsDR+JD8ojmqdFzPdrMuYG75nv37AN0CRFEKuRae0fVWsvR 0K/NaUaZ9ivEtg4Qu66ukRULAo4+22xlNO610qTrtUIccfvlxF0zSIdAOcXe3uNgYN24 +phc20Pr+VR2K8rDUThXjlHlTS8WuT3oKLuUi/dxcavLVv9jCo0+iae4EFcNYkwPx5Bk t67QU1GI0inxa35nYbrtXZw9bAMpSW5OVo+P3CDNFa/Xh4P+yG/PG/YYWspUaDpFFPtx La2GJCComFYoFze9v3apsyNHM0eZvTNdNaS92yWzgBStGWBnnQa98P/uUSBfX+0njgLU YqkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=3XAAIVgzAqewjtQglsuEeWhZxOJ9VUQNd9lGiRM5t88=; b=bjNupKIBMq2QyEAXYIF0PjpxpVImCd6LWcXYW30VxpPfbllF8H5gh48egBlm2KyaRm ywkiIih1yE6AUknfW6JfLwChrM4q1WsE4ebvFjBMuPe9ohVZva5GJN3mwy0tXH1XSurk Eo37gdiBwqv4WWwIrkJ2BQthIJvvt18PJ0/P2l3CFuFq/noKoLn2TUwAFtjoIk1zkUT+ ouhjSJaxKEsprvEnMef54Z2yk8Pz68yxqJBxvud4OVsQtaalKQzN251+RW61wpNQRRtb dITZc1FRXWgxNYkqNtUCLrvtHHOZLQYRU9sZBGo56w8k44G87t3C9L8iyUYiApI7nQuK gyTQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id f9si33554wmg.2.2021.10.26.05.28.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Oct 2021 05:28:19 -0700 (PDT) Received-SPF: pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 19QCSJ3j001418 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 26 Oct 2021 14:28:19 +0200 Received: from random.ppmd.siemens.net (random.ppmd.siemens.net [139.25.68.25]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 19QCSIPM013081; Tue, 26 Oct 2021 14:28:18 +0200 From: Adriaan Schmidt To: isar-users@googlegroups.com Cc: Adriaan Schmidt Subject: [PATCH v4 04/10] base: remove unneeded "before do_build" task dependencies Date: Tue, 26 Oct 2021 14:28:05 +0200 Message-Id: <20211026122811.2654125-5-adriaan.schmidt@siemens.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211026122811.2654125-1-adriaan.schmidt@siemens.com> References: <20211026122811.2654125-1-adriaan.schmidt@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: 9SHUZvf/+g8n This makes dependencies more precise, in preparation for the introduction of caching. Currently the dependency graph is overspecified, and do_build has too many explicit dependencies. What happens then is that even if a package (the output of do_dpkg_build) can be taken from cache, there are still dependencies that cause the execution of do_fetch, do_patch etc. Signed-off-by: Adriaan Schmidt --- meta/classes/base.bbclass | 4 ++-- meta/classes/dpkg-base.bbclass | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass index 13134ff..fe5bcb0 100644 --- a/meta/classes/base.bbclass +++ b/meta/classes/base.bbclass @@ -183,7 +183,7 @@ python do_fetch() { bb.fatal(str(e)) } -addtask fetch before do_build +addtask fetch do_unpack[dirs] = "${WORKDIR}" @@ -202,7 +202,7 @@ python do_unpack() { bb.fatal(str(e)) } -addtask unpack after do_fetch before do_build +addtask unpack after do_fetch do_build[noexec] = "1" do_build () { diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass index 2005707..eddf643 100644 --- a/meta/classes/dpkg-base.bbclass +++ b/meta/classes/dpkg-base.bbclass @@ -212,7 +212,7 @@ python do_dpkg_build() { bb.utils.unlockfile(lock) } -addtask dpkg_build before do_build +addtask dpkg_build KEEP_INSTALLED_ON_CLEAN ?= "0" -- 2.30.2