public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: <isar-users@googlegroups.com>, <adriaan.schmidt@siemens.com>,
	Gylstorff Quirin <quirin.gylstorff@siemens.com>
Subject: Re: [PATCH v3 2/2] Ensure generation of /etc/os-release is idempotent
Date: Wed, 3 Nov 2021 14:46:10 +0100	[thread overview]
Message-ID: <20211103144610.77847710@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20211103123624.3015125-3-felix.moessbauer@siemens.com>

Am Wed, 3 Nov 2021 13:36:24 +0100
schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:

> Prior to this patch, the generation of the os-release file
> was not idempotent as there was a name-glitch in VARIAN_VERSION.
> By that, the script did not detect an existing VARIANT_VERSION
> and add one additional one per invocation.
> 

Fixes: 78b24427a050 ("classes/image-postproc: Add image version")

> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/classes/image-postproc-extension.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image-postproc-extension.bbclass
> b/meta/classes/image-postproc-extension.bbclass index
> 6e6b257..87749c8 100644 ---
> a/meta/classes/image-postproc-extension.bbclass +++
> b/meta/classes/image-postproc-extension.bbclass @@ -27,7 +27,7 @@
> update_etc_os_release() { sudo tee -a '${IMAGE_ROOTFS}/etc/os-release'
>      fi
>      if [ -n "${OS_RELEASE_VARIANT_VERSION}" ]; then
> -        sudo sed -i '/^ISAR_IMAGE_VERSION=.*/d'
> '${IMAGE_ROOTFS}/etc/os-release'
> +        sudo sed -i '/^VARIANT_VERSION=.*/d'
> '${IMAGE_ROOTFS}/etc/os-release' echo "VARIANT_VERSION=\"${PV}\"" | \
>              sudo tee -a '${IMAGE_ROOTFS}/etc/os-release'
>      fi


  reply	other threads:[~2021-11-03 13:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 12:36 [PATCH v3 0/2] Improve handling of ISAR_RELEASE_CMD Felix Moessbauer
2021-11-03 12:36 ` [PATCH v3 1/2] always invoke ISAR_RELEASE_CMD to invalidate downstream tasks on change Felix Moessbauer
2021-11-03 13:42   ` Henning Schild
2021-11-03 14:09     ` Moessbauer, Felix
2021-11-03 18:16       ` Henning Schild
2021-11-04 11:50         ` Schmidt, Adriaan
2021-11-03 12:36 ` [PATCH v3 2/2] Ensure generation of /etc/os-release is idempotent Felix Moessbauer
2021-11-03 13:46   ` Henning Schild [this message]
2021-11-03 18:20 ` [PATCH v3 0/2] Improve handling of ISAR_RELEASE_CMD Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103144610.77847710@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox