From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7016230395466219520 X-Received: by 2002:a17:906:b20e:: with SMTP id p14mr20565932ejz.94.1636026687456; Thu, 04 Nov 2021 04:51:27 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:c049:: with SMTP id u9ls1779738edd.2.gmail; Thu, 04 Nov 2021 04:51:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzc14lAnUwL3AGH+gSSuYs5bXOjR9MeENTJGO3fnLj5B4IlNYInCQgw4VAtQPu+qnWta5D+ X-Received: by 2002:aa7:c391:: with SMTP id k17mr45754787edq.263.1636026686531; Thu, 04 Nov 2021 04:51:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636026686; cv=none; d=google.com; s=arc-20160816; b=TKZok8d2c+kvt+Z7UMgsioeNnOLeqF31mCCyvpnrR/NumRC83Oow+GNfwCPNG5R4KA bq9a/VErqonRzqyqjDLJJ0K6g/yC4aX20WgnjaWHMr3mimx+cmhzjZgC9M48YLoo7ru9 aLaY4yYc6Qj6cD2Z05ip6admfAwoFAsFvBy8vRtrnJA6yEEmBeJfpeZLv0no0+vvqhoP JrvN4O8j170m8UbvxJWJFvBxp1f1MFrNH5VVcX21QYyy+BTWlgzFxn+7xR3VkLpe7QZS gDpxhparKQN70eNbVlzmxjKwp4TJ7/iFk1Dh218g+SP77+RvGl1Pk1C+8ntHao4x0dG5 TDvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=lC+gBv0PyyExUWVRbBAqbKdx08gH9ZeBPz1w4Eqz1zc=; b=o4LSg5tyti/3CzWudj1K5TbtY7EP8APq+I0PQBSPx9JIZM23vxNCiyaZ4feFwnPe3J 3vVLOhczz5g4GtJfsDrw/VT6Tv/DsSCKmaiDe4IydLA4s0IR5IvXqI8KfyyOiLiKgvs0 ugWQvOWzz7maBSJfM6w2bMuwGVnow3yUE20U01Q7PQGUVuP/T7gT7Jf/OCnDNPEKa7WT Sw5pLH5FB2b1BjHvEMAYwZl7m9pGl3Pfwanu4EfCVUYWMi8/1CRNVd4P6xD1CgNbYun3 qgkpwmlfqtSfEb3HiR8l0YLAbevHcQdrBsUhksKBDuCSzGRgGM52NnLbN7W3bbjsInY6 bH3w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id bi21si455676edb.0.2021.11.04.04.51.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Nov 2021 04:51:26 -0700 (PDT) Received-SPF: pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 1A4BpQUZ030211 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 4 Nov 2021 12:51:26 +0100 Received: from random.ppmd.siemens.net (random.ppmd.siemens.net [139.25.68.25]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 1A4BpPbQ026036; Thu, 4 Nov 2021 12:51:26 +0100 From: Adriaan Schmidt To: isar-users@googlegroups.com Cc: Adriaan Schmidt Subject: [PATCH v5 12/13] test: make bitbake_args a list Date: Thu, 4 Nov 2021 12:51:22 +0100 Message-Id: <20211104115123.2519356-13-adriaan.schmidt@siemens.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211104115123.2519356-1-adriaan.schmidt@siemens.com> References: <20211104115123.2519356-1-adriaan.schmidt@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: TGn62/fp6E1S The existing code composes the bitbake command as a list, but composes bitbake args as string. Currently that doesn't matter because there is at most one arg (-v). But when adding tests for sstate cache, there will be another one. This patch makes the code somewhat more consistent and extensible by also handling the args in a list. Signed-off-by: Adriaan Schmidt --- testsuite/build_test/cibase.py | 6 +++--- testsuite/build_test/cibuilder.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/testsuite/build_test/cibase.py b/testsuite/build_test/cibase.py index 78d7bdb..0bff7e4 100644 --- a/testsuite/build_test/cibase.py +++ b/testsuite/build_test/cibase.py @@ -15,10 +15,10 @@ class CIBaseTest(CIBuilder): build_dir = self.params.get('build_dir', default=isar_root + '/build') build_dir = os.path.realpath(build_dir) quiet = int(self.params.get('quiet', default=0)) - bitbake_args = '-v' + bitbake_args = [] - if quiet: - bitbake_args = '' + if not quiet: + bitbake_args.append('-v') self.log.info('===================================================') self.log.info('Running ' + testname + ' test for:') diff --git a/testsuite/build_test/cibuilder.py b/testsuite/build_test/cibuilder.py index baa7185..b224479 100644 --- a/testsuite/build_test/cibuilder.py +++ b/testsuite/build_test/cibuilder.py @@ -74,7 +74,7 @@ class CIBuilder(Test): os.chdir(build_dir) cmdline = ['bitbake'] if args: - cmdline.append(args) + cmdline.extend(args) if cmd: cmdline.append('-c') cmdline.append(cmd) -- 2.30.2