From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7016230395466219520 X-Received: by 2002:a2e:1548:: with SMTP id 8mr5849198ljv.120.1636026687544; Thu, 04 Nov 2021 04:51:27 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:2a42:: with SMTP id q63ls930982ljq.5.gmail; Thu, 04 Nov 2021 04:51:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBp9oO1n0fzYVkclz+XZzQroGzrgdqO2folAYuzJJ2Elu/hUDMyc8VIbThRGQgg9KvS4pa X-Received: by 2002:a2e:8507:: with SMTP id j7mr13931754lji.83.1636026686500; Thu, 04 Nov 2021 04:51:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636026686; cv=none; d=google.com; s=arc-20160816; b=wAMClG8drzgYnyzmlXtYWUWlRbbQmyAzzVw8LIWdSlWZvyNRWQofRFqVccsjQa4Cc0 +eLtfd9Le2s7udNH6egy40y3t7foQI5dmeJ61e1RcMQ45U3vMkqkRnhn99Hawzn73dwW hI7nhZRm2L/N1aznrNidzG3MRp3V5MLhSJUxmongGSCKjfJjZq9xmgsgF3DBhE/nS/Ce KA+u48yc2VfPwEFiAkZykuutqVldI54TCPhFutw8Xa67wPKLrC2arZSdadtc0yf8s3uY XfTIyRbQA7KsBvECDkBhhRQ6+GYFkwdlUi11K5IGCs8QVF9AsSbg6GZ2V9niOhm234kM YV+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=3XAAIVgzAqewjtQglsuEeWhZxOJ9VUQNd9lGiRM5t88=; b=NEgq0le/Z350QFpzgxj9fLdjyByqUiYkjCzKr7qKuoiz4mBoJn2uo3WCOsn2VTZzG6 9kA8BWtcAZnJvhro4szUfxzh+TQXvXYDpI3kDzPTaLbiPs5YrkfBqZ+EUX6dYnQSJ/GD 3suKSaj6KsBb7rLNpbb3p3SJhMy8x7dTZF8OpGjzlfGE5kxK6Yxz2sjiCDM6t8blpxFd HMEVsWOzHPPupqyTXbkogowlWfaDjwlc0nAQzzAg979Aho5c/KoqyjDizCU9I00tLal2 10a/K52+dpptX9ysHKZib0GDT+zOIIHY94sJi022t/ejwZlCWqIN1ZtjDwOjCO3UZbBy 2XCg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id a4si257550lji.1.2021.11.04.04.51.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Nov 2021 04:51:26 -0700 (PDT) Received-SPF: pass (google.com: domain of adriaan.schmidt@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 1A4BpPvK027811 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 4 Nov 2021 12:51:25 +0100 Received: from random.ppmd.siemens.net (random.ppmd.siemens.net [139.25.68.25]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 1A4BpPbI026036; Thu, 4 Nov 2021 12:51:25 +0100 From: Adriaan Schmidt To: isar-users@googlegroups.com Cc: Adriaan Schmidt Subject: [PATCH v5 04/13] base: remove unneeded "before do_build" task dependencies Date: Thu, 4 Nov 2021 12:51:14 +0100 Message-Id: <20211104115123.2519356-5-adriaan.schmidt@siemens.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211104115123.2519356-1-adriaan.schmidt@siemens.com> References: <20211104115123.2519356-1-adriaan.schmidt@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: 4aDIPHtUqwmu This makes dependencies more precise, in preparation for the introduction of caching. Currently the dependency graph is overspecified, and do_build has too many explicit dependencies. What happens then is that even if a package (the output of do_dpkg_build) can be taken from cache, there are still dependencies that cause the execution of do_fetch, do_patch etc. Signed-off-by: Adriaan Schmidt --- meta/classes/base.bbclass | 4 ++-- meta/classes/dpkg-base.bbclass | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass index 13134ff..fe5bcb0 100644 --- a/meta/classes/base.bbclass +++ b/meta/classes/base.bbclass @@ -183,7 +183,7 @@ python do_fetch() { bb.fatal(str(e)) } -addtask fetch before do_build +addtask fetch do_unpack[dirs] = "${WORKDIR}" @@ -202,7 +202,7 @@ python do_unpack() { bb.fatal(str(e)) } -addtask unpack after do_fetch before do_build +addtask unpack after do_fetch do_build[noexec] = "1" do_build () { diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass index 2005707..eddf643 100644 --- a/meta/classes/dpkg-base.bbclass +++ b/meta/classes/dpkg-base.bbclass @@ -212,7 +212,7 @@ python do_dpkg_build() { bb.utils.unlockfile(lock) } -addtask dpkg_build before do_build +addtask dpkg_build KEEP_INSTALLED_ON_CLEAN ?= "0" -- 2.30.2