public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Adriaan Schmidt <adriaan.schmidt@siemens.com>
To: isar-users@googlegroups.com
Cc: Adriaan Schmidt <adriaan.schmidt@siemens.com>
Subject: [PATCH v6 12/13] test: make bitbake_args a list
Date: Thu, 11 Nov 2021 07:47:27 +0100	[thread overview]
Message-ID: <20211111064728.2375760-13-adriaan.schmidt@siemens.com> (raw)
In-Reply-To: <20211111064728.2375760-1-adriaan.schmidt@siemens.com>

The existing code composes the bitbake command as a list, but composes
bitbake args as string. Currently that doesn't matter because there is
at most one arg (-v). But when adding tests for sstate cache, there will
be another one. This patch makes the code somewhat more consistent
and extensible by also handling the args in a list.

Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
---
 testsuite/build_test/cibase.py    | 6 +++---
 testsuite/build_test/cibuilder.py | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/testsuite/build_test/cibase.py b/testsuite/build_test/cibase.py
index 78d7bdb..0bff7e4 100644
--- a/testsuite/build_test/cibase.py
+++ b/testsuite/build_test/cibase.py
@@ -15,10 +15,10 @@ class CIBaseTest(CIBuilder):
         build_dir = self.params.get('build_dir', default=isar_root + '/build')
         build_dir = os.path.realpath(build_dir)
         quiet = int(self.params.get('quiet', default=0))
-        bitbake_args = '-v'
+        bitbake_args = []
 
-        if quiet:
-            bitbake_args = ''
+        if not quiet:
+            bitbake_args.append('-v')
 
         self.log.info('===================================================')
         self.log.info('Running ' + testname + ' test for:')
diff --git a/testsuite/build_test/cibuilder.py b/testsuite/build_test/cibuilder.py
index baa7185..b224479 100644
--- a/testsuite/build_test/cibuilder.py
+++ b/testsuite/build_test/cibuilder.py
@@ -74,7 +74,7 @@ class CIBuilder(Test):
         os.chdir(build_dir)
         cmdline = ['bitbake']
         if args:
-            cmdline.append(args)
+            cmdline.extend(args)
         if cmd:
             cmdline.append('-c')
             cmdline.append(cmd)
-- 
2.30.2


  parent reply	other threads:[~2021-11-11  6:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  6:47 [PATCH v6 00/13] Add sstate-cache Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 01/13] oe imports in central location Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 02/13] images: create deploy dir Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 03/13] rootfs: recursively depend on packages Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 04/13] base: remove unneeded "before do_build" task dependencies Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 05/13] dpkg: add explicit dependency to isar-apt Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 06/13] meta: add sstate feature from oe Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 07/13] sstate: configure Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 08/13] sstate: add caching to isar-bootstrap Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 09/13] sstate: add caching to rootfs Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 10/13] sstate: add caching to debian packages Adriaan Schmidt
2021-11-11  6:47 ` [PATCH v6 11/13] test: pass absolute path for build_dir Adriaan Schmidt
2021-11-11  6:47 ` Adriaan Schmidt [this message]
2021-11-11  6:47 ` [PATCH v6 13/13] sstate: add test case Adriaan Schmidt
2021-11-16 16:46   ` Anton Mikanovich
2021-11-16 22:47     ` Henning Schild
2021-11-17  8:21     ` Schmidt, Adriaan
2021-11-17 16:51       ` Anton Mikanovich
2021-11-19 10:33         ` Schmidt, Adriaan
2021-12-02  9:19 ` [PATCH v6 00/13] Add sstate-cache Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211111064728.2375760-13-adriaan.schmidt@siemens.com \
    --to=adriaan.schmidt@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox