From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7016230395466219520 X-Received: by 2002:a2e:bd82:: with SMTP id o2mr5082656ljq.96.1636613260301; Wed, 10 Nov 2021 22:47:40 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3499:: with SMTP id v25ls1474150lfr.0.gmail; Wed, 10 Nov 2021 22:47:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJz999aGbZXbprUqbR0sHAnPP+HYmadVHFIFzwo7OFMzp1uNSbUxTgrEc7sodJ8KWu8K8vLE X-Received: by 2002:a19:5e42:: with SMTP id z2mr4746464lfi.102.1636613259177; Wed, 10 Nov 2021 22:47:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636613259; cv=none; d=google.com; s=arc-20160816; b=X7Y4AP4GbsbJppOJlH13j0OCOztW1xwMeUu2+8DZsOtq0ee8k37LTjQwojGDb4SMsL yqJHtTBRfZK7AZhO6/QUfbV0cbJMG7hMXHse4cZlglQBsoIeJuD0fvkR1ztZU3slBVsC 2nCaPu4P2R0D0Dy9K+SKRwOquAsbwBlbiOK9CXUVWSwwvfoutj+vFO8zEyft8I6J1VqK LZ6lvqJWWi1I2CPLIDAXzTILm3lkB1TowyYxFYncXt9TnYDwDI60ZddaJo/m8DwgVDUg RzMUKZ5YsSDuHG1yBSZbpxlH9yQYcghQZv98sXUtuO01IdUPlfifzHhipQSkKcgl3LQd NtSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=lC+gBv0PyyExUWVRbBAqbKdx08gH9ZeBPz1w4Eqz1zc=; b=gvhHBPXPxtydRgzj8RyjPgHWFkyMYmmNxFi0WzrEhRLBbGi6SKN7DLY6I0rY6ADdHa Ej4Nl2klcjDJa5diYEnHmXfPhdvhsbccsYVHFmPsj0vYW4qHlEA4XNfnJXtjfD78nT8G oEALmZB18R6RqZzF4guF45q0qEDDO2uPtVsQ2DHZLm19x1THJoEnKJoja5ezEfh0x996 9vBisC1f6RnfVPRm1HdeQ+2CZ/TlVB297YNfZp+0SJm7zJAQUimCqnkHKuHImXrRo05Z vgGmXe3ajXDlASuff45mF53GAeKVst0bGVF70MjCiOngCbiT/P+1I7OCUSSsCDPjWWTv TmxQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id d18si49826lfg.3.2021.11.10.22.47.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Nov 2021 22:47:39 -0800 (PST) Received-SPF: pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 1AB6lc9U009303 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 11 Nov 2021 07:47:38 +0100 Received: from random.ppmd.siemens.net (random.ppmd.siemens.net [139.25.68.25]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1AB6lbcf012388; Thu, 11 Nov 2021 07:47:38 +0100 From: Adriaan Schmidt To: isar-users@googlegroups.com Cc: Adriaan Schmidt Subject: [PATCH v6 12/13] test: make bitbake_args a list Date: Thu, 11 Nov 2021 07:47:27 +0100 Message-Id: <20211111064728.2375760-13-adriaan.schmidt@siemens.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211111064728.2375760-1-adriaan.schmidt@siemens.com> References: <20211111064728.2375760-1-adriaan.schmidt@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: 7nI163PKzaWk The existing code composes the bitbake command as a list, but composes bitbake args as string. Currently that doesn't matter because there is at most one arg (-v). But when adding tests for sstate cache, there will be another one. This patch makes the code somewhat more consistent and extensible by also handling the args in a list. Signed-off-by: Adriaan Schmidt --- testsuite/build_test/cibase.py | 6 +++--- testsuite/build_test/cibuilder.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/testsuite/build_test/cibase.py b/testsuite/build_test/cibase.py index 78d7bdb..0bff7e4 100644 --- a/testsuite/build_test/cibase.py +++ b/testsuite/build_test/cibase.py @@ -15,10 +15,10 @@ class CIBaseTest(CIBuilder): build_dir = self.params.get('build_dir', default=isar_root + '/build') build_dir = os.path.realpath(build_dir) quiet = int(self.params.get('quiet', default=0)) - bitbake_args = '-v' + bitbake_args = [] - if quiet: - bitbake_args = '' + if not quiet: + bitbake_args.append('-v') self.log.info('===================================================') self.log.info('Running ' + testname + ' test for:') diff --git a/testsuite/build_test/cibuilder.py b/testsuite/build_test/cibuilder.py index baa7185..b224479 100644 --- a/testsuite/build_test/cibuilder.py +++ b/testsuite/build_test/cibuilder.py @@ -74,7 +74,7 @@ class CIBuilder(Test): os.chdir(build_dir) cmdline = ['bitbake'] if args: - cmdline.append(args) + cmdline.extend(args) if cmd: cmdline.append('-c') cmdline.append(cmd) -- 2.30.2