From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7016230395466219520 X-Received: by 2002:adf:f551:: with SMTP id j17mr6189861wrp.392.1636613259258; Wed, 10 Nov 2021 22:47:39 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:ad6:: with SMTP id c22ls4348043wmr.1.canary-gmail; Wed, 10 Nov 2021 22:47:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGCTE9KbCbydrLKlNzqaGza8SHucHtg+ofRWRs5A9heoQoBC4Lvvgnm5EKsEHN6iR7QsL7 X-Received: by 2002:a05:600c:1d97:: with SMTP id p23mr22417327wms.186.1636613258170; Wed, 10 Nov 2021 22:47:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636613258; cv=none; d=google.com; s=arc-20160816; b=viXWNJKKvstvAzqR+hC45k059s68ga4Hhy8dsiQwm0fZ9S2zOaYVxEu0O/Jibj4cIy ig+ZlFmXk0YJTzwJu35VPS20/jR7d0XjEC52CoHd9oN+xQvUuQ3mQym82Mr9LuIryJW5 Z3NBU61mnxuGXfqcPEhCc9Dig6KjRSdD1GoT/FlDXAdOzrZB3T9sCKBt7SzlNc5A36db A/B/BFH9sqb9jdpc2TOYbOxfsHYx4cYuDy56ARNgKBlEzIUCrrUgixmgPj/Qe8fSO3Rw 6SerdDBsqZwJxjil5Eh9V0I3pjM14/9BF7YrrCo3eyQjE4sAxzKTYwdKJ3PTu+Is6+jU TA1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=3XAAIVgzAqewjtQglsuEeWhZxOJ9VUQNd9lGiRM5t88=; b=VdpZOrnl/eWoss6Yivyririm6oCjB9OclUkVhSgI4wQkwR1MQP9QxNdjWXHKWJo9Si N+D5TIeUXndTv8Rv+EKTUBgLbTXDcpoB1M/PvKofVPMRYGx3roUemSMzSl5I90q5qunf qgzqTc4qH+EcfvBBSsjC999ACKd4hYmqhnZJLW6DRFqWbIFYc4bWuKy4IrsWJJ5xKGeg P/dUq7jAM7XXDppEbOzhe3ERf4jhzAGBOo1EOn6YfnZ9MkpFH1Eujl7qQeiZRx+U46KT QQQUbSJ0fE8i01Vgn2xYIRw1p8L29r031GoSUe4az0bZByh58KTWYMJcnQmd1khFbWOM olUA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id c2si154566wmq.2.2021.11.10.22.47.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Nov 2021 22:47:38 -0800 (PST) Received-SPF: pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 1AB6lbV5020691 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 11 Nov 2021 07:47:37 +0100 Received: from random.ppmd.siemens.net (random.ppmd.siemens.net [139.25.68.25]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1AB6lbcX012388; Thu, 11 Nov 2021 07:47:37 +0100 From: Adriaan Schmidt To: isar-users@googlegroups.com Cc: Adriaan Schmidt Subject: [PATCH v6 04/13] base: remove unneeded "before do_build" task dependencies Date: Thu, 11 Nov 2021 07:47:19 +0100 Message-Id: <20211111064728.2375760-5-adriaan.schmidt@siemens.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211111064728.2375760-1-adriaan.schmidt@siemens.com> References: <20211111064728.2375760-1-adriaan.schmidt@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: Jb/T3Ksyhe4w This makes dependencies more precise, in preparation for the introduction of caching. Currently the dependency graph is overspecified, and do_build has too many explicit dependencies. What happens then is that even if a package (the output of do_dpkg_build) can be taken from cache, there are still dependencies that cause the execution of do_fetch, do_patch etc. Signed-off-by: Adriaan Schmidt --- meta/classes/base.bbclass | 4 ++-- meta/classes/dpkg-base.bbclass | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass index 13134ff..fe5bcb0 100644 --- a/meta/classes/base.bbclass +++ b/meta/classes/base.bbclass @@ -183,7 +183,7 @@ python do_fetch() { bb.fatal(str(e)) } -addtask fetch before do_build +addtask fetch do_unpack[dirs] = "${WORKDIR}" @@ -202,7 +202,7 @@ python do_unpack() { bb.fatal(str(e)) } -addtask unpack after do_fetch before do_build +addtask unpack after do_fetch do_build[noexec] = "1" do_build () { diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass index 2005707..eddf643 100644 --- a/meta/classes/dpkg-base.bbclass +++ b/meta/classes/dpkg-base.bbclass @@ -212,7 +212,7 @@ python do_dpkg_build() { bb.utils.unlockfile(lock) } -addtask dpkg_build before do_build +addtask dpkg_build KEEP_INSTALLED_ON_CLEAN ?= "0" -- 2.30.2