From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7026321669488640000 X-Received: by 2002:a1c:1d42:: with SMTP id d63mr1295651wmd.184.1637168076940; Wed, 17 Nov 2021 08:54:36 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:416:: with SMTP id 22ls3729782wme.0.canary-gmail; Wed, 17 Nov 2021 08:54:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnYiJLIw/oFmkeGerFVeh3z+pk3rN88EIPEsmJhm7vkjIxHc80Te3fnp5P2repunt5yMC+ X-Received: by 2002:a05:600c:1d06:: with SMTP id l6mr1223013wms.97.1637168076040; Wed, 17 Nov 2021 08:54:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637168076; cv=none; d=google.com; s=arc-20160816; b=SyvK/rAU7FVsm+wi0jL1FEOFWMhbSr09nyloVnbLiZBgz+a/qTV0cMHH38Ab88MMXx kNaQ8EgIavdELJsoHpjCPOBownqYE9OcY+YeMZKZ+h5luHxel1l9pRy28g9TxdzI1yFf tnB8BUx9CsMTcwZcgwpU+ipn3Hu0NCzWza8eKtP80rAOahNxm3CkVjEy7uwcwozuv/Hw 48rCEXKNN/WHpc/Z2wN34F4LuL/S83Lm4E3Ji/XMM1Ag9dC0UfA+YtgnFWFspErRXtaZ Cgyow0zzo6s87hGbV6U4vy3vzNvGukRjnmxL2WBJvK9zrThMavLnsObFHkBiW4h1Jev3 nfJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=DfHOT7By7zaeNlEbgqsOzInsQ+9dr/Ky9b4LQr9/L44=; b=buP/K5to5aGIJwwS/qB6qLoy3m1Tp2y6YlwfNokRGLawOVKj3YVXcUKNKkskvx35Cm BTdvDuXVos+vxqHpc9PQ/510e8egeXJWC/Lvr2Mt3JlmBOBrZX7xDgfvzDbqAofcFPtK SXFQq9Ft8DAMT8qNh1wPq6sJsAtqLqTpWq8i+kAbUQzp6Nn0mUPF1A/TXaWWmDGx5dgx nmgl1Kgv1si8sxw+tLYgRStVtkaIeHePFGnAhbeqTZUXVRnCfD7x/ym4roi1v8M2CF/f UUVQNNRrRbd/7ciXqI92uUuF86eKi2CCLvPW6aU+T40+4axJI1OvuYz2oefK8Etf2AqF lUnA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id j14si25854wrq.5.2021.11.17.08.54.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Nov 2021 08:54:36 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 1AHGsZZu011641 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Nov 2021 17:54:35 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.74.66]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 1AHGsZ8D003267; Wed, 17 Nov 2021 17:54:35 +0100 Date: Wed, 17 Nov 2021 17:54:30 +0100 From: Henning Schild To: Anton Mikanovich Cc: "Moessbauer, Felix" , "isar-users@googlegroups.com" Subject: Re: [PATCH v4 0/2] Improve handling of ISAR_RELEASE_CMD Message-ID: <20211117175430.06217822@md1za8fc.ad001.siemens.net> In-Reply-To: <4bf7b75d-f431-9a07-96f0-a1168af073d3@ilbers.de> References: <20211104110507.2358692-1-felix.moessbauer@siemens.com> <4bf7b75d-f431-9a07-96f0-a1168af073d3@ilbers.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: z1AUbfkQ4AvB Am Wed, 17 Nov 2021 16:05:31 +0300 schrieb Anton Mikanovich : > 17.11.2021 13:45, Moessbauer, Felix wrote: > > Hi Anton, > > > > Unfortunately I cannot reproduce this, but this is very likely > > related to a not idempotent ISAR_RELEASE_CMD. As stated in the API > > changelog, the ISAR_RELEASE_CMD shall be idempotent (and > > technically must be for MC targets). By that, no things like > > timestamps must be included. > > > > If you point me to the location where the ISAR_RELEASE_CMD is set > > for CI builds, I can have a look. Another issue could be that > > changes to the git happen during build (e.g. adding a tag, making > > the repo dirty, etc...). In that case (starting with a clean build, > > ending up with a dirty one), the CI generated files have to be > > added to the .gitignore. > > > > In Yocto there is a lengthy discussion about the idempotence sanity > > check [1] and why recipes have to be written in this way. > > > > Best regards, > > Felix > > > > [1] https://patchwork.openembedded.org/patch/133517/ > > > Default ISAR_RELEASE_CMD can be found in meta/classes/image.bbclass > as: ISAR_RELEASE_CMD_DEFAULT = "git -C ${LAYERDIR_core} describe > --tags --dirty --match 'v[0-9].[0-9]*'" > which results in something like `v0.7-534-g6752a45` > This issue is reproduced inside Jenkins only, but not locally or in > gitlab/kas. Well once you sed in there you might also get a "dirty" somewhere. The reason the output might differ in gitlab is simply the clone depth which defaults to something like 50. If your last tag is 534 commits away you will get only g because there are no tags in your not super-deep clone. Workarounds are to tag more often or to clone deeper. I am not sure git describe can be told how many commits to consider in the past. So its output might simply differ depending on how deep you cloned. Henning