public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: [PATCH v3 3/5] buildstats: Fixes to work with bbclass in ISAR
Date: Fri, 19 Nov 2021 10:24:57 +0100	[thread overview]
Message-ID: <20211119092459.27376-4-ubely@ilbers.de> (raw)
In-Reply-To: <20211119092459.27376-1-ubely@ilbers.de>

IMAGE_ROOTFS should not be empty while it's used by
buildstats.bbclass. If it's not defined in some recipe like
isar-bootstrap-*, build will fail if buildstats is enabled.

Global definition of ISAR_ROOTFS was removed in Isar in commit
33c9a27cdc4b. The solution is to get it back, but in week form.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 meta/conf/bitbake.conf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index dce467b2..f056ad19 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -115,6 +115,9 @@ BBINCLUDELOGS ??= "yes"
 # Add event handlers for bitbake
 INHERIT += "isar-events"
 
+# Buildstats requires IMAGE_ROOTFS to be always defined
+IMAGE_ROOTFS ??= "${WORKDIR}/rootfs"
+
 # Default values for ccache
 USE_CCACHE ??= "0"
 CCACHE_TOP_DIR ?= "${TMPDIR}/ccache"
-- 
2.20.1


  parent reply	other threads:[~2021-11-19  9:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  9:24 [PATCH v3 0/5] Use buildstats from OE to generate build charts Uladzimir Bely
2021-11-19  9:24 ` [PATCH v3 1/5] oe imports in central location Uladzimir Bely
2021-11-19  9:24 ` [PATCH v3 2/5] buildstats: Borrow buildstats and pybootchartgui from OE Uladzimir Bely
2021-11-19  9:24 ` Uladzimir Bely [this message]
2021-11-19  9:24 ` [PATCH v3 4/5] buildstats: Enable buildstats in default configuration Uladzimir Bely
2021-11-19  9:24 ` [PATCH v3 5/5] doc: Add buildstats section in user manual Uladzimir Bely
2021-12-01 13:24 ` [PATCH v3 0/5] Use buildstats from OE to generate build charts Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211119092459.27376-4-ubely@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox