[PATCH] meta: Reenable deps checking

[PATCH] meta: Reenable deps checking

[Uladzimir Bely]

For a long time Isar uses '-d' option passed to dpkg-buildpackage.
This makes it skip dpkg-checkbuilddeps stage.

The option was added in https://github.com/ilbers/isar/commit/b18ad30c8c
and now it seems not to be needed anymore.

Removing the option makes build process more strict, but can cause build
errors in downstream, if ':native' build-dep is used in a wrong way.

Related discussion is here:
https://lists.debian.org/debian-devel/2021/12/msg00135.html

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 meta/recipes-devtools/buildchroot/files/build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/buildchroot/files/build.sh b/meta/recipes-devtools/buildchroot/files/build.sh
index 8e6507c6..b2e60252 100644
--- a/meta/recipes-devtools/buildchroot/files/build.sh
+++ b/meta/recipes-devtools/buildchroot/files/build.sh
@@ -19,4 +19,4 @@ if [ "$use_ccache" == "1" ]; then
     export PATH=/usr/lib/ccache:$PATH
 fi
 
-${GBP_PREFIX}dpkg-buildpackage -a$target_arch -d --source-option=-I
+${GBP_PREFIX}dpkg-buildpackage -a$target_arch --source-option=-I
-- 
2.20.1

Re: [PATCH] meta: Reenable deps checking

[Henning Schild]

Am Fri, 10 Dec 2021 07:40:01 +0100
schrieb Uladzimir Bely <ubely@ilbers.de>:

> For a long time Isar uses '-d' option passed to dpkg-buildpackage.
> This makes it skip dpkg-checkbuilddeps stage.
> 
> The option was added in
> https://github.com/ilbers/isar/commit/b18ad30c8c and now it seems not

Please use only the sha here, that will enable gitk an keep the
"remote" out of the history.

In fact you could think about using "git revert" ... will need conflict
resolution i guess.

Henning

> to be needed anymore.
> 
> Removing the option makes build process more strict, but can cause
> build errors in downstream, if ':native' build-dep is used in a wrong
> way.
> 
> Related discussion is here:
> https://lists.debian.org/debian-devel/2021/12/msg00135.html
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  meta/recipes-devtools/buildchroot/files/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/buildchroot/files/build.sh
> b/meta/recipes-devtools/buildchroot/files/build.sh index
> 8e6507c6..b2e60252 100644 ---
> a/meta/recipes-devtools/buildchroot/files/build.sh +++
> b/meta/recipes-devtools/buildchroot/files/build.sh @@ -19,4 +19,4 @@
> if [ "$use_ccache" == "1" ]; then export PATH=/usr/lib/ccache:$PATH
>  fi
>  
> -${GBP_PREFIX}dpkg-buildpackage -a$target_arch -d --source-option=-I
> +${GBP_PREFIX}dpkg-buildpackage -a$target_arch --source-option=-I