public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH 0/2] Fail on the first error inside sudo
Date: Fri, 10 Dec 2021 11:10:52 +0300	[thread overview]
Message-ID: <20211210081054.225747-1-amikan@ilbers.de> (raw)

There in no need in further execution if any command failed. But inside
the sudo sections (also with chroot) we didn't have 'set -e' declared.
It leads to incorrect execution of the next code in case of failures.
So adding 'set -e' to exit immediately.

Also fix rmdir which was failed (but masked) on execution if there were
no base-apt used.

Anton Mikanovich (2):
  rootfs: Execute rmdir only if needed
  sudo: Fail on the first error

 meta/classes/deb-dl-dir.bbclass                   | 2 ++
 meta/classes/image-locales-extension.bbclass      | 1 +
 meta/classes/image.bbclass                        | 9 +++++----
 meta/classes/rootfs.bbclass                       | 2 ++
 meta/classes/vm-img.bbclass                       | 1 +
 meta/classes/wic-img.bbclass                      | 1 +
 meta/recipes-devtools/buildchroot/buildchroot.inc | 1 +
 7 files changed, 13 insertions(+), 4 deletions(-)

-- 
2.25.1


             reply	other threads:[~2021-12-10  8:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10  8:10 Anton Mikanovich [this message]
2021-12-10  8:10 ` [PATCH 1/2] rootfs: Execute rmdir only if needed Anton Mikanovich
2021-12-10  8:10 ` [PATCH 2/2] sudo: Fail on the first error Anton Mikanovich
2021-12-17 12:05   ` Henning Schild
2021-12-17 11:04 ` [PATCH 0/2] Fail on the first error inside sudo Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211210081054.225747-1-amikan@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox