From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7039983387261534208 X-Received: by 2002:a05:6402:27cf:: with SMTP id c15mr32024079ede.128.1639123863848; Fri, 10 Dec 2021 00:11:03 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:c517:: with SMTP id o23ls83618edq.2.gmail; Fri, 10 Dec 2021 00:11:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJfzycIpmB/aArQf6HYVqbjMWmIF6uFE8xpsk2Oawupcuw8zR2JfcK1K6APrfUIZAt9Wo/ X-Received: by 2002:a05:6402:90c:: with SMTP id g12mr36792755edz.36.1639123862762; Fri, 10 Dec 2021 00:11:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1639123862; cv=none; d=google.com; s=arc-20160816; b=ACnxiVyQIGOimBo2EGYu4busR7pxJVI0nNsS14dMfg0dNuNyYBScA3Rv+IqBSLdrhs CicvEyRa8B1Lpq6BEMTM+MBFQ/fHsNopKB2QFsib1d5Smq/RBTPeYBvLpc6dd7zPVb4M NBoGIO4d849tF9f0Emw30e+q2zRY6ZVmDxGMJ0++FR+zwmNBDGRnWDyMMCwElwXxXKsR Gy3YM4jpzAXzaUW9hEomStnyfc2EGHiPjpYkap/0y3laS8YlUTpf1abG47+fOke1Y9tm 6CsehDZqqIzhIrZSDz53KTsGcab2k3evw5G2+lLoTyucheFddUxgpfbTf/tp6wLWO9S/ TJig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=gssDtBhGdl03L29dA9vl0nDFJY47M/bLKsZb/3mfUZg=; b=zrBZliAx3XfdHwt1hFzR9EYVBushpWx1Qqu5pgviYOaZE81XjLLlfzrtf16u/K4zeO aCY+hnJSaHD26qGshDKutg+pHMlPKpYeWfquBPdC0CDoE3YY68iLMpAi8oZ5Zip3Uaa+ 0Po4i615dENUv+vaG3Vg0OoFohQecvRq2etGQSmjYXIWZcaC/xi57owDarjQ+aZAt8VI d6+7bajOeKI7wADTPHtAKYkLjEp2Ph5eW2mQXpw0R2TlpssINwA5UWkikgC7SlPH6HQS IaR+V5Bqhefyyx7ZxPoLerymg6WGylC7Z1CBjjS2MnHv9dahvOOpcaLMgbNj4twnVZVQ c2vw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id fl21si182128ejc.0.2021.12.10.00.11.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Dec 2021 00:11:02 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from localhost.localdomain (mm-37-66-214-37.mgts.dynamic.pppoe.byfly.by [37.214.66.37] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 1BA8B16u017623 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Dec 2021 09:11:02 +0100 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH 0/2] Fail on the first error inside sudo Date: Fri, 10 Dec 2021 11:10:52 +0300 Message-Id: <20211210081054.225747-1-amikan@ilbers.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: EpblbPBg2uYD There in no need in further execution if any command failed. But inside the sudo sections (also with chroot) we didn't have 'set -e' declared. It leads to incorrect execution of the next code in case of failures. So adding 'set -e' to exit immediately. Also fix rmdir which was failed (but masked) on execution if there were no base-apt used. Anton Mikanovich (2): rootfs: Execute rmdir only if needed sudo: Fail on the first error meta/classes/deb-dl-dir.bbclass | 2 ++ meta/classes/image-locales-extension.bbclass | 1 + meta/classes/image.bbclass | 9 +++++---- meta/classes/rootfs.bbclass | 2 ++ meta/classes/vm-img.bbclass | 1 + meta/classes/wic-img.bbclass | 1 + meta/recipes-devtools/buildchroot/buildchroot.inc | 1 + 7 files changed, 13 insertions(+), 4 deletions(-) -- 2.25.1