From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH v2 1/2] isar-bootstrap: Fail on invalid apt source list
Date: Mon, 13 Dec 2021 13:09:27 +0300 [thread overview]
Message-ID: <20211213100928.263794-1-amikan@ilbers.de> (raw)
Returning empty list leads to ambiguous errors, so we should fail early
if distro sources.list is empty or incorrect.
Fix #72
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index 7e2c5884..4037141c 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -167,7 +167,7 @@ def get_distro_primary_source_entry(d):
for source in generate_distro_sources(d):
if source[0] == "deb":
return source[2:]
- return ["", "", ""]
+ bb.fatal('Invalid apt sources list')
def get_distro_have_https_source(d):
return any(source[2].startswith("https://") for source in generate_distro_sources(d))
--
2.20.1
next reply other threads:[~2021-12-13 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 10:09 Anton Mikanovich [this message]
2021-12-13 10:09 ` [PATCH v2 2/2] isar-bootstrap: Remove unused line Anton Mikanovich
2021-12-21 13:03 ` [PATCH v2 1/2] isar-bootstrap: Fail on invalid apt source list Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211213100928.263794-1-amikan@ilbers.de \
--to=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox