From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7041127194041516032 X-Received: by 2002:a17:906:245b:: with SMTP id a27mr42569526ejb.415.1639390176884; Mon, 13 Dec 2021 02:09:36 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:c013:: with SMTP id e19ls5198097ejz.3.gmail; Mon, 13 Dec 2021 02:09:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKrMs4ETY+IP+hlj4vgjyDTTKvyUXD5o4PSbA3gbDfO9VD3ntzozQKhFxIJaQpB6RBjxeU X-Received: by 2002:a17:906:90da:: with SMTP id v26mr43921581ejw.442.1639390175994; Mon, 13 Dec 2021 02:09:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1639390175; cv=none; d=google.com; s=arc-20160816; b=AgAUYZ5Zhzf6N/k/U98ca/toeuVGocG8pEmefS0+C2NDDPqMxrguEJ0jUuLgaEf7sO HilDlnFmXubqDsw9gDF4jlwoCjqMqX08ulMgRzqlLZXAKS6u71SsWFyWXjYoixqe6APd YLz/ZCthvnrEcSdWqxInt7JvYdVLzuCLpMlF5KrVR0Io2TjMzK59s7dHWUiWUeuSD/jW PVYG3v78dWzVzJODEQHOG9ZdVbxGN31HEeTIFTi22eBuJzy62rvW2AdxztAc4ukNv04o fkyWuNs0aRNtcYY8156BLC/o4A4xVk+X6IM9u9uAiUf9arp7UFdWfZPWS7QnE3zmNdJI 45+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=kmaXkI84coSwQwnvc8SuaiDd5krMoLth5oUC5HsQ9aE=; b=HUhYanTf9MpIgTMBkQKUQErwMc12JduK5ocLHo9l2Ah/mO3BtxiNm0jR5H2YXZjBE2 rMJtQvelg1s7U2WFi6j3sz26NDz9LQbtXK3zuNd7+FRgK57h7D4udP/fq1wA17VZd0/C GqH1lWMda6JW9ZWeUW1wAIf3d0BZxv2Ez5zDdqyf/joff4gT6BcxRE8GP60lMY1tP4+0 3MlobIxGV29zvVj6f/OIlj0WkCRKal5XjxFBDknjGC6S/9bHbsz7RT+tV7xygUqvJjm/ NxcHFM/UApeNWn/4MJBOutCWlRwUrmnj1fPI9s2Mo6cLCWKBYqNpcCMWG+YWganOVcat HPkQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id nd40si381736ejc.1.2021.12.13.02.09.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Dec 2021 02:09:35 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from localhost.localdomain (mm-37-66-214-37.mgts.dynamic.pppoe.byfly.by [37.214.66.37] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 1BDA9YGc030725 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Dec 2021 11:09:35 +0100 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH v2 1/2] isar-bootstrap: Fail on invalid apt source list Date: Mon, 13 Dec 2021 13:09:27 +0300 Message-Id: <20211213100928.263794-1-amikan@ilbers.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: GfS6D7Txhw9s Returning empty list leads to ambiguous errors, so we should fail early if distro sources.list is empty or incorrect. Fix #72 Signed-off-by: Anton Mikanovich --- meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index 7e2c5884..4037141c 100644 --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -167,7 +167,7 @@ def get_distro_primary_source_entry(d): for source in generate_distro_sources(d): if source[0] == "deb": return source[2:] - return ["", "", ""] + bb.fatal('Invalid apt sources list') def get_distro_have_https_source(d): return any(source[2].startswith("https://") for source in generate_distro_sources(d)) -- 2.20.1