From: Henning Schild <henning.schild@siemens.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "Schmidt,
Adriaan (T RDA IOT SES-DE)" <adriaan.schmidt@siemens.com>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH] sdk: make SDK and image
Date: Wed, 15 Dec 2021 09:43:43 +0100 [thread overview]
Message-ID: <20211215094343.5710db46@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <c54a5213-273e-47bb-0ecd-e67dbe6b1448@siemens.com>
Am Wed, 15 Dec 2021 09:38:24 +0100
schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> On 15.12.21 09:07, Schmidt, Adriaan (T RDA IOT SES-DE) wrote:
> > Kiszka, Jan (T RDA IOT), 15. Dezember 2021 08:52:
> >> On 15.12.21 07:41, Adriaan Schmidt wrote:
> >>> This derives the SDK from image.bbclass (currently it only
> >>> inherits rootfs), removing the awkward and custom tar-xz'ing.
> >>> Note that because there is not tarxz-img IMAGE_TYPE, we switch
> >>> the SDK type to targz-img. This is only temporary, until we have
> >>> the OE-inspired imagetypes.
> >>>
> >>> API change: SDK is now no longer built using `bitbake my_image
> >>> -cpopulate_sdk`, but using `bitbake isar-sdk`. We could of
> >>> course keep the old commands working, but I could not find any
> >>> connection between the target image and the contents of the
> >>> SDK (while building the SDK using the target image recipe
> >>> confusingly makes it look like there is such a connection).
> >>
> >> This is not correct: The target image recipe may define
> >> SDK_[PRE]INSTALL in correspondance to its content. Also, changing
> >> the user API would needlessly break the alignment with OE.
> >
> > But the SDK is built by a completely different recipe (sdkchroot,
> > inheriting rootfs), so how does SDK_[PRE]INSTALL set in the target
> > image recipe have any effect there? Looks to me that those
> > variables need to be set in some .conf for this to work, but maybe
> > I'm missing something...
>
> Well, if that is the case now, we indeed have a bug. But the fixing
> direction should be along that line "image defines SDK", not "SDK is
> something completely different".
NACK. If we have that bug we can apply that patch to enable my series,
and deal with that bug later.
Henning
> Jan
>
next prev parent reply other threads:[~2021-12-15 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 6:41 Adriaan Schmidt
2021-12-15 7:51 ` Jan Kiszka
2021-12-15 8:07 ` Schmidt, Adriaan
2021-12-15 8:38 ` Jan Kiszka
2021-12-15 8:43 ` Henning Schild [this message]
2021-12-15 9:20 ` Jan Kiszka
2021-12-15 9:35 ` Schmidt, Adriaan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215094343.5710db46@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=adriaan.schmidt@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox