public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: <isar-users@googlegroups.com>
Cc: Henning Schild <henning.schild@siemens.com>
Subject: [PATCH v4 1/7] vm-img: Move template out of package into SRC_URI file.
Date: Wed, 15 Dec 2021 16:48:38 +0100	[thread overview]
Message-ID: <20211215154844.1495-2-henning.schild@siemens.com> (raw)
In-Reply-To: <20211215154844.1495-1-henning.schild@siemens.com>

Instead of placing just one static template into a file coming via a
package, fetch that template file. That allows a choice in template
files, or any kind of modification in layers. Where people might not
find our template to be sufficient.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/classes/vm-img.bbclass                      |  8 +++++---
 .../vm-img}/vm-template.ovf.tmpl                 |  0
 .../vm-template/vm-template_0.1.bb               | 16 ----------------
 3 files changed, 5 insertions(+), 19 deletions(-)
 rename meta/{recipes-devtools/vm-template/files => classes/vm-img}/vm-template.ovf.tmpl (100%)
 delete mode 100644 meta/recipes-devtools/vm-template/vm-template_0.1.bb

diff --git a/meta/classes/vm-img.bbclass b/meta/classes/vm-img.bbclass
index b230af247357..0ba60bb2f7c2 100644
--- a/meta/classes/vm-img.bbclass
+++ b/meta/classes/vm-img.bbclass
@@ -7,8 +7,10 @@
 inherit buildchroot
 inherit wic-img
 
-IMAGER_BUILD_DEPS += "vm-template"
-IMAGER_INSTALL += "qemu-utils gawk uuid-runtime vm-template"
+FILESEXTRAPATHS_prepend := "${FILE_DIRNAME}/vm-img:"
+SRC_URI += "file://vm-template.ovf.tmpl"
+
+IMAGER_INSTALL += "qemu-utils gawk uuid-runtime"
 
 # virtual machine disk settings
 SOURCE_IMAGE_FILE ?= "${IMAGE_FULLNAME}.wic.img"
@@ -100,7 +102,7 @@ do_create_ova() {
         export DISK_UUID=$(uuidgen)
         export VM_UUID=$(uuidgen)
         # create ovf
-        cat /usr/share/vm-template/vm-template.ovf.tmpl | envsubst > ${PP_DEPLOY}/${OVA_NAME}.ovf
+        cat ${PP_WORK}/vm-template.ovf.tmpl | envsubst > ${PP_DEPLOY}/${OVA_NAME}.ovf
         tar -cvf ${PP_DEPLOY}/${OVA_NAME}.ova -C ${PP_DEPLOY} ${OVA_NAME}.ovf
 
         # VirtualBox needs here a manifest file. VMware does accept that format.
diff --git a/meta/recipes-devtools/vm-template/files/vm-template.ovf.tmpl b/meta/classes/vm-img/vm-template.ovf.tmpl
similarity index 100%
rename from meta/recipes-devtools/vm-template/files/vm-template.ovf.tmpl
rename to meta/classes/vm-img/vm-template.ovf.tmpl
diff --git a/meta/recipes-devtools/vm-template/vm-template_0.1.bb b/meta/recipes-devtools/vm-template/vm-template_0.1.bb
deleted file mode 100644
index 1d474cd5d8d7..000000000000
--- a/meta/recipes-devtools/vm-template/vm-template_0.1.bb
+++ /dev/null
@@ -1,16 +0,0 @@
-# This software is a part of ISAR.
-#
-# Copyright (c) Siemens AG, 2020
-#
-# SPDX-License-Identifier: MIT
-
-inherit dpkg-raw
-
-SRC_URI += "file://vm-template.ovf.tmpl"
-
-do_install() {
-    TARGET=${D}/usr/share/vm-template
-    install -m 0755 -d ${TARGET}
-    install -m 0740 ${WORKDIR}/vm-template.ovf.tmpl \
-        ${TARGET}/vm-template.ovf.tmpl
-}
-- 
2.32.0


  reply	other threads:[~2021-12-15 15:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 15:48 [PATCH v4 0/7] vm-img improvements and fixes Henning Schild
2021-12-15 15:48 ` Henning Schild [this message]
2021-12-15 15:48 ` [PATCH v4 2/7] vm-img: Use two different ovf templates for vmware/virtualbox Henning Schild
2021-12-15 15:48 ` [PATCH v4 3/7] vm-img: Shorten code by using variables we have Henning Schild
2021-12-15 15:48 ` [PATCH v4 4/7] vm-img: Drop not used variables Henning Schild
2021-12-15 15:48 ` [PATCH v4 5/7] vm-img: Set vmware machine type to 64bit in our template Henning Schild
2021-12-15 15:48 ` [PATCH v4 6/7] vm-img: Make use of isars template class for most of the tmpl variables Henning Schild
2021-12-15 15:48 ` [PATCH v4 7/7] meta-isar: Switch virtualbox test from buster to bullseye Henning Schild
2021-12-15 15:50 ` [PATCH v4 0/7] vm-img improvements and fixes Henning Schild
2021-12-15 15:57   ` Jan Kiszka
2021-12-15 16:21   ` Anton Mikanovich
2021-12-15 16:35     ` Henning Schild
2021-12-16 13:23       ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211215154844.1495-2-henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox