Re: [PATCH v5 3/5] classes: allow more control over container image name and tag

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 18 Aug 2021 19:19:21 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> 05.08.2021 19:09, Henning Schild wrote:
> > diff --git a/doc/user_manual.md b/doc/user_manual.md
> > index cf7dc2fee35e..e5c07bd41fc5 100644
> > --- a/doc/user_manual.md
> > +++ b/doc/user_manual.md
> > @@ -1070,14 +1070,14 @@ bitbake -c do_populate_sdk
> > mc:qemuarm-buster:isar-image-base
> >    - Load the SDK container image into the Docker Daemon
> >   
> >   ```
> > -docker load -i
> > build/tmp/deploy/images/qemuarm/sdk-debian-buster-armhf-docker-archive.tar.xz
> > +docker load -i
> > build/tmp/deploy/images/qemuarm/isar-image-base-debian-buster-armhf-1.0-r0-docker-archive.tar.xz
> > ``` 
> >    - Run a container using the SDK container image (following
> > commands starting with `#~:` are to be run in the container)
> >   
> >   ```
> > -docker run --rm -ti --volume "$(pwd):/build"
> > isar-sdk-buster-armhf:latest +docker run --rm -ti --volume
> > "$(pwd):/build" isar-image-base-debian-buster-armhf:1.0-r0 ```
> >   
> >    - Check that cross toolchains are installed
> > diff --git a/meta/classes/image-sdk-extension.bbclass
> > b/meta/classes/image-sdk-extension.bbclass index
> > 426b92595554..fa15b588068c 100644 ---
> > a/meta/classes/image-sdk-extension.bbclass +++
> > b/meta/classes/image-sdk-extension.bbclass @@ -80,7 +80,7 @@
> > do_populate_sdk() { # generate the SDK in all the desired container
> > formats if [ -n "${sdk_container_formats}" ] ; then
> >           bbnote "Generating SDK container in
> > ${sdk_container_formats} format"
> > -        containerize_rootfs "${SDKCHROOT_DIR}"
> > "sdk-${DISTRO}-${DISTRO_ARCH}" "${sdk_container_formats}"
> > +        containerize_rootfs "${SDKCHROOT_DIR}"
> > "${sdk_container_formats}" fi
> >   }
> >     
> 
> This might be wrong. Containerized rootfs image and containerized sdk 
> image are using the same name, so output files will be overwritten.

I will add a way to provide a prefix. So if one recipe needs to
generate multiple containers, sdk maybe just being one weird reason to
have multiple rootfs coming out of the same recipe.

That will allow this series to continue even whith the whole "SDK
should be an image" story still going on.

Henning

> Meantime normal non-containerized SDK image is still using
> sdk-*.tar.xz output file mask.