public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Henning Schild <henning.schild@siemens.com>,
	Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH v5 3/7] vm-img: shorten code by using variables we have
Date: Thu, 16 Dec 2021 19:45:58 +0300	[thread overview]
Message-ID: <20211216164602.326689-4-amikan@ilbers.de> (raw)
In-Reply-To: <20211216164602.326689-1-amikan@ilbers.de>

From: Henning Schild <henning.schild@siemens.com>

This is a purely cosmetic change making use of shorthands we have.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 meta/classes/vm-img.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/vm-img.bbclass b/meta/classes/vm-img.bbclass
index debdf3b..e94b6de 100644
--- a/meta/classes/vm-img.bbclass
+++ b/meta/classes/vm-img.bbclass
@@ -37,10 +37,10 @@ CONVERSION_OPTIONS = "${@set_convert_options(d)}"
 do_convert_wic() {
     rm -f '${DEPLOY_DIR_IMAGE}/${VIRTUAL_MACHINE_IMAGE_FILE}'
     image_do_mounts
-    bbnote "Creating ${VIRTUAL_MACHINE_IMAGE_FILE} from ${WIC_IMAGE_FILE}"
+    bbnote "Creating ${VIRTUAL_MACHINE_IMAGE_FILE} from ${SOURCE_IMAGE_FILE}"
     sudo -E  chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \
     /usr/bin/qemu-img convert -f raw -O ${VIRTUAL_MACHINE_IMAGE_TYPE} ${CONVERSION_OPTIONS} \
-        '${PP_DEPLOY}/${SOURCE_IMAGE_FILE}' '${PP_DEPLOY}/${VIRTUAL_MACHINE_IMAGE_FILE}'
+        '${PP_DEPLOY}/${SOURCE_IMAGE_FILE}' '${VIRTUAL_MACHINE_DISK}'
 }
 
 addtask convert_wic before do_build after do_wic_image do_copy_boot_files do_install_imager_deps do_transform_template
-- 
2.25.1


  parent reply	other threads:[~2021-12-16 16:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 16:45 [PATCH v5 0/7] vm-img improvements and fixes Anton Mikanovich
2021-12-16 16:45 ` [PATCH v5 1/7] vm-img: move template out of package into SRC_URI file Anton Mikanovich
2021-12-17 14:12   ` Henning Schild
2021-12-17 14:36     ` Anton Mikanovich
2021-12-16 16:45 ` [PATCH v5 2/7] vm-img: use two different ovf templates for vmware/virtualbox Anton Mikanovich
2021-12-16 16:45 ` Anton Mikanovich [this message]
2021-12-16 16:45 ` [PATCH v5 4/7] vm-img: drop not used variables Anton Mikanovich
2021-12-16 16:46 ` [PATCH v5 5/7] vm-img: set vmware machine type to 64bit in our template Anton Mikanovich
2021-12-16 16:46 ` [PATCH v5 6/7] vm-img: make use of isars template class for most of the tmpl variables Anton Mikanovich
2021-12-16 16:46 ` [PATCH v5 7/7] meta-isar: switch virtualbox test from buster to bullseye Anton Mikanovich
2021-12-16 20:25 ` [PATCH v5 0/7] vm-img improvements and fixes Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211216164602.326689-4-amikan@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox