From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7041956804245323776 X-Received: by 2002:a05:651c:323:: with SMTP id b3mr16893185ljp.316.1639686342918; Thu, 16 Dec 2021 12:25:42 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3b9c:: with SMTP id g28ls1856839lfv.3.gmail; Thu, 16 Dec 2021 12:25:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyXXh7pTOJibCSUwgzw1W532LqOdx1mzFjbF+dFPFMNrR/z23lXkCaAFVUXNnsOZR3KdSeU X-Received: by 2002:a05:6512:3d8a:: with SMTP id k10mr15867712lfv.605.1639686341818; Thu, 16 Dec 2021 12:25:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1639686341; cv=pass; d=google.com; s=arc-20160816; b=jjk87xLS403uGHGQX+zZRClt1XObXt5ajDbUDkRzqKzlqWUf0lP2WqRIzhZTaHSaC6 QTVKneq6F2FvR7NDZbOP/NU2HoVtPAkQbGXvUXmPJknRSgFVH9QldVTcgPGEtab8WGWk YSonMHVl3Uv/aNeZb/hOdsZMPcrRfG+1o7nuBj3uSJzKr+Cjd30eNIFUKDxNnWuCIVL6 qTfE7QRHj3ZcArD688Y3XN0WGHaBgTPgF1SZxkjLB6/YsQi9Maak3XsL4snV6usAVt6x t5DHoooH6p9+SFKmIxEG+D5L2bGyaKd+y4n2Xp7Hbkwyw5F7gzYmxisw3Tzikcxyp7ci 0j/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=8v5c/qMGn6tAiIIJ4u9dz5qncbM7GoS6cK4Ww3jle24=; b=Oaa3zYaJDjmLTcc59Oc7iehXQ2FzRwdmkoXCCqv8KLRG8bHxFIb1w6p9JD6A+/KFuh ByeQ51yHYWaoMSAjDXO2t1laa/3L4Qk1r2TGiObB4NY9IIeCoeUb+rz+LSaGvi6kizGB 6g3BSXRiufQ76nzAJOu8FYkpl4NJqnmLqisKv1OoG85JCgFh2+cD9j99OtiqLBKRVG2d 9qyExhYudSzfoHqgJSIN124oajm/rvMok7GKfoDy2GpKOWzJYgfLxcOWOZPYGIfsAeS1 vwYVN0hYM8DKQyQAHBIwqBO2prDBMwOk58gSX9EbZTywvDgNe4NcOsVAmTypKea6E6sj PX/A== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="xN/rSoOk"; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.79 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70079.outbound.protection.outlook.com. [40.107.7.79]) by gmr-mx.google.com with ESMTPS id d18si270892lfg.3.2021.12.16.12.25.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Dec 2021 12:25:41 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.79 as permitted sender) client-ip=40.107.7.79; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="xN/rSoOk"; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.79 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Woo+JiC6TJVObAT2VWnOxhrj1IPPeGz5FL7bq9xVLJGiUAWaeE2viagBSK83CldCFFieDMGkP6jMWV19AcR0H6SrhFTTtAEKTGFqCeVx0wrnUSIjUCT+Evl7nmdDOEy5NPaGMfok/qNaC2B2vlu9tmzBJb0kfliAJ8JTy39jDN3HdAwCHJXfWXirj+t9Lvgn3Qk9Bya4vAYYv8oggO4LIj5QhTbfJmB3yCrVp0gJA803B/b5uBmaY4t2nrEe65hu41ukQfhG73F82dYGWTLVIgCiknwMlVLOBK2APDrfL/BwWwOfl3p1Rwlkg1QuiSfSBhGTnLH0z9Fw72emuMRPJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8v5c/qMGn6tAiIIJ4u9dz5qncbM7GoS6cK4Ww3jle24=; b=Omq16ReLoKMo9ecDq/6EhAfq+RJZ0wDy6fGHuF+kDZuwFClGg0uA9OQFeSppiSOHd90/1lNJWQ9HWp8dfL1pHMQoV11/VhzLfg5UW6Y8CeOAgUfofvVHpNfXeg3TlDK6WB3G3DlSc8xJ5DAowyaBvSOHEIF51gN/shH4nftrwkiJZ5pcppR6QLgMwetpfkrT3baQMAMhVWX1JLoAxlZk/ixPsf2ipTw3WrwEKJ3yqPtWcps5f2dBVm6mrKMNSsSu4PXoLS4DrLPgPjSReAhkIb48b4RD2toObUhpNL598DbjZ3+b60Y+lEGtrcnChQAIj+sLmDcqrfGWQAwo/6lAIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.71) smtp.rcpttodomain=ilbers.de smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8v5c/qMGn6tAiIIJ4u9dz5qncbM7GoS6cK4Ww3jle24=; b=xN/rSoOk0568HvOMzeIZVlfRQXbC+SJ6K/Q119Wl94V7EcVNHJm7Sk5ydnlJULlA0ScbIvAZyhWZT09Dbz08Ms/EFRnHFgvQyjyjleSpDrLNBGJL9DtftRvgOANCSPzZK5n9cOuR0wKXgFJh0E6B9bYMh6YjJneciOXu99WJx5wScaDn6ZAejft5sckI/qLxr+KUgbMpONbzkHLUsDAeYMvZY9mfXKY4UGRqNDve9zg/3wgadxSJ+cBnPYkaWxzfEWLK6AQv31zCgKl0+Xi21ErLeVWvG/HGkTWksk+cju/xUykHY8mKMv8Zv3v8T1tO2Q89gJQPYvqk/q0rC3haFA== Received: from SV0P279CA0069.NORP279.PROD.OUTLOOK.COM (2603:10a6:f10:14::20) by PR3PR10MB4270.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:a2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec 2021 20:25:40 +0000 Received: from HE1EUR01FT027.eop-EUR01.prod.protection.outlook.com (2603:10a6:f10:14:cafe::1a) by SV0P279CA0069.outlook.office365.com (2603:10a6:f10:14::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16 via Frontend Transport; Thu, 16 Dec 2021 20:25:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.71) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.71 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.71; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.71) by HE1EUR01FT027.mail.protection.outlook.com (10.152.0.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4778.12 via Frontend Transport; Thu, 16 Dec 2021 20:25:39 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SKA.ad011.siemens.net (194.138.21.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Thu, 16 Dec 2021 21:25:39 +0100 Received: from md1za8fc.ad001.siemens.net (167.87.33.86) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Thu, 16 Dec 2021 21:25:38 +0100 Date: Thu, 16 Dec 2021 21:25:36 +0100 From: Henning Schild To: Anton Mikanovich CC: Subject: Re: [PATCH v5 0/7] vm-img improvements and fixes Message-ID: <20211216212536.1d120174@md1za8fc.ad001.siemens.net> In-Reply-To: <20211216164602.326689-1-amikan@ilbers.de> References: <20211216164602.326689-1-amikan@ilbers.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-Path: henning.schild@siemens.com X-Originating-IP: [167.87.33.86] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a8e550c-ae39-40b0-ef5b-08d9c0d239d8 X-MS-TrafficTypeDiagnostic: PR3PR10MB4270:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xTsOpWUF/T+vUelzSJCs1RQvZB6Ni2opiO01S7YwXbPf5UfrKSKOaX9SgnJ18u/wjMPBe7xU9Np2pgooDa43u9BAuS1jjaROopSjRoyDhwcGNyW5b20bOKJcrYUSBVf1Ay/zHP7anwRJ30wKbEhPzMhwPr0O7OshQQtHGWK+SLK+Eg6LOvb5pLoPyCaiqLGAtuSZffl+WVODETj8s2Na1Ar9Ep22Dmn3RsoYABmnfeYfeUITp3W7Y1PLv3TbYbcKgEulPMMi5Y1P0OYDbLPta1w1+U0ZHxchdEjc+T0vpfOq4gcKTfPS/m8bMu1WjERWy8e2R+VoNPdwY7o1bbVdh8jOLHIk94B0mnecmjqMkf67yqxSd/KYzWWdyyLbmsrGCyRC5/ZlFAvYe3Up2MuQJo64Wc23SiPt2/oSFWFTYKlQuPiRdtwmFv5Sg/qscbm6rFSOtbdnASgH6SxSuLIIY8Te9QbCMsUdoTCQoZ3qsSX732254bJ6Xl0pPoq/62NNvAivke2w0to/CCTcYd7Jt1WUNQM7Iw1WIWb0hfDZQOORAWmZdcGW28zisdiv6OAb5hkYpa7VA3Nf8E73DPh7juplRB8oiYoeWS4YgfCyOj/+iQeD67d9/fstAHeuGOdadwxJ+2SERilR8tS11YyVYqEWHtlehBpzRuAkuZmSr7B1uwZVU79hUJbyvEivUVJJIeUc9yStEjw40RoBU+ONnqCAemPFdTAiNM0l9I00xoGWT4IPljj74yjHwlwI1T4uGmeA4CvkOWbYG64IDGYPbexJPHIVxWzy9yHKPFOGGfI= X-Forefront-Antispam-Report: CIP:194.138.21.71;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(82310400004)(4326008)(81166007)(7696005)(55016003)(26005)(336012)(508600001)(82960400001)(186003)(16526019)(8936002)(9686003)(36860700001)(70586007)(70206006)(356005)(47076005)(8676002)(83380400001)(1076003)(40460700001)(44832011)(6916009)(956004)(316002)(2906002)(5660300002)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 20:25:39.5050 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a8e550c-ae39-40b0-ef5b-08d9c0d239d8 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.71];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT027.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB4270 X-TUID: u7E54x2OGt4I Thanks so much for taking this over. I did not check what was changed, but will simply approve that "taking over" as it sound like minor style fixes wanted and done by the maintainer. Henning Am Thu, 16 Dec 2021 19:45:55 +0300 schrieb Anton Mikanovich : > changes since v4: > - format commit messages > > changes since v3: > - change the way we play with the SRC_URI path in p1 > - adding cover letter again > > changes since v2: > - change avocado code and move renamed bullseye test into another > test > > changes since v1: > - rebase on next/avocado > > > The vm-img support we currently have is a bit broken in various > aspects. Most prominently the resulting ova files are accepted by > vmware only with warnings. And UEFI booting did not really work in > virtualbox or vmware. > > This series makes the template for the appliance a file one can > override with a custom template. Which should allow close to any > special configuration that the VMMs can express in their respective > ovf dialects. It further makes changes to the templates we ship with > isar to hopefully give people a decent baseline so they will not even > need custom templates. And there is some code cleanup to the vm-img > class. > > Henning Schild (7): > vm-img: move template out of package into SRC_URI file > vm-img: use two different ovf templates for vmware/virtualbox > vm-img: shorten code by using variables we have > vm-img: drop not used variables > vm-img: set vmware machine type to 64bit in our template > vm-img: make use of isars template class for most of the tmpl > variables > meta-isar: switch virtualbox test from buster to bullseye > > meta-isar/conf/local.conf.sample | 2 +- > meta-isar/conf/machine/vmware.conf | 2 + > ...a-buster.conf => virtualbox-bullseye.conf} | 2 +- > meta/classes/vm-img.bbclass | 35 ++--- > .../vm-img/vm-img-virtualbox.ovf.tmpl} | 132 > +++++++----------- meta/classes/vm-img/vm-img-vmware.ovf.tmpl | > 127 +++++++++++++++++ .../vm-template/vm-template_0.1.bb | > 16 --- testsuite/build_test/build_test.py | 6 +- > 8 files changed, 199 insertions(+), 123 deletions(-) > rename meta-isar/conf/multiconfig/{virtualbox-ova-buster.conf => > virtualbox-bullseye.conf} (77%) rename > meta/{recipes-devtools/vm-template/files/vm-template.ovf.tmpl => > classes/vm-img/vm-img-virtualbox.ovf.tmpl} (54%) create mode 100644 > meta/classes/vm-img/vm-img-vmware.ovf.tmpl delete mode 100644 > meta/recipes-devtools/vm-template/vm-template_0.1.bb >