From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7046636801357774848 X-Received: by 2002:a2e:a169:: with SMTP id u9mr16001981ljl.219.1640672985006; Mon, 27 Dec 2021 22:29:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:158e:: with SMTP id bp14ls1407146lfb.2.gmail; Mon, 27 Dec 2021 22:29:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJy7PujIzXnTdd+vkKpOp8Tth6ubbvrYqnN1u7oO5Mrelh+tWyK87TXonhS+4fWdRAB0VQRa X-Received: by 2002:a19:7b1d:: with SMTP id w29mr17780194lfc.674.1640672984038; Mon, 27 Dec 2021 22:29:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1640672984; cv=none; d=google.com; s=arc-20160816; b=NEFrdJ3lfXHwj27k798mocL0IhDI6Df8z+yfH71/ug7fZ1Qq+RrAb3PB5ocyvRmqv6 AF9eBBesfmevxCMCAuiatg+oBfluPWDsr3/I6fgXohPLZUrqNYEZUPi1L1HaYcefGns7 /EBSMwF/fucYUCuHrqX0odbnKAoIwp4fs0+BfMG0icAYh0SyRLPwrfNvYOesKYAA+KGP U/eEshBMc0fkNFx78/L4tTtT6RKmIN7EW83V6TsGOVuoPP4Ec1UK8mi5GU9ScYVqpvoI baaWIiA2+NxahKlD7mwnfRjPFjTnaoahpOe7M0sxlRQXEykP4EwP5OppNUbiBiZOOv55 /E8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=dxtYfTEqkqH5cNCE7373JaHqAkrcG6x7+4ULfTLY3I8=; b=NMkswP8ekRfgjGcksWc6rtFMYSbO31ELWTZyuM9JztVgNEgdAG6hP0eRZslwaa+KeW sK8l7AXU2lxniJNFQp+NZNFYQ9M1GlEvdwYqlurymkWlYmDSNAW1+5zAUheRq0z3v9U4 DzzzjnOrJ4H8Sr/O8kzu3C7EO1C+xPUgEf47YnYnvacncurvcze/8bgCfSk96y9Wm2Sq mak2L4mD4ggnZBy+KJODbVOwv9aBOiT7kM9ZUb4lIS5XwEhbheEXu+97Rvtlsl19yg7D w64UAnygGubs4qzKZRQVZ6B4URO3/fxuG/Cp/b/6UOqFnClc63tb8dzK30Q49LmB9bmr 6Byg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id k19si807209lfv.12.2021.12.27.22.29.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Dec 2021 22:29:44 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from localhost.localdomain (mm-243-79-214-37.mgts.dynamic.pppoe.byfly.by [37.214.79.243] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 1BS6TdjD028769 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Dec 2021 07:29:43 +0100 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH 2/2] image: Protect shared deploy directory usage Date: Tue, 28 Dec 2021 09:29:32 +0300 Message-Id: <20211228062932.167496-3-amikan@ilbers.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211228062932.167496-1-amikan@ilbers.de> References: <20211228062932.167496-1-amikan@ilbers.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: aJqYBoVPMz8s Image deployment directory is shared between the targets with the same machine name, but there was no any protection when copy bootables with the same file names. So building multiconfig qemuamd64 targets can fail with: ERROR: mc:qemuamd64-buster-tgz:isar-image-base-1.0-r0 do_copy_boot_files: Execution of 'tmp/work/debian-buster-amd64/isar-image-base-qemuamd64-targz-img/1.0-r0/temp/run.do_copy_boot_files.31554' failed with exit code 1: cp: cannot create regular file 'tmp/deploy/images/qemuamd64/isar-image-base-debian-buster-qemuamd64-initrd.img': File exists This is caused by initrd file creation by the multiple do_copy_boot_files instances. To fix the issue additional lock introduced. Signed-off-by: Anton Mikanovich --- meta/classes/image.bbclass | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index bd58056..a10f0d7 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -139,6 +139,7 @@ EOF } do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" +do_copy_boot_files[lockfiles] += "${DEPLOY_DIR_IMAGE}/isar.lock" do_copy_boot_files() { kernel="$(realpath -q '${IMAGE_ROOTFS}'/vmlinu[xz])" if [ ! -f "$kernel" ]; then -- 2.25.1