From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7044773043327991808 X-Received: by 2002:a05:620a:29ce:: with SMTP id s14mr7184164qkp.219.1641821575563; Mon, 10 Jan 2022 05:32:55 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:622a:1801:: with SMTP id t1ls4752139qtc.9.gmail; Mon, 10 Jan 2022 05:32:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8AgFBpIighxfFmTWUjuozfKzKBt74tk69iL0ZIgLZhm+d8Lff038EbrLG3uymY/xB0IaH X-Received: by 2002:ac8:7d88:: with SMTP id c8mr14047578qtd.466.1641821575033; Mon, 10 Jan 2022 05:32:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1641821575; cv=pass; d=google.com; s=arc-20160816; b=cvmczdP1JDB8TYZA+mlDs3QsYsLB38Y7Gqr82vxbGnhjRbhG82SVv/NLwXAq+a5CU0 eQ6rtTkJWnNsa408FiZfatl3ipa9gUPNDgDb2PpJEdxW4ZtJxUnDQC1pZ0OsyoyFSwmD FFKcyz1SbZbT9BRF1gd7LfncNRvoP6mdX9l7gHavaM7GWBbE5RnWQNZ3p2QjX0k0dnrJ OlLyEwjwrlqADMsafrMWuNDdIyjibBKg18m1e8drAzVtf+VmN1twD1OoII6MdxrXeaX0 f7m/ymmZwEc9nG+wEAQ/8DfAj8rAAY6cuARNnY63mhrXRlNoH3d3ZdQntpMKn+HN7Znk 7BKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=jo1/+XBTr+lOa/TFAO/1e0kxggxTZ3yXaW1qNIpaP7A=; b=dwgU1aK3fD0kdMyFnDH8mmb74H71euvaSGTxDEqKTJKFahNv0b1z8dkyZPakCq1ns2 uDA2baV06tgjhUdfMozD23rfm7VqKrCYkRifwaVTD5QQLwoiyKoWWk6zbsrZZIQD/NXs igWA04iTAws2mL4s8PGnLtXXTWuHGS6po3/MWXU7A2VL2zwGvUYfntUr6m7gMf96ETsy Lx1KtXpAn0aXbiDzllSQHKdFbVOSnYhfmzTGy4muNfXRXsEAk3AzZUr4JzFyyYlNeZ0P 6wXAPSg0x3phv6rpmHcWq1tS+BpXUWsIKvGKYWbOL/O4GsdLWlFEC390eZlxtMTbMPvl 4Jxg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=IoVoU3Ky; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.52 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2052.outbound.protection.outlook.com. [40.107.20.52]) by gmr-mx.google.com with ESMTPS id s7si458638qkp.0.2022.01.10.05.32.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jan 2022 05:32:54 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.52 as permitted sender) client-ip=40.107.20.52; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=IoVoU3Ky; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.52 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CjmM9mgMCw4RN8Ch/E/bSdiuuHy1bevZAmrGCp8+M0vrjaJNOzQunjIT4HN55cbDZYvtxCfglPMwdS2OTBouyxNzjo9U5sLCbDCc8qCdvPUBnP/HlN+1T/eyV3PcI7U6rgbpiSzPe6SH3SrTziLsu4uUZG0A0rqp8s48Prvwrrfor8kaROBaQwV36sb6hkOAjTUjjZ2NffMKBgj749zJXMi03FYuc3a5fFXxsTHO0mnYzfN9r+NliM+Bdjyc99btNbge/4rIqoT4diQtS7JnAphoURReMu9bMkNx9/8Ip3c4NnwSmTUMkwGDW/XkYd3NL4t/91q5uZJvJo+U/Qrztw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jo1/+XBTr+lOa/TFAO/1e0kxggxTZ3yXaW1qNIpaP7A=; b=UNGrFoirIqBPCLJawQDezXicasDxen1iOHlq8WuyPj0lTYBvPuyP5e4zmeLOu90CLHxZ6r3xH7ZSbRLAqtMlCme/qMdPYzwZSfM7zdFjpVhcHjFPYPiZm+ZP9YZJW3oHybLCdwu/HvXco+JPRbhrBN2RTL2HR1YWh8ikbBTxkvlRq1/Jl4W/w2pEKFXw5YxzC9GrC4kwnI1lxeuTjDGuZkAdoZ/TtNkxvd1qELhmPKUXBXAeNu1PrqrITvmmzwqoo/usPKMkqSVYAk0QC/jtr1A44zVzudln87CljmIjRDg/CvZntpJndRsafKA9FYGyg6wtwRLxiqVfGI+DA/z3kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.72) smtp.rcpttodomain=ilbers.de smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jo1/+XBTr+lOa/TFAO/1e0kxggxTZ3yXaW1qNIpaP7A=; b=IoVoU3KyntRm/imOllJdhO+7zkxpZxizRCA0beQKcaJRlV08zd5KlhtyyA+rFPEUx0TVRMmeYqSbutp9XhMTAKKasIPcP3Q2E6rjyrEO32p6OOebnGvnCVW/9lvpoD7sGswhL8RxSQE+AdOYz3LnMswSFavJP9ssoAn8aQIhiK799aBydy5CdK/vL2ednpHsNX3Pnan1TKw8JkuOgD9lupfy5BKoONIeAY+9kxnLpcbY9kdwf4QGrcHZyfD/rm94apoiHNV3DCDSajoBeD0gB79IKbGZZ3Hj70SBgTeFWsrb00Hta+vQmXFB6rqsZtF9iisbYA2Y6rcsfo30D3P0lQ== Received: from DU2PR04CA0020.eurprd04.prod.outlook.com (2603:10a6:10:3b::25) by PAXPR10MB4752.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Mon, 10 Jan 2022 13:32:52 +0000 Received: from DB5EUR01FT054.eop-EUR01.prod.protection.outlook.com (2603:10a6:10:3b:cafe::54) by DU2PR04CA0020.outlook.office365.com (2603:10a6:10:3b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7 via Frontend Transport; Mon, 10 Jan 2022 13:32:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.72) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.72 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.72; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.72) by DB5EUR01FT054.mail.protection.outlook.com (10.152.5.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4867.7 via Frontend Transport; Mon, 10 Jan 2022 13:32:52 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SMA.ad011.siemens.net (194.138.21.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 10 Jan 2022 14:32:52 +0100 Received: from md1za8fc.ad001.siemens.net (139.25.68.217) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 10 Jan 2022 14:32:52 +0100 Date: Mon, 10 Jan 2022 14:32:46 +0100 From: Henning Schild To: Uladzimir Bely CC: Subject: Re: [PATCH] ci: make vm_start logs readable by all users Message-ID: <20220110143246.7f0b31aa@md1za8fc.ad001.siemens.net> In-Reply-To: <5338758.rdbgypaU67@hp> References: <20211223055720.4147-1-ubely@ilbers.de> <20220104205839.2fdbb6c9@md1za8fc.ad001.siemens.net> <5338758.rdbgypaU67@hp> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-Path: henning.schild@siemens.com X-Originating-IP: [139.25.68.217] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 36db4785-cd8b-4eb4-0a91-08d9d43db401 X-MS-TrafficTypeDiagnostic: PAXPR10MB4752:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gQ5+iiUKY8UXHpCRbbLLP9W+7wuaiXWyDpwaszhM2msVTxy4TWGUv6IYl8uUbVNjxDzeaXjBLhKWDjA4l/aN1asLuJQbV6oDKp/DS2ylLcHa4t4+ZPSUn0/DUtTh+2+MOWO6sDYYa4A/aOUZllnWGzeS/noI2VKp+LY4J5900oqRlYdPEGPnwTbQDDt4k8VVGEGZsji5xaWqrZMrxi0xnkE1wtvl3/+dtsISpoYF2b+ftpD5FiTFP8/DDrvny1rofpaQmUitfisBvVU7z7h7NYu23t4ocRoc17NMR/d4/pnEVpDjIiKG9D1/a890vojDZZppliUtSXWiwAGItZ6en+Vbhth94dMPLHplidWR8F0pJcxPzKUOPBm1ZXJQUf5m0iIi+2LCmY6hnQThNPgMBbo8va0voKS8N3I+tKJ/hdZtCPT3MGQjbH6fBKHgSf6c78e0mpxcxmOefQWUaTLUDlmfSwgLFZfuSfVH9CkQSE58eT4w6PNmqbrzqXBefoLLsUGK9lUMnc5FZDUwTGDDkVsnh8FJcWAr9U7PNvSt471u3JOOC4ShszdDFtPyTRxn712IkASbp1nqkf9tInW/EIBdk7faAUZSCuAhdUAepDflxWEfr7du02ehp7qo03j/EqZH15qSveY4zAex+QFu3JY6BS+SvCHIgzAaNPbXBLY4pfrUn1SGhxzmUvWEXgyNJcaaJogQmPewPpUjUn9eJjU5Ytvpp5ODQ1PprXGACDv1m6R4tBcAUybOJ/jrwsg/iIvAUI55PjImXLQKZYQza8AUBXe/59lJHZ8yccdpRsxH1wVM0EMH/TUkj2gF70TuvcTowDxW2aNOnh7um7nVLnh63bipI/vnDHLBs9ORv6o= X-Forefront-Antispam-Report: CIP:194.138.21.72;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(40470700002)(46966006)(36860700001)(6916009)(316002)(81166007)(956004)(70586007)(70206006)(2906002)(16526019)(508600001)(9686003)(6666004)(7696005)(86362001)(1076003)(82960400001)(55016003)(26005)(82310400004)(44832011)(4326008)(5660300002)(186003)(356005)(336012)(47076005)(40460700001)(8676002)(8936002)(26730200005)(19860200003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 13:32:52.7071 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36db4785-cd8b-4eb4-0a91-08d9d43db401 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.72];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT054.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB4752 X-TUID: 5oFKC3C2JXDm Am Mon, 10 Jan 2022 15:50:00 +0300 schrieb Uladzimir Bely : > In mail from =D0=B2=D1=82=D0=BE=D1=80=D0=BD=D0=B8=D0=BA, 4 =D1=8F=D0=BD= =D0=B2=D0=B0=D1=80=D1=8F 2022 =D0=B3. 22:58:39 +03 user Henning > Schild wrote: > > Am Thu, 23 Dec 2021 06:57:20 +0100 > >=20 > > schrieb Uladzimir Bely : =20 > > > This changes permissions for ${BUILD_DIR}/vm_start_.*_log.txt > > > from 600 to 644 to make them readable not only for jenkins user. =20 > >=20 > > not everybody uses jenkins ... make it "CI user" > > =20 >=20 > OK. >=20 > > > Signed-off-by: Uladzimir Bely > > > --- > > >=20 > > > testsuite/vm_boot_test/vm_boot_test.py | 1 + > > > 1 file changed, 1 insertion(+) > > >=20 > > > diff --git a/testsuite/vm_boot_test/vm_boot_test.py > > > b/testsuite/vm_boot_test/vm_boot_test.py index 01623c5c..69e7f4ae > > > 100644 --- a/testsuite/vm_boot_test/vm_boot_test.py > > > +++ b/testsuite/vm_boot_test/vm_boot_test.py > > >=20 > > > @@ -46,6 +46,7 @@ class VmBase(Test): > > > fd, output_file =3D tempfile.mkstemp(suffix=3D'_log.txt', > > > =20 > > > prefix=3D'vm_start_' + > > >=20 > > > distro + '_' + arch + '_', dir=3Dbuild_dir, text=3DTrue) > > > + os.chmod(output_file, 0o644) =20 > >=20 > > This smells like other output files could also have wrong > > permissions while being relevant. =20 >=20 > It looks like a specific behaviour of tempfile.mkstemp() function, > that always creates file readable/writable only by the user ID. So, > only vm logs are affected. Yes, apparently that one is trying especially hard to make things "secure". You could also switch to=20 with tempfile.TemporaryFile() as fp in which case you should not have such problems. Henning > > If that might be the case, maybe centrally adjust umask for all of > > the testsuite. =20 >=20 > I've just played a bit with umask and it seems to work nice with > something like 'touch', but python's tempfile.mkstemp() still always > creates files with 0600 permissions, regardless of umask set for the > same directory. >=20 > >=20 > > Henning > > =20 > > > cmdline =3D start_vm.format_qemu_cmdline(arch, build_dir, > > >=20 > > > distro, output_file, None) =20 >=20 >=20 >=20 >=20