public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: [PATCH v4 11/12] dpkg-base: Cleanup from buildchroot parts.
Date: Tue, 25 Jan 2022 13:39:14 +0100	[thread overview]
Message-ID: <20220125123915.1053-12-ubely@ilbers.de> (raw)
In-Reply-To: <20220125123915.1053-1-ubely@ilbers.de>

This removes remaining buildchroot-related tasks and variables
from dpkg-base class while there are not used anymore.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 meta/classes/dpkg-base.bbclass | 19 +++----------------
 meta/classes/dpkg.bbclass      |  4 ----
 2 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index ea914cd4..513d5217 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -167,6 +167,7 @@ addtask prepare_build after do_patch do_transform_template before do_dpkg_build
 # If Isar recipes depend on each other, they typically need the package
 # deployed to isar-apt
 do_prepare_build[deptask] = "do_deploy_deb"
+do_prepare_build[depends] = "${SCHROOT_DEP}"
 
 BUILDROOT = "${BUILDCHROOT_DIR}/${PP}"
 
@@ -216,14 +217,11 @@ dpkg_runbuild() {
 }
 
 python do_dpkg_build() {
-    lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") + "/isar.lock",
-                             shared=True)
-    bb.build.exec_func("dpkg_do_mounts", d)
+    bb.build.exec_func('schroot_create_configs', d)
     try:
         bb.build.exec_func("dpkg_runbuild", d)
     finally:
-        bb.build.exec_func("dpkg_undo_mounts", d)
-        bb.utils.unlockfile(lock)
+        bb.build.exec_func('schroot_delete_configs', d)
 }
 
 addtask dpkg_build
@@ -257,8 +255,6 @@ do_dpkg_build_setscene[dirs] += "${S}/.."
 
 do_dpkg_build[depends] = "${SCHROOT_DEP}"
 
-KEEP_INSTALLED_ON_CLEAN ?= "0"
-
 CLEANFUNCS += "deb_clean"
 
 deb_clean() {
@@ -267,15 +263,6 @@ deb_clean() {
         for d in ${DEBS}; do
             repo_del_package "${REPO_ISAR_DIR}"/"${DISTRO}" \
                 "${REPO_ISAR_DB_DIR}"/"${DISTRO}" "${DEBDISTRONAME}" "${d}"
-            if [ "${KEEP_INSTALLED_ON_CLEAN}" = "1" ]; then
-                continue;
-            fi
-            package=$(basename "${d}")
-            package_remove="/usr/bin/apt-get remove -y ${package%%_*}"
-            sudo -E chroot ${BUILDCHROOT_DIR} ${package_remove} || true
-            if [ "${BUILDCHROOT_DIR}" != "${BUILDCHROOT_TARGET_DIR}" ]; then
-                    sudo -E chroot ${BUILDCHROOT_TARGET_DIR} ${package_remove} || true
-            fi
         done
     fi
 }
diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 38845a16..99d1a074 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -13,8 +13,6 @@ dpkg_runbuild() {
     E="${@ isar_export_ccache(d)}"
     dpkg_build_export PARALLEL_MAKE "${PARALLEL_MAKE}"
 
-    schroot_create_configs
-
     distro="${DISTRO}"
     if [ ${ISAR_CROSS_COMPILE} -eq 1 ]; then
         distro="${HOST_DISTRO}"
@@ -52,6 +50,4 @@ dpkg_runbuild() {
         --build-dir=${WORKDIR} ${WORKDIR}/${PPS}
 
     deb_dl_dir_export "${WORKDIR}/rootfs" "${distro}"
-
-    schroot_delete_configs
 }
-- 
2.20.1


  parent reply	other threads:[~2022-01-25 12:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 12:39 [PATCH v4 00/12] Sbuild/Schroot migration Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 01/12] dpkg-gbp: Use separate command to export tarball Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 02/12] dpkg-gbp: Use host tools for dsc preparation Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 03/12] sbuild: Add recipes for host and target rootfs to run sbuild Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 04/12] sbuild: Introduce a class for another build method Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 05/12] dpkg: Build packages with sbuild Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 06/12] sbuild: support of DEB_BUILD_PROFILES Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 07/12] sbuild: add ccache support Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 08/12] dpkg: Remove builddeps install task Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 09/12] dpkg-base: Switch devshell to use schroot Uladzimir Bely
2022-01-25 12:39 ` [PATCH v4 10/12] dpkg-base: Switch apt_fetch and apt_unpack " Uladzimir Bely
2022-01-25 12:39 ` Uladzimir Bely [this message]
2022-01-25 12:39 ` [PATCH v4 12/12] doc: Add sbuild-related documentation Uladzimir Bely
2022-02-04 13:39 ` [PATCH v4 00/12] Sbuild/Schroot migration quirin.gylstorff
2022-02-04 14:28   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125123915.1053-12-ubely@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox