public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "Schmidt, Adriaan (T CED SES-DE)" <adriaan.schmidt@siemens.com>
Cc: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"Moessbauer, Felix (T CED SES-DE)" <felix.moessbauer@siemens.com>
Subject: Re: [PATCH 0/1] sstate bug fix
Date: Fri, 28 Jan 2022 08:15:08 +0100	[thread overview]
Message-ID: <20220128081508.1c54980f@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <AS4PR10MB5318E5A50F79D048B0E1F58DED229@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM>

Am Fri, 28 Jan 2022 07:24:50 +0100
schrieb "Schmidt, Adriaan (T CED SES-DE)" <adriaan.schmidt@siemens.com>:

> Schild, Henning (T CED SES-DE), 27. Januar 2022 21:40:
> > 
> > Some more testing reveals that buildchroot_install_files does not
> > work with that. The reason seams to be that files to be installed
> > did not get fetched when using the cache.  
> 
> An easy fix would be to add a dependency in buildchroot:
> addtask rootfs_install after do_fetch

I will try that. Looking at the code we might well have the same
problem with sdkchroot_install_files, hopefully the fetch dep fixes
both.

> Or turn those files into a package so they get installed in
> rootfs_install instead of "installing" stuff during "postprocess".

Yes both these postprocess functions violate an essential isar rule.
"everything inside rootfs should come from a package"

I think for the stuff from sdkchroot_install_files we can do that
easily and i will add a TODO for that. For buildchroot_install_files it
might be trickier, if we wanted that to be a package we would need to
build it "native" since we do not yet have a buildchroot.

Henning

> Adriaan
> 
> > Will have to see how to deal with that. Stay tuned for a v2 and
> > please not that sstate still has bugs. But those might just be OK
> > to enter a release, that is up to the maintainer to decide.
> > 
> > regards,
> > Henning
> > 
> > Am Thu, 27 Jan 2022 21:18:44 +0100
> > schrieb Henning Schild <henning.schild@siemens.com>:
> >   
> > > This is just a single patch but i think it fixes bugs and should
> > > be considered before a release ... i usually do not do cover
> > > letters for single patches. So here i still do it to point out
> > > that it might be important.
> > >
> > > Henning Schild (1):
> > >   sttate: change rootfs task to cache
> > >
> > >  meta/classes/rootfs.bbclass | 25 ++++++++++++-------------
> > >  1 file changed, 12 insertions(+), 13 deletions(-)
> > >  
> 


  reply	other threads:[~2022-01-28  7:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 20:18 Henning Schild
2022-01-27 20:18 ` [PATCH 1/1] sttate: change rootfs task to cache Henning Schild
2022-01-28  6:57   ` Schmidt, Adriaan
2022-01-28  7:18     ` Henning Schild
2022-01-27 20:39 ` [PATCH 0/1] sstate bug fix Henning Schild
2022-01-28  6:24   ` Schmidt, Adriaan
2022-01-28  7:15     ` Henning Schild [this message]
2022-01-28  7:33       ` Schmidt, Adriaan
2022-01-28  8:09         ` Henning Schild
2022-01-28  9:01         ` Henning Schild
2022-01-28  7:24     ` Henning Schild
2022-01-28  7:38       ` Schmidt, Adriaan
2022-01-28  8:08         ` Henning Schild
2022-02-14  9:28 ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220128081508.1c54980f@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox