From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057983073222131712 X-Received: by 2002:a5d:6349:: with SMTP id b9mr6340815wrw.178.1643361129769; Fri, 28 Jan 2022 01:12:09 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:ec88:: with SMTP id z8ls128952wrn.2.gmail; Fri, 28 Jan 2022 01:12:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJynguO44ibLtv+Ho39WC+S8OlmbzsW3r/m5thgsP8e7/ulHHXqioNgI7eSY/RUPQH+fBXGw X-Received: by 2002:a05:6000:101:: with SMTP id o1mr6302557wrx.487.1643361128920; Fri, 28 Jan 2022 01:12:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1643361128; cv=pass; d=google.com; s=arc-20160816; b=IWTGJl2HtH/JY63vHgSaYxI82ldUNMLY0blq0ojmQzg/CCn96QXfbmAECazqQBv1xf Z2vgDwj5C3Z6Dmp28Z/hsx1n65/+eYWkD2tHUQ7vnyH2H5qoATZqQW0+hPrRwvJtFUMo G1HBDKJIXKA1H2SX2J6TGzNogNDf8dL8smK63Y8Kvb5IpHrcJmmQw4v2GsIPKEmum2NU jUDyo7rOOooz1tUKpMacJtuBx09Aum3cnept3/Y7IPVv1VpOKFk8vOH+aEHdP3cE/zaw z/YzcIyFV4FqMH6iHOjbjRmwmwno16O9tEdzM559K5hoSZ1gyDq5X7NKfriN8N+GOTSZ MidQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=nkCpgTK7T/wX5eteDwORrW93pMIVoCTo8Hvyx7ndSyE=; b=U8Jhd+RgqyNyHP2MaHe5UbRfTYyhL6yy6NivAZRXRfgl13zysrVvXqx5YjIwtEpeGn Y+rLz5R81gHYNBDA9FM6yHW5mRcGfckHGpJK/SrVVaNdNZ36l+ZWSU5z8jBJwJNUcmjV 9tKX2MmfAB9IOKAGTYEr1Ltk6XB5tHCffgkJDvl+7iZDh0c18ljTPSkGBTDQZ7x0Xh7q OBjtEgHD/NaE0C2fAefVopVbyfzL591crNsgrrIm2sEycaAjh6S3ZRVs/L5HoSJQ+zVA Ef5StLxF2h4nc9eaF1KvjOlt5xTB6ZJgEWv79XpkchkC4WU+rZqzIaLPef36vPVTgPrk nCzQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=P3nIZ5WY; arc=pass (i=1); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.41 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80041.outbound.protection.outlook.com. [40.107.8.41]) by gmr-mx.google.com with ESMTPS id v5si455086wme.4.2022.01.28.01.12.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jan 2022 01:12:08 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.41 as permitted sender) client-ip=40.107.8.41; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=P3nIZ5WY; arc=pass (i=1); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.41 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kbL0Xl6q/17+sEAXNe/A6EzXbQa0Lw8UCXyFVlTpnlgLXu5ghXAV/yslYaH5/nf0kBChegKBVterbDiD2IqGYtxOpTihF8UL6Kpsq6BgQYHzT8/UX+/siuQw0KSv8jRNlm2eZzkO2jRr9FEqu/T7+uoKl4BXjVMMK3nApb4JuJn7vEJYbLqiiqDT0iiW/bepjv2IT3vgGO3vfpnInnXU13jgvSHikJNbLovB75beOZTt6wNtdDUGcUTyWpwAfqbMrM+H0fr8kRP8Z/RkwauLuTc6/RQR0No0+t0NtgJvLKRr9qWH/p63FOAcR2o75mr3VFTvN2Tk6HE33MNmXQMG3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nkCpgTK7T/wX5eteDwORrW93pMIVoCTo8Hvyx7ndSyE=; b=Gsz+n5FzTrmxdmRvbAyIFZsbFCvvdhYMLDqPa/n0cTpizIgh5cjtupn9pgyauUq33qiUC0E1qo0s2R8+ffyPHW/shUa2CLyca2mGCQSYnbzHZidSY4BtN0wl9NgHR0k8LXHbW+gSWfRlctwdmBqgIlF0WMejP4eVsDll0JTlpikkFubaGLWqtJNFxrb1kx6F31q2QBdAQ7z7U4Cj+KVqF86RmZYQJMYhGBy3UqHkWV05L7vw+VB+fvo33/S5LoK8rFRN6oeNVZLZ8dvordWbRIalDuwYhLNH8LZfxXPw2ekFnsqlgz177292Dm8oHn/sG1owPaZvINpPM6ENr7YDEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkCpgTK7T/wX5eteDwORrW93pMIVoCTo8Hvyx7ndSyE=; b=P3nIZ5WYApEJ7lHksk7yg1DaKa4F0eB6CtU+B5XEfC7QYv1MSEX28VEQ6+zikquyxNS0x6eqFaAbm+4acF5yDhJU7vknZUeOtIYjmvOVu/k+hE6/dbtIXTcTLy3TLAAb5g0j3im7ENFeyeoYPuCmdtPgilkvq+j9cnZuC6TSeghxgXK2Znsi+LSj1NJF5VN0sVAt4No5T2tOQ+5AdKMXrNm38H6KBsR/Knp5ljFAm3Bx7R7Xy2Slh7KVcM+IRtei9+xYm75F0hWNmqv0Qfo7XRw7Crvbe0fshVx696hIxQrPGodK8CwtlzBL181JTOPLeqFlNbqv9AH980qKJMPa8w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) by AM7PR10MB3144.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:dc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Fri, 28 Jan 2022 09:12:07 +0000 Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::95cb:ffb4:beca:fac0]) by AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::95cb:ffb4:beca:fac0%3]) with mapi id 15.20.4930.019; Fri, 28 Jan 2022 09:12:07 +0000 Date: Fri, 28 Jan 2022 10:12:06 +0100 From: Henning Schild To: Cc: Felix Moessbauer , Adriaan Schmidt Subject: Re: [PATCHv2 2/2] sstate: fix task order and deps Message-ID: <20220128101206.35c50e07@md1za8fc.ad001.siemens.net> In-Reply-To: <20220128090010.13589-3-henning.schild@siemens.com> References: <20220128090010.13589-1-henning.schild@siemens.com> <20220128090010.13589-3-henning.schild@siemens.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0101CA0008.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::21) To AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6f568451-14ba-4d94-b0d0-08d9e23e421a X-MS-TrafficTypeDiagnostic: AM7PR10MB3144:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:612; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3sdhFc80L9RKBIe+PYpcxvOOGpWsabDU/j+9xBY+U6A9UU2mJR4fAXbKSgrux6fsgi9etP6+yNm0qBpfz2jrwaK/5QuAvhL/NzJSXgDlD6W2+kHwZuBV4FLBJywAMwUmJYjgT6AhzxKPEd8WCujysELqVPziRcAOy/VdKCAM+lBsKV8o49ZoHPzFMXqkNge69MBaagqhVWWcw0jONPr4q8xgCy4UA1pugtLygMipRKBmnuKeeb4s6E5d949Hwk1rBGNwklh0LUObgFJFumKfK0mF/sRgS7eL1yP7Rx5uVzDpHupnAn9fSX4QxczTyrMNExtvv5gHABv2YvxaPGBi7hc4vRecA7IG19u77XJHuMAsJRjdaOitH3Z3EiaC2A07Cv5D7q9qp8ahV+Q0G5TjUHmlh2qHtYvb3LBVwPrVkHZJr2wahVJWsPGDyFWPhf3oO9QmSiEqX8iFLeVL/KPp2CyrFdkWYxyRbSU08mfaheKQzKE05BX+KI8ZA5He0W/Vlt+d29996rM4dlFWpbv3OQ7+oUri+RW4bJLzE5JUsZd+q8Mn6X/LfXy3tBCKkYQEW0y2XTfO3bdpGMfilOtKO/wbE7OGZDA6Glppw2fOPHK8SH0AhQPa9Xci8Zk3ioDMb1VsWw94Wucw8HLGLYWRfg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(44832011)(82960400001)(38100700002)(2906002)(83380400001)(1076003)(186003)(66556008)(4326008)(6506007)(9686003)(508600001)(66476007)(6486002)(8676002)(5660300002)(8936002)(66946007)(86362001)(6916009)(316002)(6512007)(54906003)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kbTxyM8Qujz3SRH023YNKEh6g7nd2dFZvBdD+Lu9veDC2myRlaYibM7MeAKu?= =?us-ascii?Q?8IsW1Axh4RF6fQRbHeHUCM70CITnPGmoWOyRTjDnITPw/pABNbxXekhOwXuW?= =?us-ascii?Q?NlUSPIwq7qCUvgAbQ3wzFH0dPSpPym0BOP9311WYRIiMHNjm4Yuz9ve/emxa?= =?us-ascii?Q?rxrkSui5Cf/Ekj8jbJRW/xhY3dgTYIaRyXA3YQIWAGRo9L6iL+tOJQI8730+?= =?us-ascii?Q?4tnTzINilEzMTDYxHl5x3b5xr9mBcsv+iRh+y6Z+iuyFHGrCvRvpClOpnTqH?= =?us-ascii?Q?sI6WvDjkKwGSdmy32bw+LCyY9JIE7BzxJVzZFhSwPFQq8jHHWRT94h8bvNfr?= =?us-ascii?Q?qEPOU3ucpr5QPuuvwEwgb6awuGFHT6dGn1IJJzJD6xtcb07LEi1Vi9yRpl4f?= =?us-ascii?Q?IBKoarfi/PGLebh1vHKhRYejXKTcossKTeA5ZYBQqfeUB6pzbm+m0wQBhDZ6?= =?us-ascii?Q?YXWlLId47ggNbrZGlXBY7Uu6SaiizKkR66L5xE7G8HfLe5p3gcO+3eZC7hhg?= =?us-ascii?Q?A4FtpvO4A96W14mYkDt4/RYB237gSHkGsQi9So2361VNTH/YLcYgoxfDs39Z?= =?us-ascii?Q?1gxsvxaypHtovGDyzoFN/YsLqbwiFmQu8BBAmrxP1q8lc/nGPutw5hMdXIJM?= =?us-ascii?Q?xgyFyjqWMLt1oNdfLQrzF0WN/6XMALAQNksCLMpsToJnGJd1gf5EwdEQkzGu?= =?us-ascii?Q?1J4uPh4EMVCZXNgLiCfkdFE+UzKnOW+0kdRL4uTrAGVn3V70gEnI7XUr6DEC?= =?us-ascii?Q?OtUJ+7f6F6fl8C5/Lp1rjy4mk4HglHmkWscYPI33zfr9oE08RDWSb9LMZpug?= =?us-ascii?Q?5hygiXCW0Saym7ytlmp12D1A5Mjus9uZ5A59aZL3oMajyrPE70H6qhOdre9i?= =?us-ascii?Q?7euiGZk3j/1Woj+MEU2H57kI4kwUYFRV15Kv31qIbZwjbaowWlOWqFflhH4T?= =?us-ascii?Q?KGeNFd0V/CX46vgWFUsFMLGbNwn9cGpX1bCdeKb/gq3GdhtdrWaJ+FGz8HTM?= =?us-ascii?Q?fGkUHV5XybzRN6gb2dPRE6lHHELP+XbZHfyjd4kYmqvSZ93/yv9RKModsRnz?= =?us-ascii?Q?4tVsSNgojh++HKut2tIOI+MRpFzdRSunI/b4e3dJQTyaHq3LVjOgzz6rBgaD?= =?us-ascii?Q?HBz3kCC92A5XpB8kfo4h0B9ElpxSUKWNSruUV5fWaGnIy5xnjKPof10RPX2S?= =?us-ascii?Q?qaSgkmtFbh1VwCY3/+PERQWhKTErJjxTsyM9dRIfBGvCm2JHw0938qch9ehm?= =?us-ascii?Q?6RLT/+Y479DFsac4/+Oe/j3zVeNxxwuInv8ukGPX2mWuH0vD7+/wpfVruk25?= =?us-ascii?Q?O/BZc2fio8D+FexGOAioOZsmsBZ5ZpxhlGzz2Q5qSwgQYf0XZhUpKl+j4fgP?= =?us-ascii?Q?DWObIQ4Vm5arKcC8loOl9BaxsrjMMHgWB+0d5ZnZ+UUTbAPM0jXwt0soJy1i?= =?us-ascii?Q?y0D36qJMmtTBMrZrz1iVF4Nnwfe/4LjEGiTIey8PW+dKJCKBqL9bUqo5fxLN?= =?us-ascii?Q?xkOzNF/sM3vXbc1DvXiOkAwE57WmoLDmPpNxIIDYb2/fQgbBkg8RuHOYB9wj?= =?us-ascii?Q?oXJzU938jjYY9TPwPjHtG3w8T3ey9ZHqfzxoZMnCaENO6cWzgjkedEKpw/Sx?= =?us-ascii?Q?y7K0XDVDFtSNQpQ/zk5tNU936gxlOStN78htQAJ7x15qb9PXtjDShE7ZR32U?= =?us-ascii?Q?Pz0IMOrcUHjEOtYCnzFokgWPkqI+/HReshBSHHBKu5GI5OW0H6NRg1gIQLou?= =?us-ascii?Q?iLXuLh0c/IlhxPDiYamUBD/i16QTK+U=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f568451-14ba-4d94-b0d0-08d9e23e421a X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 09:12:07.6561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pjdnItOddX+27X3/eiYO63LFw1Krgl2bz0EYowVwgCpgceHO1O4R5Az/drZkrxAs0euJRtONwlsc/mDCy/UUUgLblgy0ZZRG4iPHWJYiQzA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3144 X-TUID: h/j/7SDUXZLH Am Fri, 28 Jan 2022 10:00:10 +0100 schrieb Henning Schild : > With do_rootfs_install being the new sstate task we need to be more > precise on what needs to happen before do_rootfs_postprocess. > > Some postprocess functions need files downloaded so we add "after > unpack" > - sdkchroot_install_files > - buildchroot_install_files > And do_rootfs_postprocess needs the apt caches for rootfs_do_mounts. > > Signed-off-by: Henning Schild > --- > meta/classes/rootfs.bbclass | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 78fb2cc71350..9f0d345dae03 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -262,7 +262,7 @@ python do_rootfs_postprocess() { > bb.build.exec_func(cmd, d) > progress_reporter.update(int(i / len(cmds) * 100)) > } > -addtask rootfs_postprocess before do_rootfs > +addtask rootfs_postprocess before do_rootfs after do_unpack > > python do_rootfs() { > """Virtual task""" > @@ -270,9 +270,10 @@ python do_rootfs() { > } > addtask rootfs before do_build > > +do_rootfs_postprocess[depends] = "base-apt:do_cache > isar-apt:do_cache_config" + i do understand why this needs to be here, and it is in the commit message. > SSTATETASKS += "do_rootfs_install" > ROOTFS_SSTATE = "${WORKDIR}/rootfs-sstate" > -do_rootfs_install[depends] += " base-apt:do_cache > isar-apt:do_cache_config" do_rootfs_install[dirs] += However i do not fully understand why it seems ok to drop this again. All test i did so far look promising. And i rather not have deps overspecified, that is why i drop it here. Henning > "${ROOTFS_SSTATE} ${WORKDIR}/mnt/rootfs" do_rootfs_install[cleandirs] > += "${ROOTFS_SSTATE}" do_rootfs_install[sstate-plaindirs] = > "${ROOTFS_SSTATE}"