Re: [PATCH v3 4/6] raspios: resize rootfs on first boot

[Henning Schild <henning.schild@siemens.com>]

Am Sat, 29 Jan 2022 08:57:22 +0300
schrieb Uladzimir Bely <ubely@ilbers.de>:

> In the email from суббота, 29 января 2022 г. 00:13:43 +03 user
> Henning Schild wrote:
> > Hi,
> > 
> > why did you not use or extend recipes-support/expand-on-first-boot ?
> > 
> > Henning
> >   
> Hello.
> 
> I tried to follow the approach raspios uses. First boot expansion is
> done this way in official distribution, so I just ported this part.

In fact the recipe is heavily inspired by raspi, IIRC.

> But you are right, while we have our own implementation (I just
> forgot about it), it is worth using it.
> 
> I've just tried to revert this commit and enable
> `expand-on-first-boot` recipe in local.conf - and it seems to be
> working. After first boot `df` shows that 2nd partition is expanded
> ant all free space is available.
> 
> Also, 'raspi-config' utility (that allows to expand partition
> manually) remains working. So, even if user doesn't enable this
> recipe, they still can do it via this utility.
> 
> So, it seems, we can remove this commit in favour of the existing
> recipe and it doesn't bring any problems.

I guess that would be the way to go. Unless we can find the original in
any real package. But smuggling things in not using a package is not
the best style ... might also be the style that raspi uses to build
their images.

> By the way, `expand-on-first-boot` recipe looks like something that
> is not tested at all. None of machine uses it by default, and it's
> not included to local.conf. Probably, that's why I didn't recall it
> while porting RPi.

It is tested/used in many layers, some i know even extend it for other
filesystems. But yes it should be tested in isar, given it has been
upstreamed into isar by someone.

> Why not enable it at least for RPi targets?

Sounds like a very good idea. Maybe even with a testcase to check "df"
and that "raspi-config" remains working.

regards,
Henning

> > Am Wed, 19 Jan 2022 07:59:00 +0100
> > 
> > schrieb Uladzimir Bely <ubely@ilbers.de>:  
> > > Initially, after rpi-sdimg is created, a quite small rootfs
> > > partition is created. After boot, there is almost no free space.
> > > 
> > > This patch uses scripts (idea is taken from official raspbian
> > > distro) that make rootfs partition expanded at first boot.
> > > 
> > > Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> > > ---
> > > 
> > >  meta-isar/conf/distro/raspios-configscript.sh | 23
> > > 
> > > ++++++++++++++++++- 1 file changed, 22 insertions(+), 1
> > > deletion(-)
> > > 
> > > diff --git a/meta-isar/conf/distro/raspios-configscript.sh
> > > b/meta-isar/conf/distro/raspios-configscript.sh index
> > > 6120a379..9a7c43e6 100644 ---
> > > a/meta-isar/conf/distro/raspios-configscript.sh +++
> > > b/meta-isar/conf/distro/raspios-configscript.sh @@ -19,7 +19,7 @@
> > > EOF
> > > 
> > >  cat > /boot/cmdline.txt << EOF
> > >  console=${MACHINE_SERIAL},${BAUDRATE_TTY} console=tty1 \
> > >  root=/dev/mmcblk0p2 rootfstype=ext4 fsck.repair=yes \
> > > 
> > > -rootwait quiet
> > > +rootwait quiet init=/usr/lib/raspi-config/init_resize.sh
> > > 
> > >  EOF
> > >  
> > >  cat > /etc/fstab << EOF
> > > 
> > > @@ -27,3 +27,24 @@ proc            /proc           proc
> > > defaults
> > > 
> > >        0       0 /dev/mmcblk0p1  /boot           vfat    defaults
> > >      
> > >      0       2 /dev/mmcblk0p2  /               ext4
> > > 
> > > defaults,noatime  0       1 EOF
> > > +
> > > +cat > /etc/init.d/resize2fs_once << EOF
> > > +#!/bin/sh
> > > +. /lib/lsb/init-functions
> > > +case "\$1" in
> > > +  start)
> > > +    log_daemon_msg "Starting resize2fs_once"
> > > +    ROOT_DEV=\$(findmnt / -o source -n) &&
> > > +    resize2fs \$ROOT_DEV &&
> > > +    update-rc.d resize2fs_once remove &&
> > > +    rm /etc/init.d/resize2fs_once &&
> > > +    log_end_msg \$?
> > > +    ;;
> > > +  *)
> > > +    echo "Usage: \$0 start" >&2
> > > +    exit 3
> > > +    ;;
> > > +esac
> > > +EOF
> > > +chmod +x /etc/init.d/resize2fs_once
> > > +ln -s ../init.d/resize2fs_once /etc/rc3.d/S01resize2fs_once  
> 
> 
> 
>