* [PATCH 1/1] fix typo in variable name to disable cross-compilation of riscv64 package
@ 2022-02-02 9:20 Felix Moessbauer
2022-02-02 9:45 ` Jan Kiszka
2022-02-16 7:51 ` Anton Mikanovich
0 siblings, 2 replies; 5+ messages in thread
From: Felix Moessbauer @ 2022-02-02 9:20 UTC (permalink / raw)
To: isar-users; +Cc: quirin.gylstorff, jan.kiszka, Felix Moessbauer
The variable ISAR_CROSS_BUILD does not exist, but instead is named
ISAR_CROSS_COMPILE.
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
.../crossbuild-essential-riscv64_0.2-isar.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essential-riscv64_0.2-isar.bb b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essential-riscv64_0.2-isar.bb
index be06688f..c7ef390f 100644
--- a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essential-riscv64_0.2-isar.bb
+++ b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essential-riscv64_0.2-isar.bb
@@ -8,7 +8,7 @@ inherit dpkg-raw
DPKG_ARCH = "all"
-ISAR_CROSS_BUILD = "0"
+ISAR_CROSS_COMPILE = "0"
DEBIAN_DEPENDS = " \
gcc-riscv64-linux-gnu, \
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] fix typo in variable name to disable cross-compilation of riscv64 package
2022-02-02 9:20 [PATCH 1/1] fix typo in variable name to disable cross-compilation of riscv64 package Felix Moessbauer
@ 2022-02-02 9:45 ` Jan Kiszka
2022-02-02 10:36 ` Moessbauer, Felix
2022-02-16 7:51 ` Anton Mikanovich
1 sibling, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2022-02-02 9:45 UTC (permalink / raw)
To: Felix Moessbauer, isar-users; +Cc: quirin.gylstorff
On 02.02.22 10:20, Felix Moessbauer wrote:
> The variable ISAR_CROSS_BUILD does not exist, but instead is named
> ISAR_CROSS_COMPILE.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> .../crossbuild-essential-riscv64_0.2-isar.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essential-riscv64_0.2-isar.bb b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essential-riscv64_0.2-isar.bb
> index be06688f..c7ef390f 100644
> --- a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essential-riscv64_0.2-isar.bb
> +++ b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essential-riscv64_0.2-isar.bb
> @@ -8,7 +8,7 @@ inherit dpkg-raw
>
> DPKG_ARCH = "all"
>
> -ISAR_CROSS_BUILD = "0"
> +ISAR_CROSS_COMPILE = "0"
>
> DEBIAN_DEPENDS = " \
> gcc-riscv64-linux-gnu, \
Hmm, interesting, how did this work so far? crossbuild-essential-riscv64
is a stub package needed to create the cross-build environment, thus
can't be built in it. Seems that was magically resolved, or did you
actually notice a negative effect?
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/1] fix typo in variable name to disable cross-compilation of riscv64 package
2022-02-02 9:45 ` Jan Kiszka
@ 2022-02-02 10:36 ` Moessbauer, Felix
2022-02-02 11:12 ` Jan Kiszka
0 siblings, 1 reply; 5+ messages in thread
From: Moessbauer, Felix @ 2022-02-02 10:36 UTC (permalink / raw)
To: jan.kiszka, isar-users; +Cc: quirin.gylstorff
> -----Original Message-----
> From: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>
> Sent: Wednesday, February 2, 2022 10:45 AM
> To: Moessbauer, Felix (T CED SES-DE) <felix.moessbauer@siemens.com>; isar-
> users@googlegroups.com
> Cc: Gylstorff, Quirin (T CED SES-DE) <quirin.gylstorff@siemens.com>
> Subject: Re: [PATCH 1/1] fix typo in variable name to disable cross-compilation
> of riscv64 package
>
> On 02.02.22 10:20, Felix Moessbauer wrote:
> > The variable ISAR_CROSS_BUILD does not exist, but instead is named
> > ISAR_CROSS_COMPILE.
> >
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> > .../crossbuild-essential-riscv64_0.2-isar.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essent
> > ial-riscv64_0.2-isar.bb
> > b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essent
> > ial-riscv64_0.2-isar.bb
> > index be06688f..c7ef390f 100644
> > ---
> > a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essent
> > ial-riscv64_0.2-isar.bb
> > +++ b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-es
> > +++ sential-riscv64_0.2-isar.bb
> > @@ -8,7 +8,7 @@ inherit dpkg-raw
> >
> > DPKG_ARCH = "all"
> >
> > -ISAR_CROSS_BUILD = "0"
> > +ISAR_CROSS_COMPILE = "0"
> >
> > DEBIAN_DEPENDS = " \
> > gcc-riscv64-linux-gnu, \
>
> Hmm, interesting, how did this work so far? crossbuild-essential-riscv64 is a stub
> package needed to create the cross-build environment, thus can't be built in it.
> Seems that was magically resolved, or did you actually notice a negative effect?
Probably the ISAR_CROSS_COMPILE was always set to 0 when building this package. Don't know. Just stumbled upon this while searching for locations of ISAR_CROSS_COMPILE.
Looks like this is either not tested in CI, or magically works...
Felix
>
> Jan
>
> --
> Siemens AG, Technology
> Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] fix typo in variable name to disable cross-compilation of riscv64 package
2022-02-02 10:36 ` Moessbauer, Felix
@ 2022-02-02 11:12 ` Jan Kiszka
0 siblings, 0 replies; 5+ messages in thread
From: Jan Kiszka @ 2022-02-02 11:12 UTC (permalink / raw)
To: Moessbauer, Felix (T CED SES-DE), isar-users
Cc: Gylstorff, Quirin (T CED SES-DE)
On 02.02.22 11:36, Moessbauer, Felix (T CED SES-DE) wrote:
>
>
>> -----Original Message-----
>> From: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>
>> Sent: Wednesday, February 2, 2022 10:45 AM
>> To: Moessbauer, Felix (T CED SES-DE) <felix.moessbauer@siemens.com>; isar-
>> users@googlegroups.com
>> Cc: Gylstorff, Quirin (T CED SES-DE) <quirin.gylstorff@siemens.com>
>> Subject: Re: [PATCH 1/1] fix typo in variable name to disable cross-compilation
>> of riscv64 package
>>
>> On 02.02.22 10:20, Felix Moessbauer wrote:
>>> The variable ISAR_CROSS_BUILD does not exist, but instead is named
>>> ISAR_CROSS_COMPILE.
>>>
>>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
>>> ---
>>> .../crossbuild-essential-riscv64_0.2-isar.bb | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essent
>>> ial-riscv64_0.2-isar.bb
>>> b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essent
>>> ial-riscv64_0.2-isar.bb
>>> index be06688f..c7ef390f 100644
>>> ---
>>> a/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-essent
>>> ial-riscv64_0.2-isar.bb
>>> +++ b/meta/recipes-devtools/crossbuild-essential-riscv64/crossbuild-es
>>> +++ sential-riscv64_0.2-isar.bb
>>> @@ -8,7 +8,7 @@ inherit dpkg-raw
>>>
>>> DPKG_ARCH = "all"
>>>
>>> -ISAR_CROSS_BUILD = "0"
>>> +ISAR_CROSS_COMPILE = "0"
>>>
>>> DEBIAN_DEPENDS = " \
>>> gcc-riscv64-linux-gnu, \
>>
>> Hmm, interesting, how did this work so far? crossbuild-essential-riscv64 is a stub
>> package needed to create the cross-build environment, thus can't be built in it.
>> Seems that was magically resolved, or did you actually notice a negative effect?
>
> Probably the ISAR_CROSS_COMPILE was always set to 0 when building this package. Don't know. Just stumbled upon this while searching for locations of ISAR_CROSS_COMPILE.
> Looks like this is either not tested in CI, or magically works...
The latter, already because of https://github.com/siemens/isar-riscv.
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] fix typo in variable name to disable cross-compilation of riscv64 package
2022-02-02 9:20 [PATCH 1/1] fix typo in variable name to disable cross-compilation of riscv64 package Felix Moessbauer
2022-02-02 9:45 ` Jan Kiszka
@ 2022-02-16 7:51 ` Anton Mikanovich
1 sibling, 0 replies; 5+ messages in thread
From: Anton Mikanovich @ 2022-02-16 7:51 UTC (permalink / raw)
To: Felix Moessbauer, isar-users; +Cc: quirin.gylstorff, jan.kiszka
02.02.2022 12:20, Felix Moessbauer wrote:
> The variable ISAR_CROSS_BUILD does not exist, but instead is named
> ISAR_CROSS_COMPILE.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Applied to next, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-16 7:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-02 9:20 [PATCH 1/1] fix typo in variable name to disable cross-compilation of riscv64 package Felix Moessbauer
2022-02-02 9:45 ` Jan Kiszka
2022-02-02 10:36 ` Moessbauer, Felix
2022-02-02 11:12 ` Jan Kiszka
2022-02-16 7:51 ` Anton Mikanovich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox