public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
To: <isar-users@googlegroups.com>, <jan.kiszka@siemens.com>,
	<henning.schild@siemens.com>
Cc: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
Subject: [RFC PATCH] image: Reorder do_copy_boot_files task
Date: Fri, 18 Feb 2022 15:24:28 +0530	[thread overview]
Message-ID: <20220218095428.1767282-1-Vijaikumar_Kanagarajan@mentor.com> (raw)

There might be cases where in there are some initramfs changes in postprocess.
For example, via the distro config script.

In such a scenario we would have an outdated initramfs file in deploy directory.
Certain downstream Wic plugins directly consume the image from deploy directory.
It then uses the outdated initramfs for creating the wic image.

Copy boot files after rootfs postprocess but before finalizing the
rootfs.

Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
 RECIPE-API-CHANGELOG.md    | 7 ++++++-
 meta/classes/image.bbclass | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
index cad15a8..ef53b1a 100644
--- a/RECIPE-API-CHANGELOG.md
+++ b/RECIPE-API-CHANGELOG.md
@@ -342,4 +342,9 @@ The bitbake variable defines the respective environment variable which is availa
 When cross compiling, `cross` is added to the `DEB_BUILD_PROFILES` environment variable.
 Please note, that manually exported versions of the variables are overwritten.
 
-For a list of well-known Debian build profiles and common practices, we refer to Debian's BuildProfileSpec.
\ No newline at end of file
+For a list of well-known Debian build profiles and common practices, we refer to Debian's BuildProfileSpec.
+
+### Move do_copy_boot_files task after do_rootfs_postprocess
+
+The boot-files(kernel, initrd, dtbs) are now shipped to tmp/deploy/images after
+do_rootfs_postprocess task and before do_rootfs_finalize task.
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 6d77243..d70a93b 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -170,7 +170,7 @@ do_copy_boot_files() {
         cp -f "$dtb" "${DEPLOY_DIR_IMAGE}/"
     done
 }
-addtask copy_boot_files before do_rootfs_postprocess after do_rootfs_install
+addtask copy_boot_files before do_rootfs_finalize after do_rootfs_postprocess
 
 python do_image_tools() {
     """Virtual task"""
-- 
2.25.1


             reply	other threads:[~2022-02-18  9:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  9:54 Vijai Kumar K [this message]
2022-02-25  7:06 ` vijai kumar
2022-02-25  8:31 ` Henning Schild
2022-02-25 10:39   ` vijai kumar
2022-02-25 15:49     ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218095428.1767282-1-Vijaikumar_Kanagarajan@mentor.com \
    --to=vijaikumar_kanagarajan@mentor.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox