public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Uladzimir Bely <ubely@ilbers.de>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH] linux-custom: Set KERNEL_CONFIG_TARGET at build time
Date: Thu, 24 Feb 2022 19:14:50 +0100	[thread overview]
Message-ID: <20220224191450.0188228a@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20220224144325.12672-1-ubely@ilbers.de>

Layer CI likes that, merge ASAP.

Thanks!

Henning

Am Thu, 24 Feb 2022 15:43:25 +0100
schrieb Uladzimir Bely <ubely@ilbers.de>:

> Expanding KERNEL_CONFIG_TARGET variable at parse time doesn't properly
> work while it may need some config file in workdir that is not created
> at this moment.
> 
> This patch removes the variable from template vars and sets in in
> debian/isar/configure at build time
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  meta/recipes-kernel/linux/linux-custom.inc | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc
> b/meta/recipes-kernel/linux/linux-custom.inc index ea1abf76..8a5dbf82
> 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -72,7 +72,6 @@ TEMPLATE_VARS += "                \
>      KERNEL_HEADERS_DEBIAN_DEPENDS \
>      LINUX_VERSION_EXTENSION       \
>      KERNEL_NAME_PROVIDED          \
> -    KERNEL_CONFIG_TARGET          \
>      KERNEL_CONFIG_FRAGMENTS       \
>  "
>  
> @@ -165,8 +164,6 @@ def get_kernel_config_target(d):
>  
>      return config_target
>  
> -KERNEL_CONFIG_TARGET = "${@get_kernel_config_target(d)}"
> -
>  def get_kernel_config_fragments(d):
>      src_frags = " ".join(config_fragments(d))
>      out_frags = " ".join(map(lambda frag: 'debian/fragments/' +
> frag, config_fragments(d))) @@ -180,6 +177,11 @@ def
> get_kernel_config_fragments(d): KERNEL_CONFIG_FRAGMENTS =
> "${@get_kernel_config_fragments(d)}" 
>  dpkg_configure_kernel() {
> +	grep -q "KERNEL_CONFIG_TARGET=" ${S}/debian/isar/configure ||
> +		cat << EOF | sed -i '/^do_configure() {/ r
> /dev/stdin' ${S}/debian/isar/configure
> +    KERNEL_CONFIG_TARGET="${@get_kernel_config_target(d)}"
> +EOF
> +
>  	rm -rf ${S}/${KERNEL_BUILD_DIR} && mkdir -p
> ${S}/${KERNEL_BUILD_DIR} if [ -n "${KERNEL_DEFCONFIG}" ]; then
>  		if [ -e "${WORKDIR}/${KERNEL_DEFCONFIG}" ]; then


  reply	other threads:[~2022-02-24 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 14:43 Uladzimir Bely
2022-02-24 18:14 ` Henning Schild [this message]
2022-03-03 10:30 ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220224191450.0188228a@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox