From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7065986084596875264 X-Received: by 2002:a2e:9206:0:b0:244:c5e5:977c with SMTP id k6-20020a2e9206000000b00244c5e5977cmr4383078ljg.339.1645777905579; Fri, 25 Feb 2022 00:31:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3b8e:b0:443:9610:6a0c with SMTP id g14-20020a0565123b8e00b0044396106a0cls1911112lfv.1.gmail; Fri, 25 Feb 2022 00:31:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwLFaTE/fM9FIwWntUH2liBLewaclBroLg5McqM2YumhdcMIqIPDUL/N0G0wCiXlD1WnEwS X-Received: by 2002:a05:6512:3335:b0:444:869:882e with SMTP id l21-20020a056512333500b004440869882emr4135749lfe.41.1645777904539; Fri, 25 Feb 2022 00:31:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1645777904; cv=pass; d=google.com; s=arc-20160816; b=O2ef2rQjEKop/nkVj5dECAh6rstdyVEjkQok219mlyasZGm+lKl2CW5bAIar6KmoO8 HcEnfxAyMD/akbNLys4zopmPgD1tTl1z1c/8etgHvHfq0yngL7ot/SYy5+dcNfm3Db1W 6eLgXKxFguAbqZRmKX3hnu+GSEKU0TT6pmkbx/4tZDIK97hMmOrCX+wUsiVkIXlLLRCo sqxR3hZw20gf+p4hETIuh9Z+GrlpYXiWCssAePAFEQFgymjOGg1ffdUdj815Qz3KSQiG ZFoyl2/ENitDiAN9XXJpM5w5JWgZk+rIht+eh2kJTMrGHK3BfG3DYYq+hV1SyIMnps5i GO5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=txe1uCKBkeQYt6fge1Kpq8JdozHFzGa/G7AWS8CPlQM=; b=FW9m9OIumi7jZrGJrl8cl5IVwqsGTUO3NY+hP7DvFu8YTCds6bNmGBsJV6uEG6E9Ai uf+GAUimELdLAeTcBBx+AHmHsfnIeYvK5cECDUgyJKUhe3GI2G9sctq4e4fXnL7CxIIY nUwz/IcsvNgZBL6XSsanN8pfAdd8vNVzX99i4Mxml+l6Ab0ornB+kL6edMHqK9WqngAS pA984F4SU87lh1RNQEaAtLtLRMZBaj372y+cSUkySoZzLe/vgZqZv3YV584h7bhsdOkd fNvp5609mkZ7VLcuxjhya38F90gK4mh9O1eBvnDVDpgP1O/WImujoCaI+MctekjsyeR3 0GFw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=miTgxTV7; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe09::605 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on0605.outbound.protection.outlook.com. [2a01:111:f400:fe09::605]) by gmr-mx.google.com with ESMTPS id m15-20020a2e910f000000b00246477237ccsi113406ljg.8.2022.02.25.00.31.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Feb 2022 00:31:44 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe09::605 as permitted sender) client-ip=2a01:111:f400:fe09::605; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=miTgxTV7; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe09::605 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0+EGHTvCc/4mRzRHrJicf0LuknnPUvohdSI3w2QuJVxgMl/+niyhNOVPM+QznPrJy7FfEa/RoTiss5hoXl/IWMYC8mIFxFO6G8QWuvV8/c/fCbOyKQX3x82JpkYzQgTQkBOGONc6GMGGKSj155O+jT5uvzVuX8qFNY28YhYwTii0TcBXbUl2eCsLBgDuFlB8pUxoYA9MlTT7U7rjqtJ71vgqatBv1bz7GKBymt7RgXd9xc1Hy9ZgFKMVzELj19elA4NVoSX9znkf7bh76Ez4q7SQYbnNf/tDDkX8FlNfMR9YNVAapDKtS8wzzmurBT37ys4NAKhQzOqlKyW0mQGjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=txe1uCKBkeQYt6fge1Kpq8JdozHFzGa/G7AWS8CPlQM=; b=nuJMevdfZSal8FbeJOse1KwIezkLIR830UzBdpdC0nzlD4rOL0HcCVpoJRwmJbuGquTi1dXWJQWd125ikCrav1lYWgazjXMDXGSZAOPalTJKeoeR+4Y9kSezNr4yVuafLWehRMMdQ9rr/RiRt4BerHeK0mtLvMOEH+E5nZ1NHMjym654qjCMLyfzlUYCXFHEosKxCcNxvtb76vxkIFtZk6BSvE8k0h31DqTROyNRv3enGbWtgU1/fK2dft/NOoVihNorFM7bk33VMTk/f9QmhMl7EYle68TctfQOZqM3hj8vYmgeZt0pCSYmiW8SzcR9n3wBZGvyruaErGF0jjskkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=txe1uCKBkeQYt6fge1Kpq8JdozHFzGa/G7AWS8CPlQM=; b=miTgxTV7BB2+VEBdwOM7DmLumUsTezfwN+irPnXjeNIVQn6Z0Lw6PsBcgkuTlQpBCLUo03a+hS1jY3OfQHDhosW0dOFAE4hRUQKkYuVaev0Db/pONy3MNAxQcBJS2k/zRepQuMw0RtMhhVyHsueW6el8xMOOuRIu90YElVv1MCtf7J7tEt2LPNGq2ZoE7aTr6H+4sqVVTpG6lQsDfrmMqAfpr6LUFPd2eceExXhMFW8QgX82zmXMMPXxMdeKTluGVlJv1eTDkCUnFPLBGqS6Qm9SnbL/e/qG0ZiMBqH6JEgDJFtHLswNU3tyGWC0oXDK+MbsBPB+WYyZBJJcTwH0xQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:13d::17) by AM0PR10MB2530.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:dd::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 08:31:41 +0000 Received: from AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM ([fe80::a116:222:eb1b:efdf]) by AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM ([fe80::a116:222:eb1b:efdf%4]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022 08:31:41 +0000 Date: Fri, 25 Feb 2022 09:31:37 +0100 From: Henning Schild To: Vijai Kumar K Cc: , Subject: Re: [RFC PATCH] image: Reorder do_copy_boot_files task Message-ID: <20220225093137.54487e31@md1za8fc.ad001.siemens.net> In-Reply-To: <20220218095428.1767282-1-Vijaikumar_Kanagarajan@mentor.com> References: <20220218095428.1767282-1-Vijaikumar_Kanagarajan@mentor.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR03CA0047.eurprd03.prod.outlook.com (2603:10a6:208::24) To AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:13d::17) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9339da49-24a2-455f-1a4a-08d9f8393f5e X-MS-TrafficTypeDiagnostic: AM0PR10MB2530:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FDPMn+19y0djE8VvEzyZCO3ejN9GpMRL0tbzBglPKEoFkOMexYdlx13dpnkvzZYa3mg5AIznRAln+X+iiXxOejeIlSRlTJgC/FNLLffjx3K3piFuAK0b0DaP+ippIH1KbRa0VwcLRaS7wp5+YVj4EAMMpFFIZKGYmKPGVFR8c261aoeLE/zdYWaz1wpWxuHXHk/+wmtzE5UWYqqnG4pyEBxKd7Mam6x5dsxw0C21LtM8Gz2j98eBhKx4ZrveZCtoQvAj3TOVhnXt3U9kfA5wemoFUpjSl7cFvV4AVqBwNbErH8gtxQvN/0ookvQKEeaiaYHpNQg347UTZQa6bqC3Z7cmcEz8nVophRPuju1d3mEjvgFGI1EPTeHcO2KVH/l/ntaIw8pnLpzOMSdelIMKNx9MRspkWlhOwlaXx60Y3CuWuUpjWKCnBRcK/q/IUKOtZ/NtubEegNEtouO/MKOHfV50bX2ijka1amb3V9HLgdx5VvpiYLIyxASQ4D7SGM3EQ6LFH1PQa69+qH2hyJUXxV7EH4VHnZn8O9DNnJfH66IVK+iRoYg1CqE/w1OV4scg3Am2P4+ifh/09grVahObwQl02IYSlb0qCRnYjfbJKjqffitvwbgge5ySisIBemFhg8vzfJ1Eq3OZEFW2sB0dkQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(9686003)(2906002)(1076003)(38100700002)(107886003)(82960400001)(83380400001)(186003)(6512007)(8936002)(316002)(66946007)(66556008)(6506007)(4326008)(66476007)(8676002)(86362001)(6666004)(54906003)(6916009)(5660300002)(508600001)(44832011)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+ov88Pf/uZCWJjTCEbIDj1T04lWsWtqH1tZtdUxOKAExgHmxYqc8+lK25q0G?= =?us-ascii?Q?m99K6LMBjYnpEDXFo6D+/wWox7cGmZItJoZkb9PC/uw5EVEvJM2qvTiTNVU8?= =?us-ascii?Q?JBUUi7NSbMEhGzHyTsXu/ezXjpGTQEqOEOPOXMyvt9xRU+uX4Ajbb+6C/+iD?= =?us-ascii?Q?642sY3dfry95awi+lFXtwTB24wmHT1cKSNgl1MHkAGgfcAHNON4JiBDMBtvU?= =?us-ascii?Q?KIJ3ihA98N31+C+RAAUpuXOm/aCpY9ZB8byyJP5zUhyAQX4JN3eM9tmUNOZP?= =?us-ascii?Q?wPNCPgTHzQn2lkdk6Ws1WhoPh3Wmk+kN7hg8QLIEKy0qxUJA4XORCmobTMzm?= =?us-ascii?Q?jvzh+sbBqeg8BPOd7UZlTZNsuUgQv1ZH5Ykqlsbymho05eBbQDhaN5VjGhD8?= =?us-ascii?Q?wRTihRlRbx9B7rwRCq8nHGNdp9jt2lrjhBgC7qIWAKRXBJ62CAXXo+qtnI2/?= =?us-ascii?Q?oI/F6L5ixeT/0gCCUMh49PfHf2g05ENqb06LPDnuQ1fgtC8DI16klXaTSRD5?= =?us-ascii?Q?u71wvPInMpNO96d1Td+fA/IX5pqzUH65jav8NZuJNjQ89+LYidWLqRjDtSyY?= =?us-ascii?Q?2rIMK05Yl4nlTHOdP3W1QUqczBc7qKLvrdcY0HCd1PuzuHtzMqU2RdrOz+P1?= =?us-ascii?Q?zrcWGFUvSaI2TU4aPMIRpWKtSYxmKrZyGFmGmUcnbLTP16rg8SrM5QBI5XVC?= =?us-ascii?Q?p5IhNvDmA5KxTVAft4+gt0X50823lRtW8BMXzoDHGVRSZMdgOYqwlapP6IJM?= =?us-ascii?Q?GFmDpU6an8K5UY51EDD86E56BuVDAfRtOnGk4xNpB7blOml4BCLnkmr+Fo1X?= =?us-ascii?Q?PfsirVvpn0x5MWpFRHc1X1Vj01R8nRNL3IzNmiUFHQgJJb9fbm3NazCBcGiC?= =?us-ascii?Q?LhTdjVWHFdoZP1sfopqmVgYZ7oYsei+d76bIj2XcAKfU9CzxQ6Yoq1rBZwy+?= =?us-ascii?Q?bC7bh5eoix+SRikAS62VMYe4f6joDpMQM86Oj9YBbtrGfxJ0zulpGt1sDtvV?= =?us-ascii?Q?NIbY6FozawHyRRQxbRWFCbZICzfh7RhTRIsGmU5Z9OPjbSEETs6K2ORZWHu4?= =?us-ascii?Q?WEQQl1CVSC5Rsyxy4WbKHwzirDfdKNuI+LoC5s6Lqp9dKp6l+KXIJFGlCl8y?= =?us-ascii?Q?UbPQe15qOk4h5HcO3b/z8yGgEgYW6cbjDt3LLG6EjaJHQIqTptn2UNXMj7KC?= =?us-ascii?Q?BnS8VMNgvuiyraM8mpgWLJ+Ef0kwzxRBKp6jWcDi6lbop3SV8+dkja0xB9pJ?= =?us-ascii?Q?wpayYPb6PovNSahGagUzLqVCKAUsabLHNcvYtWhAt3AWS5gkrlhUtztwCSrd?= =?us-ascii?Q?xxcjiH01ECPmhMpD+jjDKxHvujHy+71Id3YuQ3gqdWfFHIHljKtcKP9T+fsd?= =?us-ascii?Q?sMW2PMQ1SaLyaO6k8R5kpdnaWbofSh07pY/XrJ9whLDml0A+Lcn05FHw9yBZ?= =?us-ascii?Q?sJTI212aDXsQuGRT6Y2SbYG/gm+1fzy1BYrn7QeOyxKAa4eIpixet+fPuf1W?= =?us-ascii?Q?5Uk/ZgLCBUyXegOjYur4Lfla5AB/D5dmcHRH67w9nweHh7TuJUwACp6G6fkj?= =?us-ascii?Q?Fb/YuuITZFazohRdg8ghfOSIkJ4Z12dacjf/s9QgIi9VaZeyI/fyyDfBJeDA?= =?us-ascii?Q?+1uRiaSHcAJAHLJi1TxP3LQTu4ionw3FwJPK+JxlIUOrht2oswRehFJ/Ziix?= =?us-ascii?Q?uAwiXurLVB+rkCHnYAqLut/niRpoRNJxqwf//CZNqcBPfXiclLfcyGijFpiN?= =?us-ascii?Q?hK0VT69PCA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9339da49-24a2-455f-1a4a-08d9f8393f5e X-MS-Exchange-CrossTenant-AuthSource: AM7PR10MB3462.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:31:41.1154 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jb7BMgq5DJtlC346s/fhHzI4MvIP4V//c7t96hTUtcNpB7qxepc1ifInPYikfMrzMcp+FS74aKWuCVF9wayny3eEY0KyCe1p5AR+CRUikjY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2530 X-TUID: 56TK2g52L2Ib Am Fri, 18 Feb 2022 15:24:28 +0530 schrieb Vijai Kumar K : > There might be cases where in there are some initramfs changes in > postprocess. For example, via the distro config script. Postprocessing is a hack reserved for very few special cases, most of which should read and not write. That smells like you are abusing postprocess, and whatever you do there might also break kernel updates with "apt-get". Please give us the example, i bet it can be moved out of postprocess into a much more sustainable place (like a package). With no good example, NACK from me. > In such a scenario we would have an outdated initramfs file in deploy > directory. Certain downstream Wic plugins directly consume the image > from deploy directory. It then uses the outdated initramfs for > creating the wic image. Maybe those downstream wic plugins deserve fixing as well, take the initrd and kernel out of root/boot. For image type wic there should in fact be no reason to copy the boot files to deploy. That is something for ext4 and others going to "qemu --kernel ..." While those files are there for any image i would not suggest using them. We have lava setups where we convert a wic into kernel+initrd+nfsrootfs+cmdline, all taken only out of that wic. No side channels. I guess one could also look into ".wic.img.p1" but the boot files have no place as output for wic images, let alone as input for wic. regards, Henning > Copy boot files after rootfs postprocess but before finalizing the > rootfs. > > Signed-off-by: Vijai Kumar K > --- > RECIPE-API-CHANGELOG.md | 7 ++++++- > meta/classes/image.bbclass | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index cad15a8..ef53b1a 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -342,4 +342,9 @@ The bitbake variable defines the respective > environment variable which is availa When cross compiling, `cross` is > added to the `DEB_BUILD_PROFILES` environment variable. Please note, > that manually exported versions of the variables are overwritten. > -For a list of well-known Debian build profiles and common practices, > we refer to Debian's BuildProfileSpec. \ No newline at end of file > +For a list of well-known Debian build profiles and common practices, > we refer to Debian's BuildProfileSpec. + > +### Move do_copy_boot_files task after do_rootfs_postprocess > + > +The boot-files(kernel, initrd, dtbs) are now shipped to > tmp/deploy/images after +do_rootfs_postprocess task and before > do_rootfs_finalize task. diff --git a/meta/classes/image.bbclass > b/meta/classes/image.bbclass index 6d77243..d70a93b 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -170,7 +170,7 @@ do_copy_boot_files() { > cp -f "$dtb" "${DEPLOY_DIR_IMAGE}/" > done > } > -addtask copy_boot_files before do_rootfs_postprocess after > do_rootfs_install +addtask copy_boot_files before do_rootfs_finalize > after do_rootfs_postprocess > python do_image_tools() { > """Virtual task"""