From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7069776205411516416 X-Received: by 2002:a19:f701:0:b0:440:81d2:6855 with SMTP id z1-20020a19f701000000b0044081d26855mr12590125lfe.616.1646060544370; Mon, 28 Feb 2022 07:02:24 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:15a3:b0:443:7b15:f451 with SMTP id bp35-20020a05651215a300b004437b15f451ls1743593lfb.0.gmail; Mon, 28 Feb 2022 07:02:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwMcd/vEPJ0lFJSi4fYoE5mQgLSRSc+EDA/PTd41JHEuSp/5C44J/S8EFzLuHQNYjuXp3Tr X-Received: by 2002:a05:6512:485:b0:445:7e5e:450 with SMTP id v5-20020a056512048500b004457e5e0450mr10042088lfq.547.1646060543256; Mon, 28 Feb 2022 07:02:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1646060543; cv=pass; d=google.com; s=arc-20160816; b=gEHFL6Re9hiZ8qaY7M/pTDyVw+jgAI48DEYIUXKzR8o4rnn/RWp9EiUmhzCyKZfdJC I4+5T1/gJ5+P2zju3QrchxlFK+r3eiwgdv+TUcSRa+q3xiOpPbSYU3QPAghQ0wJILSrs 0C6ADzd4guZ+5m82rvRqLwFzZEE4rTqok0+Ge0jfJJtw555v++ssDRQxaJo8BMZ/q0gR TkH66l7VLfr6ywefs2UyRQ3HsDV6vYKzfti6XxbSrYVo2cNNXccM2D5aJZjXmg/a1fMX kMpql5ga4shYMaT3TjwxEaoff6TXqLgoNFtDVcPt/nW61jF7H+AaC0zNAtpcjTaDCeJp 0Gww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=L1u6BoaB7MqerOdXNXmMsaqIlqWhDW36gsT56dvGMEU=; b=ahIh353GJ0nmPgeFBl7lfMg8cHpLlmbCRD/cA/6YJ8hYLhsnrkqmmVsQpCay8dHaA+ ZdGfiKUH4sHU6z2djCBPW3A5KVFszU32ffMelTvU9rVy+9+BiPmFaMwPr2uSGp7TUPfp s8txeFESwwIIvk/zTguciZTwzhjokH/uHe8QbJ+VSzUkGKRnOW4uZEUDBlGrN7mx8TZd gf2H1ohqr2QSLWiH+jjNrGmw5g8APTdUiudGjp9R++gFkpmv3UTgsyBWZ707mNSogvBw q6HGdfHmpjlgHaPu4Ha/oD+6xT8nQPBnVZp+mzqwW7XbUCf0Ui2FvzsmDhlqYwzFIa0Z JIGQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=oyduj4eQ; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7d00::621 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20621.outbound.protection.outlook.com. [2a01:111:f400:7d00::621]) by gmr-mx.google.com with ESMTPS id d12-20020a2e890c000000b00246846148c4si369363lji.3.2022.02.28.07.02.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Feb 2022 07:02:23 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7d00::621 as permitted sender) client-ip=2a01:111:f400:7d00::621; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=oyduj4eQ; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7d00::621 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R+PnuhlxF42xbW7XrtOmGo95mH6/eBe2qXsOTRCSPA96LHlgAsw1NeKar3g3j5EsVkrl8eb4j7Yq36r0pEjzSMWLKHU3eQ51Z5Z6sCjwL6IrSOa3x2Miw/ICTzsNOK8yPsLL9meWXFMNYzQ/zsPbyOlWZazT1lIkaSZQhMW08hTRJ5bPlvlf5jYvI/NOWkn7taujyQicOKmhUyL75F3FwqlWAYS0AZAa/vjHT9o50UdeHIt7St8vCDKzLzijNx7pfA8KsTb+/U79rOU89U6RjohYtqasvt3aQQOGW6iznNFmsODsNNSdHzp57ta+dr3hnhZoc0wG4WhDWRjGqZBWBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L1u6BoaB7MqerOdXNXmMsaqIlqWhDW36gsT56dvGMEU=; b=Wt1ta6Nx3jgOy4XLtLko1J7Q3+04seazU8E9lGfBZmyhcOF70wsZEv4GDm+INyV+q13sJRR5SX1d1lmGBQQmGTAE0hANi9aiJFlSuZKWTs2jsoSkNEfzKG62XvKGkLEhcViZmaHoQwGEpm/rujzm5MhYFojQtcsEMv7h7hZU09mznGovf/RNMY7xftyxwZ7xmrmUnn1Xl0D/lANopYdhIFf612eHVIdScLEVoMGFN6btJGoo3JTBXLqZ4+8+y6jZlTpz1nSlVH6HiKMY67UEivhmlCz6Df8OnN9k1gs5hTuq0wKQah1ECfQdUVERaugW2/lauvB0zMC4u+X25dFONg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L1u6BoaB7MqerOdXNXmMsaqIlqWhDW36gsT56dvGMEU=; b=oyduj4eQN3R22ryolQzR2Zs0Pj2M8dC/kroNYr6Mkf09U6S+kLxIH6HwqHC0/EMYXHhwReaTqH1QhlbF/gU1C3Jsv0GmoPpkEaXgg525aaxo6mQy4Np/07a9kM8xKryWrEu6kmlhJCcFb3ntcFOdS4x94QCZC6M4lJx1+jqkSRP9hCPBIiLMB67mMUhwMbrufL/Dw0RfenmLfc+0XjHNjY4qVfCWyHXc6cXZLxd5Jt312r/rfeNDlhdR5h/ho6ZkxW869a94RHCj7GFrnzPu/L1/pcWuOKtcFhxCrxTlEoB7iLbbqp2TXQWelpAm3ge2HYvwPbwdQT3yLRsMTcal7g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) by DB8PR10MB3353.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:11d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Mon, 28 Feb 2022 15:02:20 +0000 Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::d433:79c4:958b:1551]) by AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::d433:79c4:958b:1551%7]) with mapi id 15.20.5017.027; Mon, 28 Feb 2022 15:02:20 +0000 Date: Mon, 28 Feb 2022 16:02:10 +0100 From: Henning Schild To: isar-users@googlegroups.com Cc: Vijai Kumar K , jan.kiszka@siemens.com Subject: Re: [PATCH] meta: add quality check helper to image class Message-ID: <20220228160210.6ca63409@md1za8fc.ad001.siemens.net> In-Reply-To: <20220228145918.387-1-work@hennsch.de> References: <20220228145918.387-1-work@hennsch.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR16CA0005.namprd16.prod.outlook.com (2603:10b6:208:134::18) To AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94c80147-32f0-4d77-37df-08d9facb50e1 X-MS-TrafficTypeDiagnostic: DB8PR10MB3353:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nXqXE6J+xjziE6hkJlcxU16DgY7R/Kqhqf/bJB+AIJa/QdRaPgH2vZUW/aiNR4t85ZqGZl3tjJdivN/5dhToq/aVtwjkxD9M09+4g+0DgLgtICYm60t0GTrz9hg0x6qfoMlywKg+lqr5yr9lKe7U7Bmz9MYup5/Oc7DQG7D5DBfZ6qNd1CabZX+hAAjnAXV5L+caoRbKYyAkOy8lXgebYg+jPYsFMxS7ojs15GNbPSPp1bYfGj5zgs1Ge7DFkeHVZtFS7VR2jALAuXwQpOgPZ0hxxekGQvPQL3gmIqVsC51YG2oA99VBmcW5JRdvFN0NB8ztTjj18TqWdSezhJbzq2RDXWVE5diadbqmiRBzslLBl9EgK6781pToCvSQzI8FYVy1r7eP0DCa9Yi9pa3MXwSnEQo9HXFdF43q5yLDr4IrirlRkVL1Rg9WxZH5+tDez6QlsxktFqBNURQq/FRw35NLkUyUKONQhVKVNLwwVB8/BjR28oZ/HlI3q1svc9OK8fUWjcU3GdmQyAsfutY20z+2YyPlZp9CGn6lwJRYP6BJyQKtWpfFW7tLclOlldF8krge2ae2xChfa/5vsWaRG41kZMhZC/PRxmbk5pW6wcaiXb9HMrjGYIu6ChPfQ2zWnv+Zdjqhaj5PYo2l5Y6YQA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(6486002)(508600001)(6666004)(316002)(6506007)(86362001)(38100700002)(82960400001)(6512007)(9686003)(1076003)(26005)(186003)(107886003)(2906002)(4326008)(8676002)(66476007)(66556008)(66946007)(8936002)(5660300002)(44832011)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1f5xRxVxaoKI0I4yKPkKuCJ0D3afJf6Rn5zjayEp0pdURH1UOVWTfs/Jx6TN?= =?us-ascii?Q?V8Xf83Xdk/tTdziEzR3wF+IGJuaHNcpBK7HwaBYTbSxlrkcs6bTL+YIkmHg6?= =?us-ascii?Q?c+ZgUuxBF8S53Zy5rOY7pSVUse2wSb6K1P0HU047Yu8HI+naD0rnQRmghM+x?= =?us-ascii?Q?G8w3eshiCnCW1xvJ845kF7dCsFzWGEOmJVZPJpCx5g0cy8xyGcmdRvionbNT?= =?us-ascii?Q?9yYh9JFiosLmeeOP+6aoam6DOdUA4cRjeV6PtappH/CZ1DMGPpMmlL8exRxY?= =?us-ascii?Q?hJseskWmCRvsBlwpA91plyYvY1zAWfb8pRu6d9pMwZ51YOALQVxEN1FJ/JMH?= =?us-ascii?Q?SuNaaG9qv+WXwLVBgRcQ0r2jKemtGRCv1LnwYA1pGVXoI/Py6w0CWLySsEgr?= =?us-ascii?Q?VvqyD2D1iSPfROYJL4ClLI26W6gFc+MYCizwCJPZg7T28Jies8KMnEWaGulJ?= =?us-ascii?Q?Ltt4eyBDNIOKYrcF/fF+9fpc1jLxsLQnjgT3yIcSDjghYwn3VhYAg1Q0op0F?= =?us-ascii?Q?fcIq+gEcatBM9WIOFK42cDFPw1E1yZofHii5e8U7+9BhSgHqbTwvcs0RLEYE?= =?us-ascii?Q?YZFdP022HLM5d0sKMjr9fslpQq89p0j5/baZ0DLR4TZZNxoPee2KK6Khw9XT?= =?us-ascii?Q?noJYW3el8YWOaP6OctX7UoZuV4Zop57p3FRYRetxgp+w1hPrtOlMIXylUgef?= =?us-ascii?Q?bfYWYyGWe9kI74/ydE4oLLf00LzmXMsWy548l/C3mQ3iGR5xGqz2tmKK5XOB?= =?us-ascii?Q?V6qdfRint/RLqpIl/sh7P2JifHuibvEuhmi8IsJ0yuW4sOyh2RtlFbu9pvNL?= =?us-ascii?Q?AfFZM1HtstSQRjJXH5G/drsxYOHkfQyF7WFRrjTbXvj4AImr6HixRKy8yCO9?= =?us-ascii?Q?OTOJ3QYNXg4rnGgQ6GuNqIj1Fhi2FXEqW9Hi85hUYmgWhsEzOZRGuQqvldue?= =?us-ascii?Q?AfAmrnvl50E9Jze4FVWJ13MFrerUCShKPkCao1Fv/weVq3THagrv6YLr+in0?= =?us-ascii?Q?uGOXQhJgKtQ8i+SdTHqghH9/+dYTCpChT7Ym6uIxqo6hkUrzHjEUyhykuEzY?= =?us-ascii?Q?0BMYXxrbIzSIalTrm2cofc6Iqjnz8YBvIhWQidonojeHU7FqzWqNsCOoiGCy?= =?us-ascii?Q?1JLr0e3vF7ofxuplCwaj5HepOLfYJNhm7mxtZqfMBmlD3dWDYgxpiqm4Pd/k?= =?us-ascii?Q?izM1+HE02DFgT8G0QiXj8ySTp3kz91H/ZWUJwYaH3pYraJZcTmF/PiT4nPNP?= =?us-ascii?Q?bgaBy7unsOFvDhP0xAUUPimRIJzqxCU2YqzieABbPb8WZrWaJHMVtku0D66u?= =?us-ascii?Q?zUPug2qdYUDDzkgR5peQzClHXtvryyYusyEuTt6ssLOY7s80aY6eM6fKrv+6?= =?us-ascii?Q?BnkWfFJcSKYcBdr6bZJOGD80fl4AadlTucng9wAHHNwxdB4E+PL5kdkucsOx?= =?us-ascii?Q?7cTq6zxQUCXuGvAcfsfggLwNGdGdCIJ8NINMRv+I9crrDpzlodcl78X8knVO?= =?us-ascii?Q?iemn9EN8Lu6n48bCHK5IFWxptOFjLyMXUM/uOBEmwDeoNQ3Wtj1ZXbuFZntf?= =?us-ascii?Q?+QxEXGO9z9+UerqvOvJbc7KccIiOy+tqUziwN+IfegbgKK7O3T+42djOV06Y?= =?us-ascii?Q?YemfAT1xL9SNrLeXA6F6l5v2+yIk4KSVc8BclTKycYlXeArDLbTDu9sD9iDo?= =?us-ascii?Q?GBTE8DlWWoKcvfSizcz6jKIBkJ4=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94c80147-32f0-4d77-37df-08d9facb50e1 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 15:02:20.2357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hjyzQB7av66pie3qXKc1Bfhmg7P//pVHdxO4SJ2mprQD4Nt0ppDFDMYqmz4PxUf+H9ghIRIvabtTDhVq++SCVVpSMVImNYdv3gnnxo7R6IU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3353 X-TUID: ZjYYU2WTzPX1 Hi all, this is inspired by the discussion around "[RFC PATCH] image: Reorder do_copy_boot_files task". Early tests suggest that this works well. Everybody might want to try this on their most hacky layer. I could envision future QA checks like ... do we find any files that do not belong to packages but live in package manager locations. regards, Henning Am Mon, 28 Feb 2022 15:59:18 +0100 schrieb Henning Schild : > From: Henning Schild > > Content of rootfs should ideally all be coming from packages and their > hooks. POSTPROCESSing and custom tasks should be handled with a lot of > care and avoided where possible. > > This commit introduces a quality check task to help devs not > accidentially abuse POSTPROCESS, while allowing them to add files to > an ignore list. > > Signed-off-by: Henning Schild > --- > meta/classes/image.bbclass | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index d44298bcdd7c..a0d44489d5bb 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -231,5 +231,33 @@ EOSUDO > } > addtask rootfs_finalize before do_rootfs after do_rootfs_postprocess > > +ROOTFS_QA_FIND_ARGS ?= "" > + > +do_rootfs_quality_check() { > + rootfs_install_stamp=$( ls -1 "${STAMP}".do_rootfs_install.* | > head -1 ) > + test -f $rootfs_install_stamp > + > + args="$ROOTFS_QA_FIND_ARGS" > + # rootfs_finalize chroot-setup.sh > + args="${args} ! -path ${ROOTFSDIR}/var/lib/dpkg/diversions" > + for cmd in ${ROOTFS_POSTPROCESS_COMMAND}; do > + case "${cmd}" in > + image_postprocess_mark) > + args="${args} ! -path ${ROOTFSDIR}/etc/os-release";; > + image_postprocess_machine_id) > + args="${args} ! -path ${ROOTFSDIR}/etc/machine-id";; > + esac > + done > + found=$( sudo find ${ROOTFSDIR} -type f -newer > $rootfs_install_stamp $args ) > + if [ -n "$found" ]; then > + bbwarn "Files changed after package install. The following > files seem" > + bbwarn "to have changed where they probably should not have." > + bbwarn "You might have a custom task or writing POSTPROCESS > function." > + bbwarn "$found" > + fi > +} > + > +addtask rootfs_quality_check after do_rootfs_finalize before > do_rootfs + > # Last so that the image type can overwrite tasks if needed > inherit ${IMAGE_FSTYPES}