From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7069776205411516416 X-Received: by 2002:a1c:f413:0:b0:37b:d1de:5762 with SMTP id z19-20020a1cf413000000b0037bd1de5762mr3185531wma.108.1646302154783; Thu, 03 Mar 2022 02:09:14 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:2a9:b0:1ef:8a00:36a with SMTP id l9-20020a05600002a900b001ef8a00036als2160123wry.0.gmail; Thu, 03 Mar 2022 02:09:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8mgTEM9eNRte5OxFnVUTKLekKSCWDl/lju1kppAs9Nk+nh0q43+ZoilAxjvAsgfWPkBaL X-Received: by 2002:a5d:440c:0:b0:1ee:1c9a:193e with SMTP id z12-20020a5d440c000000b001ee1c9a193emr25540095wrq.523.1646302153975; Thu, 03 Mar 2022 02:09:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1646302153; cv=pass; d=google.com; s=arc-20160816; b=vwn/mt6idWjmoCkNAUlRyu37mPn9sP6imb7FLDBJEa3veunONTmHlLsBWJy2iwuFpi fUw/e4YIXlt30XHuqDOPzIICi89oG//nBd83VrBwBX8yJWI7dZHSLYpXtECNEOiKbzUx 2CKt1nQLyx3XtDBFTEmq7/wsVpzrCN+8tKgEfVrTqupZVaPuR1I4EcsoZ5FNrPLNm8LL tizGr5wj0OqoI1U2ssayIVWzG+5TZ5INHwiBKmD1HE9g90LSH0qXUKAGSNhIVKlQuZIs U3voYKFz2XjkrTEhbm/h2ujMhEuoM5Kkw1ZZNqTJ1y9I7PkFkpkcaha8mV0MjyqfZOLI iBtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=V8otOP4rnkvgkR7DTtX0D0FUftJip6W5ZE089yZtPpY=; b=ImA34kfmunJUS44GRxvAevo2dFO4NHhzWUK/Iv6Nx1Lqsx7vxXx3sO2oaxFjBKhXPo UcF77zUgy5aPUPDw7pOX1WFmAPzBvtT3+14sSHdicAtBSP776djTZikMFEH4PjyPQ8vQ 4JEvGaGRMjfA4Q0yH4rvfUt/ZX/HgEeo8m7UdRgXM2bk73aBh9716BK7tnT1FoiHrYUU yV4WG9Icuqs/6x/rlbkNzM4V2iwGoyTu1tskTuApr4coUitv8GW3q59H7cFFn+weAQO7 npGVvJyG6xZRfVdzCbMjizCQBL1pxRxGvRsnQ1OcCeDlPbCKBBSR8QSJV3axiqcorfz+ UR8w== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="bGEi/zl0"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1b::626 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20626.outbound.protection.outlook.com. [2a01:111:f400:7e1b::626]) by gmr-mx.google.com with ESMTPS id bg3-20020a05600c3c8300b0037e391f947bsi443530wmb.4.2022.03.03.02.09.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Mar 2022 02:09:13 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1b::626 as permitted sender) client-ip=2a01:111:f400:7e1b::626; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="bGEi/zl0"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1b::626 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cQWrkEQSVdfXw+ZtJBuY7t0osbr9D7KBBQz0RO0vAl6lPQhxQJHFPiGAb/Avud2/d2Yg6PAYHSvHDwCyFCcst7pBtImYqyVzZQj+p4UdfEtZD8LeyDzyuBXGsXtt9pqQi5pgYfCsRuVI1VePnrr7iw07b1OzbJPwXu9zXISPFMGk74cGhnOnzli32Srw2OLXUYymooxsqKxLfG1Vfc6+dEtqFRt4Mm6pObcVh96mOLHRHMMklRWpG95lwd8PIrfRr5x5rL/x0W9wJrT9EfoH3OCDnEDIj+KPSbByrO0jSqjsBXtBN4waEEfkoW/b3oZNCaWaKMwToy57T3q+SNtwpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V8otOP4rnkvgkR7DTtX0D0FUftJip6W5ZE089yZtPpY=; b=evHOZb0vLv2wuUwGszwhtt6SZYRAb7XumaIfx5fDYgKrDOLlF1PEv0BSfH9pPSTSZfIVISj6nmdGK47odH6pyqma6zrQeFNs0OV9hLRTQvuSlOWDIzBIK7dS1oxlMk8O4XZRDyn7QacLdDRJsOBDHDfuZqWaMXdX2wO+RKhQuc0K5wWe9A3vNWz+MMtiR2LWKXOFmKSNuMrJpfqypSjQn1tQFH865NXR2ZH5CADU9DsU3obRZeQ1rytm+M79jto4XEtBzjHyMmHY7/Q+K0tlpMBJVy92xilXhNGCyG+/LAVdhnAchyLKJpTad+VYjg2BAN83f5v72FdOQ8ytGifLcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V8otOP4rnkvgkR7DTtX0D0FUftJip6W5ZE089yZtPpY=; b=bGEi/zl0r4jVIY9Bjx3SvLkYwBGFiGP4WQlNICOpW19xyRMEVDaqnWRvNydXn9lAvac6cjvNlVvXjxYAnLk//0w0hJQEsoL5WBq62wK4RR0hqn0Ozake0GCNbjyg1jvEkgsGlvsgFBPt1atxte7981vtTxUFb+66ROELLsUhvNuhO2N4a1MTg+vDF0r9Akt/c/bFCGGY7Xlnmke9Be3gM7RNliFkWOIsTIzGGdGUQ0BlgGXU82QgT67tCN/lGpMX7f1hruSHSKIDsnVZuHqP3VrvSryrXv+UcJYEtEW4meKNPfSwFv8EWerDJUSyM++DxNxTvbSDLhBR/uyLJzQENw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) by AS8PR10MB4373.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:2ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 10:09:13 +0000 Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::d433:79c4:958b:1551]) by AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::d433:79c4:958b:1551%7]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 10:09:13 +0000 Date: Thu, 3 Mar 2022 11:09:08 +0100 From: Henning Schild To: Henning Schild Cc: isar-users@googlegroups.com Subject: Re: [PATCH] meta: add quality check helper to image class Message-ID: <20220303110855.0777a483@md1za8fc.ad001.siemens.net> In-Reply-To: <20220228145725.32716-1-work@hennsch.de> References: <20220228145725.32716-1-work@hennsch.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0022.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::14) To AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42888aa3-6067-4ae9-affb-08d9fcfdddaf X-MS-TrafficTypeDiagnostic: AS8PR10MB4373:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0ZrZzF8Hb3P44qcUmQK385f/pkTte6LDEMfZNCaxwEiKuza4D6BidkJlEJMKHVM+OtDrigdBEXKU2gYo6ljXRplomJ+DUDRbU/b98HkAFcvylHUXLZwqylik7EjbC1Oy+es+xl4oNy7csxCsvCsoGM9lhmKYHP2Bg6P43jfR315xk1CssEifD1UxZ1XcU3u70mvGpFxxTW1xxZt0Hv8gNJtIitl+TcrKfFsWOUsdb5yJYwhGeeaPH9HJHGxzQ2rFdzIMkCDbJ5VchYtcd4T5H4uuIi3Y8bPcH337PfJdokeua9u4pvIhLoFV3spSGX+y6OjfQTivVAY7ErnjTVf5/SU6AF0DRvan0xd1hLWAkvTD6XoLq4hk6WfBaguyIR84Fr/yzmjxqQGD8i93FtMxuOd9Lz4AYFr516M1y+9TlMPdkWMb5Clu8ZHTa9TexxVcLqzNrLg7rhL/rUCVVlxyqv38J7xpoTGg5A7wUb6LvOLsH1Mtl/CunaZS/x4OmNgjRo8HXgk+PHLesCaknKkyAUpLCGrIdulAymYf3lqAxXp6pHl6HBXl3g2WGn8orkKuYB/0nTNNFUNMDdpnDZ/E5X+ETVnr2DbflbwIpta9Exvnwg+UTD+ddLiIWGlDHWxObH7aLrfCb8vq07jCsqamJw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(6666004)(6486002)(9686003)(508600001)(6506007)(8676002)(83380400001)(6862004)(6200100001)(66476007)(66556008)(66946007)(4326008)(82960400001)(5660300002)(8936002)(2906002)(86362001)(316002)(186003)(44832011)(1076003)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z0CWDFxGUsuSBeJVWIRASfZvalbm/f/6kziNv2oU6hSwCCV0uVvliSEY76Kz?= =?us-ascii?Q?ApJ0lG0zLlNICEwFMXWjp39hRn7ALzD8Gmrxv7Hr05oOS3BOkfjk0Rj0qYFb?= =?us-ascii?Q?aQfo10F/WUjHi758Dqwfm4kL2Ud421vQSR/2a/GUUl28WbKRA1LGvRzKQWIM?= =?us-ascii?Q?pieOQ8qu53d0ua55bweeOLcRmxETR6p/u80EGF6sIImH4ju9+Wd6wauLuJRk?= =?us-ascii?Q?PcXZTZkbsn2TJP9lXVCvT9J8iYOGpI+zUdGPwS9cLIdKzqfgTKhjqGRdsapn?= =?us-ascii?Q?sqRuCgDzeXrRo9klcFFEHDJonmDx2SQ9XotdJtyXjDBBUcgO1QtuHrEPL07x?= =?us-ascii?Q?fVlh3EpMVFMu8zdIKw81DW/zPqWrqIMleljIkgyFUpQAlhKWvq8DT56tHFNk?= =?us-ascii?Q?7SUA1guQa6hs+m0MUeVgxcGek77PdjY1VaLLqQ8OqLWav+svym4DGZZSXZga?= =?us-ascii?Q?R8GIcHctntmihTbPq59X87fyZFaVVBVXSaYIAs8yGNWR+eyL4BxIO1o8v2IS?= =?us-ascii?Q?KG2g2LR9edt7nKGlcfKvbZ+eXZolBLNtM4TqJqIBigp1V/G3DIhVRNAfPCMM?= =?us-ascii?Q?k2fiFL01mGTc8T56KsZKO58nu2yt1+40KLVXxvj5W5kZuj689MmcSpAt/GeV?= =?us-ascii?Q?2qrL6Xod1Nt+9TBvsmkl15kia/zpMZOsgMyjEQJ9XbjseKURPiIk8v+0VN/e?= =?us-ascii?Q?3Vs40m5jjSKPgXJzDrXd53I24slu5FaF/eYfHhUL/9hg6ntKeuPfTVry1m+n?= =?us-ascii?Q?7N4UPz3WBrumo/idzFA5fmoRuciortFAv3PIMMrFq2xDMUJpCqHjAXhmrtTV?= =?us-ascii?Q?B56ECGhoFyNJl9YVHHpcNpQr2BVDKLqOqNHCYVX9GQ0+NHMo2vQF6foNurT7?= =?us-ascii?Q?a9V6ubJvXI/BNCILRwUKVKdfGB41zbCVaHEWQSEXmAfxuqgDt9PvlBe4HRhg?= =?us-ascii?Q?LFlt+envC5gp9y55Q+d78e7cR2UQHrwJ/NmuYdsR3Iuq8qc1elpG1+BECGfd?= =?us-ascii?Q?MT1m/rGe+HxJr2/R1OPjfFXNJt3WidWy/KSCLd6xd/7YccwjwyqrdEzroNov?= =?us-ascii?Q?wCRnpn79zfXahpkSIbBCXTA4NlDo6wNCepBhN/j9KOr/Q0tHcBbBMo7urxLL?= =?us-ascii?Q?MeMmKLgFT2iYk6C5sTX4rqMj1HNFwftBy5ksdWYVgvdtogRMonYjqjxlHS4Q?= =?us-ascii?Q?1j960+Jgu7/EMekdT4Lu1yydcTmXvFBRwZ6NIjs4shXONhT7fOyCJNJDZKRX?= =?us-ascii?Q?3dGL8Gk5BDGvELFI6yuiNq/iuip4TNBAKa0JOlu11kOKAFhw8pxuNS3bHT14?= =?us-ascii?Q?ZWfNEa8mKpl7ZZRa4ceXUBHgSj1o3BelOvM1tLL0PSAtK6IfWHXVXWI7hx9R?= =?us-ascii?Q?wo4snJ306KoXhOI0P9xPu/p+0tRXw9ftMczniKnL66K1Q5uZiAFzYJvfoGW+?= =?us-ascii?Q?YxUc+e3LtDswclTeMpmaQ89t9rhahfyolXAlIkWHhb68Bh4iektpNb00Xpx8?= =?us-ascii?Q?4KuHpf/v+0rqTrQbT1Wv9217pElkBSod/6FTFnRTTFmxhdwVIupV/ZnrZba5?= =?us-ascii?Q?GDdsf0qeBqEcytiAZZ2lVQJBHAacneAjXzUe66ng+7pnJdXe0QfHx4zc/RQb?= =?us-ascii?Q?gI1qn++t3p83pkxOfDGD4k3+8c9O5SSKcaJjrBKIYc+5sWGfqcdYAXimFykm?= =?us-ascii?Q?zM6xrB1utHqnzOCEaAQOjViGfpZmc99flJFnw/zZznEQ6cjt/7Zt40sdspQP?= =?us-ascii?Q?Gas3cCmizA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42888aa3-6067-4ae9-affb-08d9fcfdddaf X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 10:09:13.0057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: of1sh9UWiairdo5fG2m5lnsFbXSum75IT4K/xfPlD8TZW7QvgOTokWGQULjWiXDgztfsW45RmywjMc8OyxYHrNtdoccdGTC6Ig+HKc7Tp+Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB4373 X-TUID: BvRWmsLklw24 Am Mon, 28 Feb 2022 15:57:25 +0100 schrieb Henning Schild : > From: Henning Schild > > Content of rootfs should ideally all be coming from packages and their > hooks. POSTPROCESSing and custom tasks should be handled with a lot of > care and avoided where possible. > > This commit introduces a quality check task to help devs not > accidentially abuse POSTPROCESS, while allowing them to add files to > an ignore list. > > Signed-off-by: Henning Schild > --- > meta/classes/image.bbclass | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index d44298bcdd7c..a0d44489d5bb 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -231,5 +231,33 @@ EOSUDO > } > addtask rootfs_finalize before do_rootfs after do_rootfs_postprocess > > +ROOTFS_QA_FIND_ARGS ?= "" > + > +do_rootfs_quality_check() { > + rootfs_install_stamp=$( ls -1 "${STAMP}".do_rootfs_install.* | > head -1 ) Will need to take setscene/sstate into account. do_rootfs_install.* -> do_rootfs_install* > + test -f $rootfs_install_stamp needs quoting because "test -f" exits 0 while 'test -f ""' does not Henning > + > + args="$ROOTFS_QA_FIND_ARGS" > + # rootfs_finalize chroot-setup.sh > + args="${args} ! -path ${ROOTFSDIR}/var/lib/dpkg/diversions" > + for cmd in ${ROOTFS_POSTPROCESS_COMMAND}; do > + case "${cmd}" in > + image_postprocess_mark) > + args="${args} ! -path ${ROOTFSDIR}/etc/os-release";; > + image_postprocess_machine_id) > + args="${args} ! -path ${ROOTFSDIR}/etc/machine-id";; > + esac > + done > + found=$( sudo find ${ROOTFSDIR} -type f -newer > $rootfs_install_stamp $args ) > + if [ -n "$found" ]; then > + bbwarn "Files changed after package install. The following > files seem" > + bbwarn "to have changed where they probably should not have." > + bbwarn "You might have a custom task or writing POSTPROCESS > function." > + bbwarn "$found" > + fi > +} > + > +addtask rootfs_quality_check after do_rootfs_finalize before > do_rootfs + > # Last so that the image type can overwrite tasks if needed > inherit ${IMAGE_FSTYPES}