public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Daniel Machon <dmachon.dev@gmail.com>
To: isar-users@googlegroups.com
Cc: Daniel Machon <dmachon.dev@gmail.com>,
	Daniel Machon <dama@universal-robots.com>,
	Torsten Bonde Christensen <tbch@universal-robots.com>
Subject: [PATCH v1] linux-module: remove double quotes around AUTOLOAD
Date: Thu,  3 Mar 2022 12:47:24 +0100	[thread overview]
Message-ID: <20220303114724.3399961-1-dmachon.dev@gmail.com> (raw)

If the AUTOLOAD variable has more than 1 entry the for-loop in
do_prepare_build() doesn't expand and therefor result in a
one-line entry into the postinst file. This in turn gives the
wrong format for the /etc/modules (all module names are on the
same line) and therefor fails to load at startup.

Signed-off-by: Daniel Machon <dama@universal-robots.com>
Signed-off-by: Torsten Bonde Christensen <tbch@universal-robots.com>
---
 meta/recipes-kernel/linux-module/module.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
index 968ac4c..fa13e41 100644
--- a/meta/recipes-kernel/linux-module/module.inc
+++ b/meta/recipes-kernel/linux-module/module.inc
@@ -30,7 +30,7 @@ TEMPLATE_VARS += "KERNEL_IMAGE_PKG KERNEL_HEADERS_PKG"
 do_prepare_build() {
     cp -r ${WORKDIR}/debian ${S}/
 
-    for module in "${AUTOLOAD}"; do
+    for module in ${AUTOLOAD}; do
         echo "echo $module >> /etc/modules" >> ${S}/debian/postinst
     done
 }
-- 
2.25.1


             reply	other threads:[~2022-03-03 11:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 11:47 Daniel Machon [this message]
2022-03-03 14:15 ` Henning Schild
2022-03-17 13:47 ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220303114724.3399961-1-dmachon.dev@gmail.com \
    --to=dmachon.dev@gmail.com \
    --cc=dama@universal-robots.com \
    --cc=isar-users@googlegroups.com \
    --cc=tbch@universal-robots.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox