From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7070839259639316480 X-Received: by 2002:a05:651c:201b:b0:246:34b5:155e with SMTP id s27-20020a05651c201b00b0024634b5155emr22238770ljo.273.1646316926411; Thu, 03 Mar 2022 06:15:26 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:552:b0:246:2d50:5db7 with SMTP id q18-20020a05651c055200b002462d505db7ls476117ljp.2.gmail; Thu, 03 Mar 2022 06:15:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJycBno4FVw40XmxJ7wXU6RPIdK3vCh0kUYYS2aTAe1VNKOEX7WFN+AQ5wmPPYxOgxs3AVAR X-Received: by 2002:a2e:b90e:0:b0:239:3332:c83c with SMTP id b14-20020a2eb90e000000b002393332c83cmr22687146ljb.426.1646316925406; Thu, 03 Mar 2022 06:15:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1646316925; cv=pass; d=google.com; s=arc-20160816; b=OIL2u/5wfoM6Jg517DrnS4dT0x5J11oDbo4hucBjUJM34NCdz+QyJoIFOGrZqcpTt4 AQS7lb5P1/auL+tAhxPiUsScrGycQ4ZhPk468q3pHYsEjxUrynJSogG+qR84llCkJyOE N1yTCA9HLR9Edyww3FnuMdpiYhBjFzZ5YDaHg9bi708qpv3AtbAS0/2pqwv6YWZFMh1W IMxLxrKYTF6pMvYQYizcM+Vppzmsocx4DqinKlsqGIbcifHo0aLmif7jVUcKHmIRk7K7 jt3ZaCC7UlsDrkS+KAyqsWQGaKUREl5fUYNdFqUQVHWX/QTOMOswnHTxg55CaQz9/MHX jarg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=dD7XRSxwv/mhrmNeYahx4b4JHN0iQc7ZdhPqd0TUKK4=; b=eL1PGrXoQe0r3tSiXwOeoe2coO4BXooXaLY1tl1m0yIcIZeFDKo+uJeLB1JpKadk9x NBVs8K7hIL44V+hn7pnXgADq/t93xb55rtTrf8PTB+XeWcWVO568/ruYRTMu8RjwVml0 OPDnz6+ZBUetys+LyajmraJM3tINhDzZVE8mZvK6kwEY3Qn85GDHJta1KgawteWotfwz Cg5fmDYVSMs5WhLQ0dOe9pPA7cf+OwhjkyqzEjVkClt1Y+sW2awnfVYg8iED5psYG6v9 /WTZgdBPHYDrKsy8ZJw76KmouKNIS792uqn9LpoThJTnqPQsPU3yvMNjPFiJx/z7+vhE PSEA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Im38jScD; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0a::609 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03on0609.outbound.protection.outlook.com. [2a01:111:f400:fe0a::609]) by gmr-mx.google.com with ESMTPS id n2-20020a2ebd02000000b00247a36b13a3si105209ljq.0.2022.03.03.06.15.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Mar 2022 06:15:25 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0a::609 as permitted sender) client-ip=2a01:111:f400:fe0a::609; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Im38jScD; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0a::609 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AYqK2oKmejBrUmoA7qVOsKXuszeOvMvzmWvYAfgNe8m7rYsMcCYsVNWvsxHR/jC7s/GDLdFP09LXPzS200911IX/MqKbP4EtI8tZ0BYA9/AaONcbX0sHjuxPRTBL3UbcslZVCrpABtTPohcgr9Yn9Jrl508TZampcru1iApxhCn3iWoKbH15FBRslxd9r1NpXLn+IVQbmBEtCasmTyVMIkGwRCYcAyrLgkYdXYFqi1IT3LabWwYXsRc5sr/EMJONrw98NtlC7xbp/mqR6Swq7+Gey1/ZKxx0p2P6XnZwqbZar4NYhUA4ff6SlKkg5Kx95KvGcqbhQkvLAN3Vu4oHfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dD7XRSxwv/mhrmNeYahx4b4JHN0iQc7ZdhPqd0TUKK4=; b=Y5MC3j22MSayQJiQ1GHC1uMJ1AGbM+XBH2mOe4Hb3RZYOdVQDPE1rtPoAFdL72NNS40zDvP8IyghInba1tIoQisSsUZFc824X6MfAFs7z0Snl9qIXwoWi/f/QrQ7wnpfcBB4mOe0MbVNa77oaFN0esjcbxH2KxtE8YC2fG8xq0o/oelsWlJkkdxVtUQNC1mT4HbDIVW2NEmdRlga4RKsbjougDpK0euL4WiAtWmMr9IwJ5SZYYHmYUZlr7N9AKZ3aWohPvz9T5g9GPi9xb2It6q1H1k5PFpVsaNfLW2DYv4pix+wf552+IbAA3wZMWsjtKRT+ttKBiJWhh7qXBiBGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dD7XRSxwv/mhrmNeYahx4b4JHN0iQc7ZdhPqd0TUKK4=; b=Im38jScDZi7vZyulYHwhhIMjGerRNmGiSMWl0CVKybYiFMPu/chT4YwUVek6NWWahrWcHpNsGvyIJOPtEOs4Q2+2Z5Jl6dZkSopKcBzkN5k3U6uLMabB9U1gHK/RtdyysIxONUX74Z0hgGZE//RcIo2lON78T3aTAtt6yFVzVtQilIl/geCSqj9Z5/Ooyc7Wxoey5ddoKjNerPu8FWD/xHdoTm9r3d5n99M5ndJvqqIlvf/JFcnu2AR1rsfj3vCpy6b2lKEavNuvS3vR64yTePVjeMuxVVAdITEpNV/s3v1j/9734KaarachslTJZTX3Gh6fW/msCjE72N2akSbboA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) by AM0PR10MB2180.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:dc::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 3 Mar 2022 14:15:23 +0000 Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::d433:79c4:958b:1551]) by AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::d433:79c4:958b:1551%7]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 14:15:23 +0000 Date: Thu, 3 Mar 2022 15:15:20 +0100 From: Henning Schild To: Daniel Machon Cc: isar-users@googlegroups.com, Daniel Machon , Torsten Bonde Christensen Subject: Re: [PATCH v1] linux-module: remove double quotes around AUTOLOAD Message-ID: <20220303151520.5a56cbcd@md1za8fc.ad001.siemens.net> In-Reply-To: <20220303114724.3399961-1-dmachon.dev@gmail.com> References: <20220303114724.3399961-1-dmachon.dev@gmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0119.eurprd04.prod.outlook.com (2603:10a6:20b:31e::34) To AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 837e48b8-51ab-4a97-eb9a-08d9fd2041de X-MS-TrafficTypeDiagnostic: AM0PR10MB2180:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1sDx29QE9UCEBOwL3os01zKo6oB1iyLxCbxWrqH1iDuW0GvBLc51XFk8lsv2++TLocaPBFNNGHGd/jBZqsA64x/wFdN1F/qS0yc8GZKKzB3zjVeVNkguiSuZF8+UpZnV3ZNKWgUySuyWxAVKtyeUAFZW0NfdEIgCmrlaCIlJJmENREiFLChxa6CgeBHIUdL08SA9/lRPNtDCbaLjYw3ZZiiQ5zJlIP9PTMTToEmKsv+VXc+fjRxfREXhnF20SfXmmvclqVgokac3Jl7moXqYkbGGBD8q8iZb/vlpaKS59M+Vuy/myQ9mDmPj3aN++xB59OzWcun+qsdqFFKxgYLGRTpffy9+vfYMPF6xH8aKLfgPynmNZrGIeLwAULgrG4ulS+qFmEcIYp86JSolB4r7TnScsibplIreFAOVGYtaA3P4A4cbuMpGgnlOgg1GlUktrq55JGE0j03V96ClzE8ua8mZ7ebYfYrZdBJAH1uuqNtPQAM68Supku7owHLvC4/qQ5vjyaDUp1JkFaT20b0x0Euun/jbd9l6Nuy7sIZjyUjfMKsvonqfRodlqYdmYw9QRb8tr/WGqZRf5l96P5WBrpCcfZO8wO2ERkMJ+1J8oCY0RCzKfzCcPkUV8gxK0QsjVXx2iuOhlIYqAqWzxodufQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(316002)(54906003)(8936002)(86362001)(66946007)(6506007)(66556008)(66476007)(8676002)(4326008)(83380400001)(2906002)(1076003)(6512007)(9686003)(5660300002)(44832011)(38100700002)(82960400001)(186003)(6486002)(508600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Dd77xY9eBfMO+HTmCyYvThG02vV+Qg8gfPgiNuyytJSTHzk/kHq4AWu6wJgy?= =?us-ascii?Q?g+OEy/adydTPfpAN9NljDgsjun4MsuAgXAJ162zsy/FTNz44+iql0CqEl057?= =?us-ascii?Q?/NEFO0r3rGdn7Z2jd3fHBMtcLSpmNvMCfeBabqcts8oG6FqUWKOMfkSYrfqR?= =?us-ascii?Q?tDZNdwmqKWsnWprWd2gfVdC2en/nO6PFLwtj0BX8p2A09H4LoqXczOEZCFp1?= =?us-ascii?Q?CGfft1AfWIL+eiJP1xu6io7y65x/v6b1jWtWsTLo4eqBl1QCOQWLYnc1cUoh?= =?us-ascii?Q?LCD+0op8QYQhWE/VsuCLHyuJ7GuabJYwEgbEpq/wx7PqPlVOiC0OJUq7zRzZ?= =?us-ascii?Q?g08xMEGZqHWasgtGywcYN07C38O5SXmObjCxynFC6K1q1DLPXwvg75qO5MaS?= =?us-ascii?Q?+990NjKVsHlKMyTQEigh1RYsmxKdPKdPtf1EXcybqmZGJWzETCA1PzsQ8I+s?= =?us-ascii?Q?C9bK/WmWXPYBw0vtzFm4SylNy7fIDjQ68rw2sE/gtJD3eVHpyAjTPKKdFELK?= =?us-ascii?Q?uEjv4XzZ9t7w+0ZTTPiOafy7f1BWhlloKqbBYcWixRrXEeKjHwkMo+0VlgDG?= =?us-ascii?Q?M9mp5/8I1fiQ3RbE4EE6bKFGqEcOeCkSgH9ScQrAn+7lBdZhBSOjMAKRDAAc?= =?us-ascii?Q?CL95Kh81R2TpHLXJf6QqOiOhNpFcrIpdB5j3BLmKQ41W1UuVyfF6OvWDUYfL?= =?us-ascii?Q?zHFKKCiIqSXDWg+JJpCe3buCm7gpcT0EHPnzY5542FiX3krjRzAeZXCMEEn0?= =?us-ascii?Q?Yef81No7Mjw4Z4Y7AZ7HUYpYd7U6tZyXYJmPRilJ70mGN9tYfaIWxMVksnqv?= =?us-ascii?Q?R7Pn7stfrxUv07VzquX+dsQgXxXFxziUwSm0EdMUejkOuPO5Cobwu7CCW+Fp?= =?us-ascii?Q?AroejOlB2H/0qbeFJOP0uWnmDTmuxplYbYyuT0Xj8MxAbqwmwYIagZPA45+i?= =?us-ascii?Q?Y9DzD3syYBdmu2wcyREqm5wKvj9ZWOJGyaGx3cF/ZbHk1WEkJAiHKAgr3D85?= =?us-ascii?Q?+bpMk+E8h8NpAkRcppM/bEbk6hGa7DxsrRFqQeOTbniOAg3Y9EDqMrUwGlnV?= =?us-ascii?Q?7x6mnzoq5q8vLweELn5WCOqtlKHIyNzwK+szcG14uDvSGgdliKo9zru45ZGl?= =?us-ascii?Q?NY9wd6T6XAq6iD49t8pXmmxqvsLaisfMEcOA+3PaoRKA9QLbW2/KWbJXkVHU?= =?us-ascii?Q?IdfhSMnIcuy6c7mEljS6kDqPpcbQddZcbvLaKwrCQGpWJJ1bAXu5OiA1f3ts?= =?us-ascii?Q?8Oli9LdZ7NHj8H4Htpa+VKEXOtzIVAO9da24/wqIJQdjw0KvPDtdySWQZBHS?= =?us-ascii?Q?QxQuQ31RWamO4Qbq6fgcv7g4kXhrEIIbQEt/XQnVLvrqzawr6qIEgcgEidEj?= =?us-ascii?Q?4IO6+5F0Tubd2nR6yXTIanR4EWrsHKqwGRq++o6MnSs/glxvQLUJeVuk/Bxk?= =?us-ascii?Q?mreWYHs2XFJOMomP4Vdqke0LXv5HhL+iwFkmVHa1JG4Vov/4ixRRcP5JIg99?= =?us-ascii?Q?GL6jAMb4lU/SPgPbu4rWtj1k0pRb6xsJMkiO00D5u943HBC1uPOkIu659t+/?= =?us-ascii?Q?/CEpNHIJVQG55db+M33X7xfcSN0x9KFPAF7BM4ZQNC6fDLY0UhWq7K5SyuQf?= =?us-ascii?Q?2QnHLgavSq76ycNvdLlSJ1vrqvnmB7GHBb25NkGkelpHlcl0SET1nD30qbSq?= =?us-ascii?Q?y9Ho1WsB955ZpTR/gfDkgYalWXQ4MiT+I2xsa1p0En/iOwfvvCBLPluVFqZY?= =?us-ascii?Q?OlB0NfMIAg=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 837e48b8-51ab-4a97-eb9a-08d9fd2041de X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 14:15:23.8205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nPfQx1hPFkBfvD9AusolpG0g9emjE06rSdu7NPzyDTLo7h8/HiINGUrwjMesF3X7An+yMQVK++rxaotGI4kqjbUSeSLY96lzq1h7b3dADnM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2180 X-TUID: OhenK0J78XSo Good catch! Well written modules will know when to load and how to depend on each other. MODULE_ALIAS MODULES_SOFTDEP and some more, but yes if your modules do not do that and one package has multiple your patch is valid. Thanks! Henning Am Thu, 3 Mar 2022 12:47:24 +0100 schrieb Daniel Machon : > If the AUTOLOAD variable has more than 1 entry the for-loop in > do_prepare_build() doesn't expand and therefor result in a > one-line entry into the postinst file. This in turn gives the > wrong format for the /etc/modules (all module names are on the > same line) and therefor fails to load at startup. > > Signed-off-by: Daniel Machon > Signed-off-by: Torsten Bonde Christensen > --- > meta/recipes-kernel/linux-module/module.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-kernel/linux-module/module.inc > b/meta/recipes-kernel/linux-module/module.inc index 968ac4c..fa13e41 > 100644 --- a/meta/recipes-kernel/linux-module/module.inc > +++ b/meta/recipes-kernel/linux-module/module.inc > @@ -30,7 +30,7 @@ TEMPLATE_VARS += "KERNEL_IMAGE_PKG > KERNEL_HEADERS_PKG" do_prepare_build() { > cp -r ${WORKDIR}/debian ${S}/ > > - for module in "${AUTOLOAD}"; do > + for module in ${AUTOLOAD}; do > echo "echo $module >> /etc/modules" >> ${S}/debian/postinst > done > }