From: Henning Schild <henning.schild@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>
Cc: Adriaan Schmidt <adriaan.schmidt@siemens.com>,
isar-users@googlegroups.com
Subject: Re: [PATCH 0/6] imagetypes
Date: Thu, 3 Mar 2022 19:55:04 +0100 [thread overview]
Message-ID: <20220303195504.2494664c@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <4bb37893-596f-8a2c-3f7c-9d48ee493602@ilbers.de>
Am Thu, 3 Mar 2022 21:35:12 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:
> 10.02.2022 09:24, Adriaan Schmidt wrote:
> > This series introduces image types and conversions as known from OE.
> > The main motivation is to provide a more flexible way of generating
> > and processing images, without the need to insert custom tasks
> > (e.g., currently we have custom classes adding tasks for things
> > like bz2 or xz compression of images in several downstream layers).
> >
> > These patches have been tested on some of our layers, and also
> > work with some more "challenging" use cases like image-in-image
> > recipes and custom image types brought by layers.
> >
> > It's not perfect (e.g., documentation is still missing). Also I
> > added just the bare minimum of conversions, so there should
> > probably be follow-ups for additional compressions, or things
> > like checksums, which can also be nicely done with this.
> >
> > - p1 prepares by removing image-type-suffix from image build
> > directories, which enables sharing of the completed rootfs across
> > image types
> > - p2 refactors the SDK, and makes it an image feature instead of
> > a separate recipe (has been discussed here a while ago)
> > - p3 does the actual work, but keeps all original files
> > - p4 moves code to different files
> > - p5 adapts meta-isar
> > - p6 removes IMAGE_FSTYPES as a dimension in multiconfig. Now that
> > we can build multiple types from one rootfs, multconfig is
> > just the wrong way of doing this (also been discussed here).
> >
> > Adriaan Schmidt (6):
> > image: remove IMAGE_SUFFIX
> > image: refactor SDK
> > meta: introduce IMAGE_CMD_*
> > imagetypes: restructure files
> > imagetypes: switch meta-isar to the new scheme
> > meta-isar: remove IMAGE_FSTYPES from multiconfig definitions
> >
> > meta-isar/classes/rpi-sdimg.bbclass | 10 +-
> > meta-isar/classes/ubi-ubifs-img.bbclass | 11 +-
> > meta-isar/conf/local.conf.sample | 4 -
> > meta-isar/conf/machine/bananapi.conf | 2 +-
> > meta-isar/conf/machine/container-amd64.conf | 2 +-
> > meta-isar/conf/machine/de0-nano-soc.conf | 2 +-
> > meta-isar/conf/machine/hikey.conf | 2 +-
> > meta-isar/conf/machine/imx6-sabrelite.conf | 3 +-
> > meta-isar/conf/machine/nanopi-neo.conf | 2 +-
> > meta-isar/conf/machine/phyboard-mira.conf | 3 +-
> > meta-isar/conf/machine/qemuamd64.conf | 2 +-
> > meta-isar/conf/machine/qemuarm.conf | 2 +-
> > meta-isar/conf/machine/qemuarm64.conf | 2 +-
> > meta-isar/conf/machine/qemui386.conf | 2 +-
> > meta-isar/conf/machine/qemumipsel.conf | 2 +-
> > meta-isar/conf/machine/qemuriscv64.conf | 2 +-
> > meta-isar/conf/machine/rpi-common.conf | 1 +
> > meta-isar/conf/machine/rpi.conf | 1 +
> > meta-isar/conf/machine/sifive-fu540.conf | 2 +-
> > meta-isar/conf/machine/stm32mp15x.conf | 2 +-
> > meta-isar/conf/machine/virtualbox.conf | 2 +-
> > meta-isar/conf/machine/vmware.conf | 2 +-
> > .../qemuamd64-bullseye-cpiogz.conf | 7 -
> > .../multiconfig/qemuamd64-bullseye-tgz.conf | 7 -
> > .../conf/multiconfig/qemuamd64-bullseye.conf | 2 +
> > .../multiconfig/qemuamd64-buster-cpiogz.conf | 9 -
> > .../multiconfig/qemuamd64-buster-tgz.conf | 9 -
> > .../conf/multiconfig/qemuamd64-buster.conf | 2 +-
> > .../recipes-core/images/isar-image-ubi.bb | 4 +-
> > meta/classes/container-img.bbclass | 17 --
> > meta/classes/cpiogz-img.bbclass | 22 --
> > meta/classes/ext4-img.bbclass | 24 ---
> > meta/classes/fit-img.bbclass | 29 ---
> > .../classes/image-container-extension.bbclass | 83 -------
> > meta/classes/image-sdk-extension.bbclass | 87 --------
> > meta/classes/image.bbclass | 202
> > ++++++++++++++++-- meta/classes/imagetypes.bbclass |
> > 89 ++++++++ meta/classes/imagetypes_container.bbclass | 95
> > ++++++++ .../{vm-img.bbclass => imagetypes_vm.bbclass} | 24 +--
> > ...wic-img.bbclass => imagetypes_wic.bbclass} | 45 ++--
> > meta/classes/rootfs.bbclass | 1 +
> > meta/classes/sdk.bbclass | 137 ++++++++++++
> > meta/classes/targz-img.bbclass | 15 --
> > meta/classes/ubi-img.bbclass | 32 ---
> > meta/classes/ubifs-img.bbclass | 32 ---
> > .../{sdkchroot => sdk-files}/files/README.sdk | 0
> > .../files/configscript.sh | 0
> > .../files/gcc-sysroot-wrapper.sh | 0
> > .../files/relocate-sdk.sh | 0
> > meta/recipes-devtools/sdk-files/sdk-files.bb | 26 +++
> > meta/recipes-devtools/sdkchroot/sdkchroot.bb | 78 -------
> > testsuite/build_test/build_test.py | 2 -
> > 52 files changed, 599 insertions(+), 544 deletions(-)
> > delete mode 100644
> > meta-isar/conf/multiconfig/qemuamd64-bullseye-cpiogz.conf delete
> > mode 100644 meta-isar/conf/multiconfig/qemuamd64-bullseye-tgz.conf
> > delete mode 100644
> > meta-isar/conf/multiconfig/qemuamd64-buster-cpiogz.conf delete mode
> > 100644 meta-isar/conf/multiconfig/qemuamd64-buster-tgz.conf delete
> > mode 100644 meta/classes/container-img.bbclass delete mode 100644
> > meta/classes/cpiogz-img.bbclass delete mode 100644
> > meta/classes/ext4-img.bbclass delete mode 100644
> > meta/classes/fit-img.bbclass delete mode 100644
> > meta/classes/image-container-extension.bbclass delete mode 100644
> > meta/classes/image-sdk-extension.bbclass create mode 100644
> > meta/classes/imagetypes.bbclass create mode 100644
> > meta/classes/imagetypes_container.bbclass rename
> > meta/classes/{vm-img.bbclass => imagetypes_vm.bbclass} (89%) rename
> > meta/classes/{wic-img.bbclass => imagetypes_wic.bbclass} (86%)
> > create mode 100644 meta/classes/sdk.bbclass delete mode 100644
> > meta/classes/targz-img.bbclass delete mode 100644
> > meta/classes/ubi-img.bbclass delete mode 100644
> > meta/classes/ubifs-img.bbclass rename
> > meta/recipes-devtools/{sdkchroot => sdk-files}/files/README.sdk
> > (100%) rename meta/recipes-devtools/{sdkchroot =>
> > sdk-files}/files/configscript.sh (100%) rename
> > meta/recipes-devtools/{sdkchroot =>
> > sdk-files}/files/gcc-sysroot-wrapper.sh (100%) rename
> > meta/recipes-devtools/{sdkchroot =>
> > sdk-files}/files/relocate-sdk.sh (100%) create mode 100644
> > meta/recipes-devtools/sdk-files/sdk-files.bb delete mode 100644
> > meta/recipes-devtools/sdkchroot/sdkchroot.bb
> This patchset also fails on mc:rpi-arm-v7-bullseye:isar-image-base
> target if using BASE_REPO_FEATURES = "cache-deb-src".
Would it be ok to remove rpi-sdimg.bbclass and switch over to wic for
rpis? This class is causing headache and seems legacy from very old
days.
Henning
next prev parent reply other threads:[~2022-03-03 18:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 6:24 Adriaan Schmidt
2022-02-10 6:24 ` [PATCH 1/6] image: remove IMAGE_SUFFIX Adriaan Schmidt
2022-02-10 6:24 ` [PATCH 2/6] image: refactor SDK Adriaan Schmidt
2022-02-10 6:24 ` [PATCH 3/6] meta: introduce IMAGE_CMD_* Adriaan Schmidt
2022-02-18 14:55 ` Anton Mikanovich
2022-02-10 6:24 ` [PATCH 4/6] imagetypes: restructure files Adriaan Schmidt
2022-02-10 6:24 ` [PATCH 5/6] imagetypes: switch meta-isar to the new scheme Adriaan Schmidt
2022-02-18 14:56 ` Anton Mikanovich
2022-02-10 6:24 ` [PATCH 6/6] meta-isar: remove IMAGE_FSTYPES from multiconfig definitions Adriaan Schmidt
2022-03-03 18:35 ` [PATCH 0/6] imagetypes Anton Mikanovich
2022-03-03 18:55 ` Henning Schild [this message]
2022-03-03 19:04 ` Schmidt, Adriaan
2022-03-03 20:46 ` Henning Schild
2022-03-04 17:54 ` Anton Mikanovich
2022-03-07 6:41 ` Jan Kiszka
2022-03-08 13:50 ` Moessbauer, Felix
2022-03-31 5:56 ` Schmidt, Adriaan
2022-03-08 14:10 ` Moessbauer, Felix
2022-03-31 5:57 ` Schmidt, Adriaan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303195504.2494664c@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=adriaan.schmidt@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox