From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7071266692367646720 X-Received: by 2002:a05:600c:4ba1:b0:389:8898:2a28 with SMTP id e33-20020a05600c4ba100b0038988982a28mr1668553wmp.139.1646411626707; Fri, 04 Mar 2022 08:33:46 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:2bc2:0:b0:386:8897:8f1 with SMTP id r185-20020a1c2bc2000000b00386889708f1ls3719935wmr.2.canary-gmail; Fri, 04 Mar 2022 08:33:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJySaVvhHXeq1Yd5EtXBBiu9dxT+F34gROpjHdUIgGxNFhAdBKOdcVR0p+2j5tL/3P7OapbV X-Received: by 2002:a05:600c:3585:b0:37b:d7f3:c839 with SMTP id p5-20020a05600c358500b0037bd7f3c839mr8445857wmq.95.1646411625773; Fri, 04 Mar 2022 08:33:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1646411625; cv=pass; d=google.com; s=arc-20160816; b=gcK6wyPs/vChIxBHLbMxaAX8tMWDJua9vk6x4d8XDxvD4E4GP3HaXntd1vVCKVaHWT jKm3vmjwNH7QrPnU17hln5Qa3kgebVlrYc22in8NJ9Gd9WTYddIzvi2O0+w6yLG40ABc sdkjYtjaN2MxVYWV9TyMf2fP5dBtNwxBFp7L1wpVWN0be7Rmqb7m2f2/ZKaaA6totpca rb048jGhrJDaPKkHZp+HjHidZQ+IUf6wxGAkh5B7bC37k80GIlmAh+qCGMbKGZh7wo8A B19QNGZc511oAUWBP0cvf5V5o72Bn3e/UHAvFhsshLaRd0ZbtXriJYvBSLPVPalBst41 7PZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=u83R0KDFAbZPZXSWSbC9kGMNCHRgVnvBAwrMQ28Nonc=; b=gzUsWhuNBv8EQEEDiyRI0GS/OAlbdsSF3DultABYb4loPaPGL3dA8LtVx27WOSHEEx hsgFOTu4IVzFgk3fSmpAQOS+LJacY7asH/53Jcm6Q75A33p59YyOfPLQJA2f6b5SK4iF N8bd6wNB0zj6N1+5pgCyJBfMBn/3d1ql3uuvo5WrOskRKLKld4EqIl2OMrGrAcbYE61L zsPq7u2Glr5NpkTackhj2UzbxfeK8fhTawbUD5wM30YfrSfl1Q48KKndRpJQoDWc94Pu hED860TWYJHB+spEeauE2ZnNMYqH5KelZaEUizYolJ3O0wpEAglizNp9vGU6uav+xM8B 0pEQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=smNc7RRB; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0d::602 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0602.outbound.protection.outlook.com. [2a01:111:f400:fe0d::602]) by gmr-mx.google.com with ESMTPS id d15-20020a5d538f000000b001f04b8a304dsi301395wrv.6.2022.03.04.08.33.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Mar 2022 08:33:45 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0d::602 as permitted sender) client-ip=2a01:111:f400:fe0d::602; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=smNc7RRB; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0d::602 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VF19JLeguGgIkhJ5RfssTi2icuYVIwvd1F+Ua2b9cu75bZkpFvRCIH7t7CEV9x2FR5zx9zPipBAVr+TREDWQKAgVt/Vs4yhIx7Nqsnk6Q+VL4b6+8qcb8nIJ+emNB33dYiABosM1v3URnLoO/5MNIJeLf9YGZhwTKq4t7nbh9ciqqzVaX5HRH8TGjvxtgfMZ6GaXF+VmRR/3RilmHQujwaiZvKSQ020o5Af3mcnMxZ8SLZqRIe/aZyHkpiqiuKYwO8ixBWXVjv/7hYv7vwGXqW8rsBaMtvJj6iO/E6T4wPNbD2agPZvYp8GBbe+hkzYxdcGeW1KziKXLRC+Vah2XfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u83R0KDFAbZPZXSWSbC9kGMNCHRgVnvBAwrMQ28Nonc=; b=FKHwRki3C4CKtn3TeH/Fjmmde2sYNHVludBSxncqmlxzBdATqJe2Bi10RA4mSpE0Z8mWSnqMyVC3asaBhRcnIOFgp22evxexke9kGlyLt7SJH+Np+DJK9Z4V8DAsKi7ngddPOUmVHYc7hfqJXRoZuxSN1uvmXxd0Qgq11sNCW+e+VaME/07egTy1UXvKWhye8U1Dotvc2Xk1GuWDxL+FhG8yjTqmRVu7BRJYkgnF2IqtDMsvB/hZPDjxeKE6tfYrPalBaOKvUL76Sd3YFRJCGADhHgLawmi/FJTw9VME2EpQUpHIhDWScovyAW/P/QxRrOlX1CFwmR08CI4ZUb2osQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u83R0KDFAbZPZXSWSbC9kGMNCHRgVnvBAwrMQ28Nonc=; b=smNc7RRBJ9RfW82HupIPhk9QaPa6yZE3dl9ZV+3u6vyNb0ccxGqwdJ3yXEGK6+tsVRxyXzfFHv2/6EvvYlSC17KX75kuB9JUa41HWtGs6dgWqVE9JboZF+64TmA0MkZINMKQuScWh9Pk3p5X9qBetZthY+vvwCJ+lFi+qWQzL4r/W7bI6SRsBMk2szsYt0gTfl/ocjBIvh2TyX3CFklXVPCJZO8DH1s5hgArPgYxtKF7+otLSTeenZo5bJzkE82Mz571icnPQcggl2lljXYuInQS0IOayzqhc4eQzF39AeXQs9lZbgvpjc7e/cDLgyMguzUuaPogbEAa3zF+JVp6Ww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) by DB6PR10MB1621.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:6:37::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Fri, 4 Mar 2022 16:33:44 +0000 Received: from AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::d433:79c4:958b:1551]) by AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM ([fe80::d433:79c4:958b:1551%7]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 16:33:44 +0000 Date: Fri, 4 Mar 2022 17:33:41 +0100 From: Henning Schild To: Felix Moessbauer Cc: , , Subject: Re: [PATCH 2/4] Add ISAR version of biosplusefi WIC plugin Message-ID: <20220304173341.422e43a9@md1za8fc.ad001.siemens.net> In-Reply-To: <20220304152553.584534-3-felix.moessbauer@siemens.com> References: <20220304152553.584534-1-felix.moessbauer@siemens.com> <20220304152553.584534-3-felix.moessbauer@siemens.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0035.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::48) To AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:155::20) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93177d69-1d2d-4e7d-6873-08d9fdfcbfad X-MS-TrafficTypeDiagnostic: DB6PR10MB1621:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0ViAr15PL1QZf5//R1i3b+l36SKALNNGn+oxwAvMOMf9JzxOqSDpe0ZfX7ozQ5WqLu/xSfFOw+5Bu4RPZ8HC1CgbPciH7pv+z207u5WR2pjkWCMG6ZIhMY4EC1vt2x1qJPAljgbDUrjVzS/8xgYuiNwizhlRsOODHN8K2Q2RZcnSiWHMoHnNaRK85pBZeuKyL6qSvfUGfDbaG0ySKUqKisVntINbCDkxXqLrg2lN+cxpUgdw2EC5jbUqBEE+Ks96L+BJ7q4ASQIoW2YmsCbN1e5dld7nyqY/7AOhTvnUazd4YMJTli88LKn3e2mgKBNa1EaPHDLBSNPYf+xEkA6Ya+l/0zBLUWSo4anKkbit5XTiHpiasOoH6X+hFzjpfoHZTtJ16qPcuG6BoTypuikABEhPn2dxryEYzUtMGrqespuDRfesR3RT/JaO5ANBDUYHKSce/lE0oe8Pp1S060NbjL5SJbs/kqQ9+1rmotzkF2pRe0C+ngpg6i//pSBbnrIsjv9RHB3aj6x+K6K4iXO7T5bCubsEIqAS0ChrdU/fIGj1UCr7OxL80Sy/hVqrrv8N7eHSqm46PlMfSQrc6lzu7w/qPJbaQSAp6hJ+kj4caEStbUOtVpxJtsAvuPIvwR7OxYs22wMYbSJQVLfbjSPVjdEJKqlkLiuY9NGQDFYTXpqK9YyuMjzg2mNDSQv962TT X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(316002)(6506007)(6486002)(6666004)(6636002)(83380400001)(86362001)(6512007)(9686003)(107886003)(508600001)(1076003)(8936002)(5660300002)(44832011)(2906002)(66556008)(66946007)(66476007)(6862004)(38100700002)(186003)(4326008)(8676002)(82960400001)(2004002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?irxuqD40NDG7xz+1UaOfzinnVQ/MiSaT0j+HQ8CnhsP/WyhTd3Edif0tnJ9d?= =?us-ascii?Q?LQ8oidu4M35WVm9s6cpIPDYfXeVUKgCbWbi2cQzdhm6qCLuxrETSZRXtSxpK?= =?us-ascii?Q?Do0U5t4I1RJv7pbDTXmGVCk/bue/2Eqld5L4E1oZUNy6xoWYnaMFhgzlG0+p?= =?us-ascii?Q?G6fAfmMVxw8BkaT6N434ta+qneM0EElYcpYhRXDnQtZrH/DV7VbCpQ2NAXdO?= =?us-ascii?Q?g1luSFJxRuP8Zz1cQ9gaVCSQ9u3rjPlLjE3x+EPPohA7kc1qZFU8LDhRVeAO?= =?us-ascii?Q?u6/DCuqlEMIRhsqv84K13xSTkZY8aLkbVov9gb/0zPQAaQjk3gcOLNp718ku?= =?us-ascii?Q?lV85fyppqiw1k/tktGBBD/DIsKjcqeE3DI5gq+N1xVvOY111rNsOqil0FeRf?= =?us-ascii?Q?5cNHOViiGmiXsehjQutAgtqMFOyZJXVKcBlmNuDfxawiVrg1MsyC2ZHh69nU?= =?us-ascii?Q?3D/+ux435a4e3mgo3i0KzAq4vdV+ytNE4J2jNKufjIwsWEiVA09Lh4NTzslP?= =?us-ascii?Q?CBfE1Qc3H36gJ0D+MN9/JRS3uj5/vLKVAKxy7UjSW0Qw3AvvGcS5y27Wl8Dk?= =?us-ascii?Q?ghjvsucK2Griq6V3XYq2E6lbzSRPaf6Wo3Ime0m8PsmBNTq8pgCUbEzVYKoU?= =?us-ascii?Q?MFmOf3vcUwmGipwWNKGehnyRn1u+EzW0fUXEn3xgV5wMugLP22mhbDLmQ89L?= =?us-ascii?Q?PZOWssbjMjm6jYJLTbE4Bg6CwJNQbz0pGpxRjJ3IA/ouNKnsZPhEsQeQiNWp?= =?us-ascii?Q?2ZFZYXBPkv5oKu/6ufOgQT2Qh8+cV0F0oE+pkyPkpH9x5oNPkBgyf2cEm9WW?= =?us-ascii?Q?jhuMi3gK+cHmtsSNBHzIL71n2y9Cl9PoEw+zlEtZ0rdaytZXUcvYWbskCc5M?= =?us-ascii?Q?DtUbLl0HW2vAhQdSgReK0sj6eMXJUUR1/TPdQcgr7a0scIkHrZQac3uQw7ht?= =?us-ascii?Q?DKw6U3spL7+gOX2bP2okl7cxcR/9mWWYENnUVvADe8Qhu1p0pJH8byGRdq9P?= =?us-ascii?Q?4B29zXubdOqbhVR3wSCO4Y1ad7oh5AFa7Yc/Te1Kb/yHDgyvhUPeoh57v+nK?= =?us-ascii?Q?FcDCtN9wQduTbVS5Aas+AT37EIV2mJvdhckES76kj/RTmWYFB4HLe5PX7YGx?= =?us-ascii?Q?7PowbYsOJAvPMxYTqiE2CHsaBGzJrXf5VTvBbCU2wJ19LlRbyMFluOHVSnnv?= =?us-ascii?Q?ID5U/CIre4z7pSVGRvOSR4cu8xuQhQcsGrkNG5C4/gMVhl0EdU3G5dupZsif?= =?us-ascii?Q?srCLocOR0l9AXV0ZemF+bfowgX3Ln+N1xjJZNdyyugQ0tLUlchcf3h+Wlm6u?= =?us-ascii?Q?tF66OXrFj94D8YvVu9fTQrdyZZ2U+ZpOEn5jGJTwawg3939IGG9PKN3QKTYX?= =?us-ascii?Q?pdYnoxDOXYgbL/W891EnUostwNYAnFd6IHbxReH1Aj7J2U8ilBoa7a6DHQqZ?= =?us-ascii?Q?lToM1hdTWcmiwkBnZZf7tAaOL/7y6/W9ubvFvzwBuTMAUbwh4U+oF+DOunRE?= =?us-ascii?Q?csAzCt1PlWTDdQZRcIUwd6iNqRxw4izyMKK3tACt1OVyatN8xmMnDzL+tiLM?= =?us-ascii?Q?TXAQt/LyNm4zEyOnxD7iKMEo05Rcij+knhbvJRlFSaYEgxzsLSPxVkjoTZEc?= =?us-ascii?Q?o7eJ1RetsYL3vkUXo0t4oBCIACtINK/3G4wfD9SWk7Lkw4kFHgcDGp00DLcG?= =?us-ascii?Q?f1vgBpYbG2BIf1FeDIaUUuRNoVYL17XG504djwoawNF2O78WfHrjAwAcPOOh?= =?us-ascii?Q?zphTd+2Vdw=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93177d69-1d2d-4e7d-6873-08d9fdfcbfad X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB3459.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 16:33:44.1221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mCccsL8uZFwMuLyWqJJ0+dTc57W8SJtJ86zp5C8rLEbb76YAMpfTddGPnEMkYYdW+p+5GnJhmy5Kb03q5cgzBwJwE/LbPv4aigvw1l3mEqU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR10MB1621 X-TUID: 7qlXoX0AIa9v Am Fri, 4 Mar 2022 16:25:51 +0100 schrieb Felix Moessbauer : > This patch adds support to create a disk image that works with both > EFI and legacy bios. The biosplusefi-isar is based on the original > biosplusefi WIC plugin that internally calls the bootimg-pcbios and > bootimg-efi. By that, code duplication can be avoided. > > The generated image can be booted with EFI or legacy pcbios. > > Signed-off-by: Felix Moessbauer > --- > .../source/bootimg-biosplusefi-isar.py | 24 > +++++++------------ 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git > a/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py > b/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py > index 5bd73906..6bb15cd9 100644 --- > a/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py +++ > b/meta/scripts/lib/wic/plugins/source/bootimg-biosplusefi-isar.py @@ > -1,22 +1,14 @@ # -# This program is free software; you can > redistribute it and/or modify -# it under the terms of the GNU > General Public License version 2 as -# published by the Free Software > Foundation. +# Imported from openembedded-core > # > -# This program is distributed in the hope that it will be useful, > -# but WITHOUT ANY WARRANTY; without even the implied warranty of > -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > -# GNU General Public License for more details. > -# > -# You should have received a copy of the GNU General Public License > along -# with this program; if not, write to the Free Software > Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA > 02110-1301 USA. +# SPDX-License-Identifier: GPL-2.0-only > # > # DESCRIPTION > -# This implements the 'bootimg-biosplusefi' source plugin class for > 'wic' +# This implements the 'bootimg-biosplusefi-isar' source plugin > class for 'wic' # Please do not touch any of that, you are just asking for merge conflicts if someone finds a typo or adds words ... > # AUTHORS > # William Bourque > +# Felix Moessbauer same here, unless you are super proud to add a few "isar" here and there, not a noteworthy contrib Henning > import types > > @@ -75,10 +67,10 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin): > --ondisk sda --label os_boot --active --align 1024 > --use-uuid """ > > - name = 'bootimg-biosplusefi' > + name = 'bootimg-biosplusefi-isar' > > - __PCBIOS_MODULE_NAME = "bootimg-pcbios" > - __EFI_MODULE_NAME = "bootimg-efi" > + __PCBIOS_MODULE_NAME = "bootimg-pcbios-isar" > + __EFI_MODULE_NAME = "bootimg-efi-isar" > > __imgEFIObj = None > __imgBiosObj = None > @@ -106,7 +98,7 @@ class BootimgBiosPlusEFIPlugin(SourcePlugin): > loader = SourceFileLoader(cls.__PCBIOS_MODULE_NAME, > modulePath) mod = types.ModuleType(loader.name) > loader.exec_module(mod) > - cls.__imgBiosObj = mod.BootimgPcbiosPlugin() > + cls.__imgBiosObj = mod.BootimgPcbiosIsarPlugin() > > # Import bootimg-efi (class name "BootimgEFIPlugin") > modulePath = > os.path.join(os.path.dirname(os.path.realpath(__file__)),