From: Henning Schild <henning.schild@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: <isar-users@googlegroups.com>, <adriaan.schmidt@siemens.com>,
<jan.kiszka@siemens.com>
Subject: Re: [PATCH 4/4] test: add target for efi-plus-pcbios image type
Date: Fri, 4 Mar 2022 22:28:21 +0100 [thread overview]
Message-ID: <20220304222821.78fe9f04@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20220304174138.195de2a9@md1za8fc.ad001.siemens.net>
I think the real test would be to also modify the script starting the
VM waiting for the login prompt, it should boot both ways for at least
one image using this wks.
Henning
Am Fri, 4 Mar 2022 17:41:38 +0100
schrieb Henning Schild <henning.schild@siemens.com>:
> Am Fri, 4 Mar 2022 16:25:53 +0100
> schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
>
> > This patch switches the qemuamd64-buster mc target to generate
> > a efi-plus-pcbios image.
> >
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> > meta-isar/conf/multiconfig/qemuamd64-buster.conf | 2 ++
> > meta-isar/scripts/lib/wic/canned-wks/efi-plus-pcbios.wks | 6 ++++++
> > 2 files changed, 8 insertions(+)
> > create mode 100644
> > meta-isar/scripts/lib/wic/canned-wks/efi-plus-pcbios.wks
> >
> > diff --git a/meta-isar/conf/multiconfig/qemuamd64-buster.conf
> > b/meta-isar/conf/multiconfig/qemuamd64-buster.conf index
> > 5615198d..44fe8af9 100644 ---
> > a/meta-isar/conf/multiconfig/qemuamd64-buster.conf +++
> > b/meta-isar/conf/multiconfig/qemuamd64-buster.conf @@ -2,5 +2,7 @@
> >
> > MACHINE ?= "qemuamd64"
> > DISTRO ?= "debian-buster"
> > +WKS_FILE ?= "efi-plus-pcbios.wks"
> > +IMAGER_INSTALL += "${SYSLINUX_BOOTLOADER_INSTALL}"
> >
> > IMAGE_FSTYPES ?= "wic-img ext4-img"
> > diff --git
> > a/meta-isar/scripts/lib/wic/canned-wks/efi-plus-pcbios.wks
> > b/meta-isar/scripts/lib/wic/canned-wks/efi-plus-pcbios.wks new file
> > mode 100644 index 00000000..7b78104e --- /dev/null
> > +++ b/meta-isar/scripts/lib/wic/canned-wks/efi-plus-pcbios.wks
> > @@ -0,0 +1,6 @@
> > +# Example to show how to create an efi + pcbios image
> > +# Note, that the loader argument is mandatory. But systemd-boot
> > also works. +part /boot --source bootimg-biosplusefi-isar
> > --sourceparams="loader=grub-efi" --label boot --active --align 1024
> > +part / --source rootfs --ondisk sda --fstype=ext4 --mkfs-extraopts
> > "-T default" --label platform --align 1024 --exclude-path=boot +
> > +bootloader --timeout=0 --append "rootwait rootfstype=ext4
> > video=vesafb vga=0x318 console=tty0 console=ttyS0,115200n8"
>
> i would take more inspiration from the
> meta-isar/scripts/lib/wic/canned-wks/sdimage-efi* guys
>
> vga= and video=vesafb are very "bios" centric things, in uefi there is
> efifb and no vesa
>
> i guess
> bootloader --ptable gpt --timeout 3 --append "rootwait
> console=ttyS0,115200 console=tty0"
>
> will work just fine
>
> Henning
>
next prev parent reply other threads:[~2022-03-04 21:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 15:25 [PATCH 0/4] Add support for dual bios + efi disk generation Felix Moessbauer
2022-03-04 15:25 ` [PATCH 1/4] Copy efi-plus-pcbios script from OE Felix Moessbauer
2022-03-04 15:25 ` [PATCH 2/4] Add ISAR version of biosplusefi WIC plugin Felix Moessbauer
2022-03-04 16:33 ` Henning Schild
2022-03-04 15:25 ` [PATCH 3/4] wic: biosplusefi: make sure sub-plugins can import isarpluginbase Felix Moessbauer
2022-03-04 16:34 ` Henning Schild
2022-03-04 15:25 ` [PATCH 4/4] test: add target for efi-plus-pcbios image type Felix Moessbauer
2022-03-04 16:41 ` Henning Schild
2022-03-04 21:28 ` Henning Schild [this message]
2022-03-04 21:26 ` [PATCH 0/4] Add support for dual bios + efi disk generation Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304222821.78fe9f04@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=adriaan.schmidt@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox