From: Henning Schild <henning.schild@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: <isar-users@googlegroups.com>, <adriaan.schmidt@siemens.com>,
<jan.kiszka@siemens.com>
Subject: Re: [PATCH v2 0/6] Add support for dual bios + efi disk generation
Date: Mon, 7 Mar 2022 10:50:01 +0100 [thread overview]
Message-ID: <20220307105001.2a4438e6@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20220307064252.651695-1-felix.moessbauer@siemens.com>
LGTM
Am Mon, 7 Mar 2022 07:42:45 +0100
schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
> This patch ports the bios + efi disk support from OE to ISAR.
> By that, the generated disk can be booted both with EFI as well
> as with PCBIOS.
>
> Please note, that patches 2 and 3 do not work independently,
> but are split for easier refactoring of the isarpluginsbase class.
>
> Changes since v1:
>
> - minimize changes to bootimg-biosplusefi-isar.py
> - replace erronous commit message of hennings commit
> - rework efi-plus-pcbios WKS file to not include any bios-only options
> - update start_vm script to support modern debian distros
> - test boot of both efi and bios of efi + bios test target
>
> Best regards,
> Felix
>
> Felix Moessbauer (5):
> Add ISAR version of biosplusefi WIC plugin
> test: add target for efi-plus-pcbios image type
> add support for current debian distros in start_vm.py
> Add pcbios option to start_vm
> run vm_boot_test against EFI and PC BIOS
>
> Henning Schild (1):
> wic: make import isarpluginbase work when plugins use each other
>
> meta-isar/conf/multiconfig/qemuamd64-buster.conf | 2 ++
> .../scripts/lib/wic/canned-wks/efi-plus-pcbios.wks | 6 ++++++
> .../wic/plugins/source/bootimg-biosplusefi-isar.py | 8 ++++----
> .../lib/wic/plugins/source/bootimg-efi-isar.py | 6 ++++--
> .../lib/wic/plugins/source/bootimg-pcbios-isar.py | 6 ++++--
> testsuite/start_vm.py | 14
> +++++++++----- testsuite/vm_boot_test/vm_boot_test.py |
> 7 +++++-- 7 files changed, 34 insertions(+), 15 deletions(-)
> create mode 100644
> meta-isar/scripts/lib/wic/canned-wks/efi-plus-pcbios.wks
>
next prev parent reply other threads:[~2022-03-07 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 6:42 Felix Moessbauer
2022-03-07 6:42 ` [PATCH v2 1/6] Add ISAR version of biosplusefi WIC plugin Felix Moessbauer
2022-03-07 6:42 ` [PATCH v2 2/6] wic: make import isarpluginbase work when plugins use each other Felix Moessbauer
2022-03-07 6:42 ` [PATCH v2 3/6] test: add target for efi-plus-pcbios image type Felix Moessbauer
2022-03-07 6:42 ` [PATCH v2 4/6] add support for current debian distros in start_vm.py Felix Moessbauer
2022-03-07 6:42 ` [PATCH v2 5/6] Add pcbios option to start_vm Felix Moessbauer
2022-03-07 6:42 ` [PATCH v2 6/6] run vm_boot_test against EFI and PC BIOS Felix Moessbauer
2022-03-07 9:50 ` Henning Schild [this message]
2022-03-22 14:01 ` [PATCH v2 0/6] Add support for dual bios + efi disk generation Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307105001.2a4438e6@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=adriaan.schmidt@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox