From: Henning Schild <henning.schild@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH 1/1] Ensure generation of /etc/os-release is idempotent
Date: Thu, 10 Mar 2022 09:07:21 +0100 [thread overview]
Message-ID: <20220310090721.1ecc4cab@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20220309153444.1885926-2-felix.moessbauer@siemens.com>
ACK
Am Wed, 9 Mar 2022 16:34:44 +0100
schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
> Prior to this patch, the generation of the os-release file
> was not idempotent as there was a name-glitch in VARIAN_VERSION.
> By that, the script did not detect an existing VARIANT_VERSION
> and add one additional one per invocation.
>
> Fixes: 78b24427a050 ("classes/image-postproc: Add image version")
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> meta/classes/image-postproc-extension.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image-postproc-extension.bbclass
> b/meta/classes/image-postproc-extension.bbclass index
> 3f00c21b..ca520273 100644 ---
> a/meta/classes/image-postproc-extension.bbclass +++
> b/meta/classes/image-postproc-extension.bbclass @@ -27,7 +27,7 @@
> update_etc_os_release() { sudo tee -a '${IMAGE_ROOTFS}/etc/os-release'
> fi
> if [ -n "${OS_RELEASE_VARIANT_VERSION}" ]; then
> - sudo sed -i '/^ISAR_IMAGE_VERSION=.*/d'
> '${IMAGE_ROOTFS}/etc/os-release'
> + sudo sed -i '/^VARIANT_VERSION=.*/d'
> '${IMAGE_ROOTFS}/etc/os-release' echo "VARIANT_VERSION=\"${PV}\"" | \
> sudo tee -a '${IMAGE_ROOTFS}/etc/os-release'
> fi
next prev parent reply other threads:[~2022-03-10 8:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 15:34 [PATCH 0/1] " Felix Moessbauer
2022-03-09 15:34 ` [PATCH 1/1] " Felix Moessbauer
2022-03-10 8:07 ` Henning Schild [this message]
2022-03-21 15:00 ` [PATCH 0/1] " Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310090721.1ecc4cab@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox