From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7075360254141136896 X-Received: by 2002:a17:907:9482:b0:6da:a24e:e767 with SMTP id dm2-20020a170907948200b006daa24ee767mr22844162ejc.479.1647360682065; Tue, 15 Mar 2022 09:11:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:6a07:b0:6db:d3f5:96cc with SMTP id qw7-20020a1709066a0700b006dbd3f596ccls3169414ejc.7.gmail; Tue, 15 Mar 2022 09:11:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMmh0TA2V8KsrYDCeFiMr6WbEll6Pdo7r/yrDHlpeQd6TqCfIy/DF2BKIs3Z+4TmexB48j X-Received: by 2002:a17:906:4108:b0:6db:6b07:34c3 with SMTP id j8-20020a170906410800b006db6b0734c3mr24400771ejk.407.1647360681025; Tue, 15 Mar 2022 09:11:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647360681; cv=none; d=google.com; s=arc-20160816; b=HuNzFMDfAeqsVjlTJgLHuoiv3l03CNVaLO/Wnn2YbdpWa0rm/jMn5isUR3O66Qijwk h9NWpu4lHLffh1meyv47iQPAKr7EhoMxPIH0H2rokkkSF/wwRW+f4tPWsy4EcOp75pju DVhXWmrXqMDjL998hywjfcwTZMDIr2+4KTHev3pJQIvyl1xGMctFgYZwmvItXscyFjiT DRHyEqjsBmPFpw2JjCefUajnX+kKGI2ukFx9ZWh9GC7gWO6DamGVwquljdLEAsYUS+Le WLowJTyS+LjbCgVdTCprY9sfl7zV2/K5CCDue+kAivrcjgnsS73oEDN+sc8Scut0vCWk i68g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=FXRRsbnDr5uRZtO6Ci30HNgtlj+iybG6ef175yeeR2c=; b=YA1CKSUmdLE4pX0QrvmgwjU8XKUtNNHDVeT7p3SBSJUFzj8VyfEWKr/DAN+zok+4G2 bGmlf5Eupksg+BtaSqAHuiPvINsSsxmURW5j66OshjQs/y/z6o8KSLQ39DIDOq3aivZy VFwNxAtDo1aY4wZmgPT7fVdVQ7DPDdBvlNpGtX5MfYDEaCTGUn9iz14r/JysvTEejf3d XfGDGM23dG+c68dJ91/rNiQ5HUkvjk8cb+LjRe1w+ceCXBYgjyeuhuAX/Vubokcl3F9c wHBL0MRV0CYgEb8II5QMTogBGhgP4inr+32LZptCfnI7GquSYzuddfRGE9NNYdoigOZb y52A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id c19-20020a056402159300b00416465a807fsi1091695edv.1.2022.03.15.09.11.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Mar 2022 09:11:20 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from localhost.localdomain (mm-14-51-214-37.mgts.dynamic.pppoe.byfly.by [37.214.51.14] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 22FGBGMU018764 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Mar 2022 17:11:20 +0100 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH 2/2] rpi-sdimg: Limit volume id value Date: Tue, 15 Mar 2022 19:11:09 +0300 Message-Id: <20220315161109.29653-3-amikan@ilbers.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220315161109.29653-1-amikan@ilbers.de> References: <20220315161109.29653-1-amikan@ilbers.de> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: pCsOeZyMpw7T The volume name should be up to 11 characters long. It is longer for some rpi targets and fails with the following error: | mkfs.vfat: Label can be no longer than 11 characters | mkfs.fat 4.2 (2021-01-31) | WARNING: exit code 1 from a shell command. Limit volume name length to fix the issue. Signed-off-by: Anton Mikanovich --- meta-isar/classes/rpi-sdimg.bbclass | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meta-isar/classes/rpi-sdimg.bbclass b/meta-isar/classes/rpi-sdimg.bbclass index 1efc1c4..0b5a2a8 100644 --- a/meta-isar/classes/rpi-sdimg.bbclass +++ b/meta-isar/classes/rpi-sdimg.bbclass @@ -46,7 +46,11 @@ do_rpi_sdimg () { # Create a vfat image with boot files BOOT_BLOCKS=$(LC_ALL=C parted -s ${SDIMG} unit b print | awk '/ 1 / { print substr($4, 1, length($4 -1)) / 512 /2 }') rm -f ${WORKDIR}/boot.img - mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS + + # Limit volume name length to be 11 characters long + VOLUME_NAME=$(echo "${BOOTDD_VOLUME_ID}" | sed 's/^\(.\{11\}\).*/\1/g') + + mkfs.vfat -n "$VOLUME_NAME" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS mcopy -i ${WORKDIR}/boot.img -s ${IMAGE_ROOTFS}/boot/* ::/ # Burn Partitions -- 2.17.1