From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7075360307159236608 X-Received: by 2002:a05:651c:14f:b0:246:e2c:a985 with SMTP id c15-20020a05651c014f00b002460e2ca985mr17856462ljd.122.1647369622303; Tue, 15 Mar 2022 11:40:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9b13:0:b0:248:f7ff:c777 with SMTP id u19-20020a2e9b13000000b00248f7ffc777ls2251541lji.7.gmail; Tue, 15 Mar 2022 11:40:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5sBR8mV4lMeTadh5ezuOtAps7xAm67eOLRzHCaHjz9Xut/99pxtSOMirdjAVysngidQMO X-Received: by 2002:a2e:a80a:0:b0:248:49f:b427 with SMTP id l10-20020a2ea80a000000b00248049fb427mr18207368ljq.301.1647369620795; Tue, 15 Mar 2022 11:40:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647369620; cv=none; d=google.com; s=arc-20160816; b=XvIGPOHcdATlUqU7l9LNqJ60A9SKZWLMkAo68CWHq/CngRAl31cBLmmJd5XCOgBg4b GfugOCzLq5BtP6i4CVMowqKAHQ6Zr9+nfyD8rcG96swn1SKM/MnilB5N1UnvpMG6FnXK uTaCP6dO4ah5eYopDqwIyqPH2uoqmizRAEaA08u5ZUFprYlFXIjLWeDUUdGI2PJoPN8c BV6cjUWVANvZke5YKczGig4gL934FEU3gFVTXzmxjsdzO1AIMBBytC3lublHbdq4Eanh HlL5tMaKukVQD6ylxKVK2UL7mtKqi+muGtr3aGqgo/DM2BPmJKSakem4iuE6e/iFtYsj Bm3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=CD7+9sWjye3KbaZ1sX/tVL/9fePF7ZZcx8sU3az+vMA=; b=e0MPt3febvf7X1bKSmTKQ5ywQ4uLo0r+dHDloYOKdxL9pSxebKwdWpk3VTUqLJH9eb UjVCQur95s6v8zUhHUZQ3ROVNHjcmBORbTeF99mHHEUpXHDQYfZyZiIwmzIB9PmWHeOK iaWFtWn/yTyxqmGI/ZqvlCLBsjyz/sN15lMx+0/X8b2s/AuZ+XxFXEYHEDBKOB6jvu17 cOXcR1viT4KteABNGooDf/DbtH+Pj+bSfwBh5vEEMwJ+iiXspyvHUQNXU/nAwuixhQ0C BvGhDLZjiK4xHgolhmFytQGqp2qkNMCgpq/sA0jNZgj/rjYtaKKJfSKGkXWV5DcIaTy7 3JYw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id p16-20020a2e9ad0000000b00247f6f7df5esi1397427ljj.7.2022.03.15.11.40.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Mar 2022 11:40:20 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from localhost.localdomain (mm-14-51-214-37.mgts.dynamic.pppoe.byfly.by [37.214.51.14] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 22FIeEQM019349 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Mar 2022 19:40:19 +0100 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH v2 2/2] rpi-sdimg: Limit volume id value Date: Tue, 15 Mar 2022 21:40:06 +0300 Message-Id: <20220315184006.2479-3-amikan@ilbers.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220315184006.2479-1-amikan@ilbers.de> References: <20220315184006.2479-1-amikan@ilbers.de> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: z52FhN93+gEa The volume name should be up to 11 characters long. It is longer for some rpi targets and fails with the following error: | mkfs.vfat: Label can be no longer than 11 characters | mkfs.fat 4.2 (2021-01-31) | WARNING: exit code 1 from a shell command. Limit volume name length to fix the issue. Signed-off-by: Anton Mikanovich --- meta-isar/classes/rpi-sdimg.bbclass | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meta-isar/classes/rpi-sdimg.bbclass b/meta-isar/classes/rpi-sdimg.bbclass index 1efc1c4..b13611b 100644 --- a/meta-isar/classes/rpi-sdimg.bbclass +++ b/meta-isar/classes/rpi-sdimg.bbclass @@ -46,7 +46,11 @@ do_rpi_sdimg () { # Create a vfat image with boot files BOOT_BLOCKS=$(LC_ALL=C parted -s ${SDIMG} unit b print | awk '/ 1 / { print substr($4, 1, length($4 -1)) / 512 /2 }') rm -f ${WORKDIR}/boot.img - mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS + + # Limit volume name length to be 11 characters long + VOLUME_NAME=$(echo "${BOOTDD_VOLUME_ID}" | cut -c -11) + + mkfs.vfat -n "$VOLUME_NAME" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS mcopy -i ${WORKDIR}/boot.img -s ${IMAGE_ROOTFS}/boot/* ::/ # Burn Partitions -- 2.17.1