Re: [PATCH] Add missing WicError import

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 16 Mar 2022 12:03:36 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> 16.03.2022 11:24, Henning Schild wrote:
> > This is already done in all the plugins we have in tree. The file
> > you are touching here is "what we need to fork", and we do not need
> > that. Or does the import in the existing plugins also not work?
> >
> > In case you need that in your custom plugin, just include the import
> > into your own plugin. Maybe you do not even need that "base" lib for
> > your custom plugin. Since it is ... what we need to fork. Not what
> > we might need for our own plugins.
> >
> > regards,
> > Henning  
> 
> I agree we should add this import of WicError in isarpluginbase.py 
> because it
> is really used inside it.

Ah yes, ACK!

Henning

> Any script using isar_get_filenames() can not care about its internal
> implementation and can not even use WicError. So the requirement of 
> importing
> something not even used looks wrong in that case.
>